RFR: 7903659 Verify Problemlist contents [v6]

Ludvig Janiuk lujaniuk at openjdk.org
Thu Mar 28 09:10:56 UTC 2024


On Wed, 27 Mar 2024 18:08:24 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Ludvig Janiuk has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - oops
>>  - fix strange bash contruct
>
> src/share/classes/com/sun/javatest/regtest/tool/ExcludeFileVerifier.java line 93:
> 
>> 91:         if (line.equals("")) return true;
>> 92:         if (line.charAt(0) == '#') return true;
>> 93:         return false;
> 
> Could be simplified to 
> 
> return line.isBlank() || line.trim().startsWith("#");

done

> src/share/classes/com/sun/javatest/regtest/tool/Tool.java line 1447:
> 
>> 1445: 
>> 1446:         if (hadErrors) {
>> 1447:             error("Cannot run because an exclude list had errors, printed above. Either resolve them or remove the exlude list.");
> 
> typo: exlude

done

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/181#discussion_r1542553938
PR Review Comment: https://git.openjdk.org/jtreg/pull/181#discussion_r1542554135


More information about the jtreg-dev mailing list