RFR: 7903730: Enhance the agentvm to be tolerant to unexpected connection on the port the Agent listens on for handshake with the AgentServer [v3]
Jaikiran Pai
jpai at openjdk.org
Tue May 21 01:58:13 UTC 2024
On Mon, 20 May 2024 23:14:02 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
> Use Throwable.addSuppressed -- it is for exactly this situation.
But we wouldn't be throwing any exception to which we would be adding this as a suppressed exception. This failure is during close()ing a connection on which we either had a read timeout or an IOException when reading off it. We log that failure a few lines above this and then go and close this connection and then attempt to accept() a next connection (if any).
I can update this catch block to log a message which states the close() failed, along with the reason. Is that reasonable?
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/195#discussion_r1607485242
More information about the jtreg-dev
mailing list