RFR: 7903738 : jtr.xml logs produced with -xml argument do not contain compilation failure justification

[Jiří Vaněk]

On Tue, 28 May 2024 12:47:29 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> jtr.xml files generated while using -xml flag don't contain any info about why the compilation failed although the info is present in jtr files. This can be solved by looking for the compilation failure in case there is no main section -> the main has not been executed -> failure occurred during compilation
>
> Even if we add another case in the future, I'd prefer to keep the current implementation stable by only adding another expression to the `if` branch. From:
> `if (titles[i].equals("main") || titles[i].equals("shell")) {`
> to:
> `if (titles[i].equals("main") || titles[i].equals("shell") || titles[i].equals("compile")) {`
> 
> The comment:
>> `// we are looking primarily for either a "main" section or a "shell" section in jtr log`
> 
> should be reworded to something that handles all current and future cases. For example:
>> `// try to find and return first output from the following sequence of title names`
> 
> Nit: the previous commit touching this line (https://github.com/openjdk/jtreg/commit/8c105f2953edac0881819131f5f6836bda06ef25) introduced an `import java.util.Arrays;` statement which wasn't used back then. Can it be removed?

I agree with @sormuras  the `if (titles[i].equals("main") || titles[i].equals("shell") || titles[i].equals("compile")) {` is better.
Also as we discussed yesterday, if compilation fails, there si nothing in main.

Please remove that unused import.

@sormuras  thanx a lot for prompt review!

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/198#issuecomment-2135298268