RFR: 7903443: Propagate verbose flag to agents [v2]
Christian Stein
cstein at openjdk.org
Wed May 29 04:09:13 UTC 2024
On Tue, 28 May 2024 21:27:56 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> src/share/classes/com/sun/javatest/regtest/tool/JarManager.java line 77:
>>
>>> 75: InputStream in = getClass().getResourceAsStream("jars.properties");
>>> 76: if (in == null) {
>>> 77: throw new Error("Can't find jars.properties");
>>
>> What's the reason for dropping this?
>
> I guess it is expected to be available, by construction in the build, so this was effectively just an assertion, right?
Yes. Without this assertion in place, an IDE-based launch of `jtreg`'s main program is possible. For example, here are the options for a test run for all self-tests in `test/junit`:
-Djunit.path=<ABSOLUTE-PATH-TO>/jtreg/build/deps/junit/junit-platform-console-standalone-1.10.2.jar
com.sun.javatest.regtest.Main
-v:pass,error,fail
test/junit
I tried to provide an empty `jars.properties` instead of removing the check, but that didn't work out.
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/187#discussion_r1618150482
More information about the jtreg-dev
mailing list