RFR: 7903883: --verify-exclude test existence and format checks are broken

[Christian Stein]

On Wed, 13 Nov 2024 09:11:06 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:

> The way this feature selected "the full set of tests" was actually getting "the set of tests to be run". But often, we run some subset through either specifying test files, folders, or groups. Our problemlist files will still have entries for other tests we were not running right now.
> 
> As a solution, --verify-exclude needs to compute the maximal set of tests that could be run for all test suites that any of the tests being run are a part of. I've implemented this by creating a dummy testmanager and passing no parameters to it.
> 
> Additionally, the regex for problemlist format had a typo.

Looks good so far, left some requests regarding a `TODO` comment and optional verbose output.

src/share/classes/com/sun/javatest/regtest/tool/Tool.java line 1184:

> 1182: 
> 1183:         // TODO We know set of suites here, could save/do dummy
> 1184: 

Suggestion:



Please don't add `TODO` comments — just do it, or don't.

src/share/classes/com/sun/javatest/regtest/tool/Tool.java line 1429:

> 1427:             for (Iterator<TestResult> iter = getResultsIterator(params); iter.hasNext(); ) {
> 1428:                 TestResult tr = iter.next();
> 1429:                 out.println(tr.getTestName());

This print statement would now produce many output lines by default - perhaps, re-add and guard it via the `--verbose` flag?

src/share/classes/com/sun/javatest/regtest/tool/Tool.java line 1436:

> 1434:         List<String> validTestNames = new ArrayList<String>();
> 1435:         for (RegressionTestSuite ts: dummyTestManager.getTestSuites()) {
> 1436:             out.println(i18n.getString("main.tests.suite", ts.getRootDir()));

Guard this output line by the `--verbose` option?

-------------

Changes requested by cstein (Committer).

PR Review: https://git.openjdk.org/jtreg/pull/236#pullrequestreview-2433657556
PR Review Comment: https://git.openjdk.org/jtreg/pull/236#discussion_r1840650394
PR Review Comment: https://git.openjdk.org/jtreg/pull/236#discussion_r1840668862
PR Review Comment: https://git.openjdk.org/jtreg/pull/236#discussion_r1840658364