RFR: 7903193: [jtreg] build and test failures using JDK 18 [v4]
Jaikiran Pai
jpai at openjdk.org
Thu Oct 17 13:37:27 UTC 2024
On Sun, 22 Sep 2024 10:58:50 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>>
>> - merge latest from master branch
>> - Jon's review - maintain alphabetical order of environment variables in build script
>> - better code comment
>> - consider java version >= 18
>> - merge latest from master branch
>> - 7903193: [jtreg] build and test failures using JDK 18
>
> I've now updated the PR after merging against latest master. I have verified that with these changes, all self tests continue to pass with Java versions less than 18 as well as greater than 18, both when headless is true and when headless is false.
> @jaikiran Can you please replace the 17 with a 21 in https://github.com/jaikiran/jtreg/blob/60809c4da0f2ef18540df4328113f898d032497b/.github/workflows/test.yml#L24
>
> That should make a) the test workflow download an Oracle JDK and b) also run the build (compilation and tests) on a JDK 18+.
I wasn't sure if we should do that change as part of this PR, so I created a separate branch which includes the changes in this PR plus the change to the JDK version in the github workflow file. That branch's job is currently in progress here https://github.com/jaikiran/jtreg/actions/runs/11385998691/job/31677151971
-------------
PR Comment: https://git.openjdk.org/jtreg/pull/190#issuecomment-2419563169
More information about the jtreg-dev
mailing list