RFR: 7903193: [jtreg] build and test failures using JDK 18 [v6]

Jaikiran Pai jpai at openjdk.org
Thu Oct 17 13:37:27 UTC 2024


On Thu, 17 Oct 2024 11:03:36 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this test only changes, which proposes to address the current failure in jtreg self tests when Java 18 or higher is used to build and test jtreg?
>> 
>> As noted in the following issues:
>> https://bugs.openjdk.org/browse/CODETOOLS-7903193
>> https://bugs.openjdk.org/browse/CODETOOLS-7903646
>> https://bugs.openjdk.org/browse/CODETOOLS-7903645
>> 
>> these self tests in jtreg which rely on SecurityManager, no longer pass when used with Java 18 or higher, since starting Java 18 the setting of SecurityManager throws an UnsupportedOperationException.
>> 
>> Changes in this PR, include updates to test files which check for the Java version being used to run these tests and then decide whether or not to include some specific tests that only pass when a SecurityManager is set.
>> 
>> I've run these changes locally (on macos M1) and on a linux setup, both with Java 17  and Java 21. The tests all pass on these versions.
>> 
>> I've also run this on a headless system to make sure the `ReportOnlyTest.gmk` does indeed properly check the correct values on a headless system (both Java 17 and 21). I think this change should address the issue that Ludvig @LudwikJaniuk had run into.
>
> Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits:
> 
>  - merge latest from master
>  - Fix test pass/fail count checks
>  - merge latest from master branch
>  - merge latest from master branch
>  - Jon's review - maintain alphabetical order of environment variables in build script
>  - better code comment
>  - consider java version >= 18
>  - merge latest from master branch
>  - 7903193: [jtreg] build and test failures using JDK 18

If that build succeeds and if you think that we should include that change in this PR, let me know and I'll update this PR to include that change.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/190#issuecomment-2419567119


More information about the jtreg-dev mailing list