RFR: 7903871: Typo bug in doc/building.md of 'Rebuilding faster'
Christian Stein
cstein at openjdk.org
Mon Oct 21 08:50:59 UTC 2024
On Mon, 21 Oct 2024 08:23:03 GMT, SendaoYan <syan at openjdk.org> wrote:
> Hi all,
> The document of `doc/building.md` at chapter `Rebuilding faster with build/make.sh` has a typo bug, which may cause misunderstand.
> Anyone wants to skip download dependencies, the option `--skip-download` should passed to `make/build.sh` explicitly. Because the default valune of variable `SKIP_DOWNLOAD` in [build-common.sh](https://github.com/openjdk/jtreg/blob/master/make/build-support/build-common.sh#L155) is empty, unless execute `make/build.sh` with `--skip-download` option.
> Only fix the document bug, no risk.
For the workflow in the description works as expected and documented:
$ bash make/build.sh
[build.sh][INFO] CYGWIN_OR_MSYS=0
[...]
/bin/rm -rf /workspaces/jtreg/build/images/jtreg.zip
cd /workspaces/jtreg/build/images; /usr/bin/zip -rq /workspaces/jtreg/build/images/jtreg.zip jtreg
$ bash build/make.sh
make: Nothing to be done for 'default'.
Noted the difference in (first call) `make/build.sh` and (second call) `build/make.sh`?
-------------
PR Comment: https://git.openjdk.org/jtreg/pull/232#issuecomment-2426018768
More information about the jtreg-dev
mailing list