RFR: 7903193: [jtreg] build and test failures using JDK 18 [v7]
Jan Lahoda
jlahoda at openjdk.org
Mon Oct 21 10:29:22 UTC 2024
On Mon, 21 Oct 2024 09:24:37 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this test only changes, which proposes to address the current failure in jtreg self tests when Java 18 or higher is used to build and test jtreg?
>>
>> As noted in the following issues:
>> https://bugs.openjdk.org/browse/CODETOOLS-7903193
>> https://bugs.openjdk.org/browse/CODETOOLS-7903646
>> https://bugs.openjdk.org/browse/CODETOOLS-7903645
>>
>> these self tests in jtreg which rely on SecurityManager, no longer pass when used with Java 18 or higher, since starting Java 18 the setting of SecurityManager throws an UnsupportedOperationException.
>>
>> Changes in this PR, include updates to test files which check for the Java version being used to run these tests and then decide whether or not to include some specific tests that only pass when a SecurityManager is set.
>>
>> I've run these changes locally (on macos M1) and on a linux setup, both with Java 17 and Java 21. The tests all pass on these versions.
>>
>> I've also run this on a headless system to make sure the `ReportOnlyTest.gmk` does indeed properly check the correct values on a headless system (both Java 17 and 21). I think this change should address the issue that Ludvig @LudwikJaniuk had run into.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>
> use Java 21 in github workflow
Seems fine to me.
I'll note that you can enable the `setSecurityManager` with `-Djava.security.manager=allow` on the command line, for JDK 18+, until https://github.com/openjdk/jdk/pull/21498 is integrated. But there presumably is no strong reason to do so for the tests.
-------------
Marked as reviewed by jlahoda (Lead).
PR Review: https://git.openjdk.org/jtreg/pull/190#pullrequestreview-2381594350
More information about the jtreg-dev
mailing list