RFR: 7903808: IOOBE in compile action when processing class files only

Jaikiran Pai jpai at openjdk.org
Thu Sep 5 09:20:03 UTC 2024


On Fri, 30 Aug 2024 19:28:22 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this fix preventing an `IndexOutOfBoundsException` in the compile action when processing class files only.
> 
> As an library used by a test might need `--enable-preview` it is possible that the `insertPos` variable is still assigned with the value `-1`: the `for (String currArg : args) { ... }` loop may exit normally without setting a valid insertion position.
> 
> This change checks for `-1` values and use `0` instead in order to prepend `--enable-preview` and `--source N` before any variadic arguments.

Hello Christian, this looks OK to me. Would it be possible to add a self test for this?

-------------

Marked as reviewed by jpai (Committer).

PR Review: https://git.openjdk.org/jtreg/pull/224#pullrequestreview-2282348217


More information about the jtreg-dev mailing list