RFR: 7903813: Tag enablePreview with false should take precedence [v4]
Christian Stein
cstein at openjdk.org
Tue Sep 10 05:55:17 UTC 2024
On Mon, 9 Sep 2024 22:11:50 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Please review this change to let tests with `@enablePreview false` take precedence over libraries that require preview features being enabled.
>>
>> Note that the [PreviewHiddenClass](https://github.com/openjdk/jdk/blob/f6d7e30b84fedbf42077526610ba7a5bcfaece4c/test/jdk/java/lang/invoke/defineHiddenClass/PreviewHiddenClass.java#L34-L35) test should receive an explicit `enablePreview=false` tag line (in addition to the comment).
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>
> Update BuildAction.java
Thank you for the review, Jon.
> Maybe you can change the GHA tests to use JDK 11 for tests.
I'll look into that - ideally, we would have all those JDKs installed/available on GHA when running `jtreg`'s self-tests:
- Warning: JDK8HOME not set; some tests may not have been executed
- Warning: JDK9HOME not set; some tests may not have been executed
- Warning: JDK10HOME not set; some tests may not have been executed
- Warning: JDK14HOME not set; some tests may not have been executed
- Warning: JDK18HOME not set; some tests may not have been executed
-------------
PR Comment: https://git.openjdk.org/jtreg/pull/225#issuecomment-2339677255
More information about the jtreg-dev
mailing list