RFR: 7903961: Make default timeout configurable [v2]
Jaikiran Pai
jpai at openjdk.org
Fri Apr 4 01:48:04 UTC 2025
On Thu, 3 Apr 2025 18:48:16 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Please review this change replacing the hard-coded `120` seconds default timeout for test actions with a configurable solution parsing a custom default value from `TEST.ROOT` and `TEST.properties` files:
>>
>>
>> timeout.default.seconds=360
>>
>>
>> Especially in combination with "JUnit.dirs" and "TestNG.dirs", where all actions directives found in a test file are ignored, is helpful.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>
> Simplify implementation, don't expose default timeout value
src/share/classes/com/sun/javatest/regtest/exec/RegressionScript.java line 1351:
> 1349: private final TestProperties properties;
> 1350:
> 1351: public RegressionScript(TestProperties properties) {
I did not notice this in the previous round, sorry, but this constructor can be `private` like the other one that previously was.
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/253#discussion_r2027967296
More information about the jtreg-dev
mailing list