RFR: 7903961: Make default timeout configurable [v2]
Jaikiran Pai
jpai at openjdk.org
Fri Apr 4 06:32:01 UTC 2025
On Thu, 3 Apr 2025 18:48:16 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Please review this change replacing the hard-coded `120` seconds default timeout for test actions with a configurable solution parsing a custom default value from `TEST.ROOT` and `TEST.properties` files:
>>
>>
>> timeout.default.seconds=360
>>
>>
>> Especially in combination with "JUnit.dirs" and "TestNG.dirs", where all actions directives found in a test file are ignored, is helpful.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>
> Simplify implementation, don't expose default timeout value
These changes look OK to me.
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jtreg/pull/253#pullrequestreview-2741897932
More information about the jtreg-dev
mailing list