Integrated: 7903989: Default to no error if existing, make parent directories as needed
Christian Stein
cstein at openjdk.org
Tue Apr 15 15:02:13 UTC 2025
On Mon, 14 Apr 2025 15:44:55 GMT, Christian Stein <cstein at openjdk.org> wrote:
> Prior this change, most usages of the `$(MKDIR)` variable in jtreg's self-tests had to add `-p` in order to not fail with an "error if existing, make parent directories as needed". Many usages are lacking the flag and in concurrent test scenarios, this leads to flaky tests.
>
> This PR appends `-p` to each expansion of `$(MKDIR)`. Hard-coded `-p` will be removed; stray/duplicate `-p` flag don't seem to be a problem for `mkdir`'s option parser. I didn't see any "-p specifed more than once" warnings.
>
> This PR also cleans up redundant `-f` and `-rf` arguments from `$(RM) ...` calls, as they are very close in nature and location of the `$(MKDIR)` calls, as `Defs.gmk` declares `RM` to expand with `-rf`.
This pull request has now been integrated.
Changeset: 19cdb840
Author: Christian Stein <cstein at openjdk.org>
URL: https://git.openjdk.org/jtreg/commit/19cdb8404930c3025bd48436907ccc65bd133fee
Stats: 156 lines in 50 files changed: 0 ins; 0 del; 156 mod
7903989: Default to no error if existing, make parent directories as needed
Reviewed-by: iris
-------------
PR: https://git.openjdk.org/jtreg/pull/259
More information about the jtreg-dev
mailing list