RFR: 7903981: Support easy way to use current class name for test actions [v6]
Christian Stein
cstein at openjdk.org
Tue Apr 22 07:54:40 UTC 2025
On Mon, 14 Apr 2025 13:13:46 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Please review this change to allow an easier way to use current class name for test actions.
>>
>> Test authors usually specify the name of a test class to be run by `jtreg` 1:1 in a `@run` action directive. This PR introduces the new test property `test.main.class` and tries to initialize it with the fully-qualified class name of the test class. It is composed of the package name and the truncated file name of `.java` source file passed to `jtreg`: `SomeTest.java` becomes `SomeTest`
>>
>> Example for `Test.java` in the unnamed package:
>> - `@run main Test` - `@run main ${test.main.class}`
>>
>> Example for `Test.java` declaring `package p;`:
>> - `@run main p.Test` - `@run main ${test.main.class}`
>>
>> See also: [CODETOOLS-7902352: Support use of ${property.name} in action args](https://bugs.openjdk.org/browse/CODETOOLS-7902352)
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>
> Use canonical expression for expecting non-zero result
test/smartActionArgs/SmartActionArgs.gmk line 31:
> 29: $(JTREG_IMAGEDIR)/bin/jtreg
> 30: if [ -d $(@:%.ok=%) ]; then $(CHMOD) -R +w $(@:%.ok=%) && $(RM) $(@:%.ok=%) ; fi
> 31: $(MKDIR) -p $(@:%.ok=%)
Suggestion:
$(MKDIR) $(@:%.ok=%)
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/257#discussion_r2053541473
More information about the jtreg-dev
mailing list