RFR: 7903934: Add support for query strings to the IntelliJ plugin [v4]

Jorn Vernee jvernee at openjdk.org
Thu Feb 6 16:00:27 UTC 2025


On Thu, 6 Feb 2025 14:45:35 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>> 
>>  - Merge branch 'master' into RunMethods
>>  - update notes
>>  - Update wrapper validation action
>>  - Use qualified class name, for the sake of nested test classes
>>  - move query string text field + tie to file selection
>>  - use new query string format
>>  - Support query string in idea plugin
>
> plugins/idea/src/main/java/com/oracle/plugin/jtreg/configuration/producers/JTRegClassConfigurationProducer.java line 69:
> 
>> 67:     }
>> 68: 
>> 69:     private static String nameForElement(PsiElement element) {
> 
> What are these changes for? These seems unrelated to the binary name problem?

These are creating a name for the run configuration. For instance, currently when you create a run configuration, it will always have the same name as the file, but with these changes, when you create a configuration for a method, the name will be e.g. `TestDowncallScope::testDowncall`. This should make it easier to tell apart a run configuration for a whole class from one for an individual method.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/240#discussion_r1944982832


More information about the jtreg-dev mailing list