RFR: 7903519 : jtreg/jtharness is missing features for basic crash testing
Jaikiran Pai
jpai at openjdk.org
Thu Feb 13 17:01:27 UTC 2025
On Thu, 13 Feb 2025 16:49:00 GMT, andrlos <duke at openjdk.org> wrote:
>> Hello @andrlos, looking at that code you pasted:
>>
>> if(originalStatus.getType() == Status.FAILED && ! this.didCrash(td)){
>> newStatus = new Status(Status.PASSED, "Just a regular failure.");
>> }
>>
>> It looks odd to be marking a failed test as successful. Furthermore, doesn't a crashed JVM result in test status to be `Status.ERROR`?
>
> @jaikiran @sormuras I believe that I answered all your questions and addressed all your comments and currently I am still waiting for a constructive discussion to take place.
Hello @andrlos, sorry to keep you waiting. I don't have a strong opinion or objection to this change. At the same time, I don't have enough knowledge of this code to approve this change. So other than asking some basic questions (which I did), I don't feel qualified enough to officially review this proposed enhancement.
-------------
PR Comment: https://git.openjdk.org/jtreg/pull/235#issuecomment-2657217955
More information about the jtreg-dev
mailing list