RFR: 7903953: Use scratch directory for JUnit's TempDir annotation [v2]
Jaikiran Pai
jpai at openjdk.org
Tue Feb 25 07:31:04 UTC 2025
On Mon, 24 Feb 2025 11:28:44 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> The assertion(s) in the test only make sense, when `jtreg` runs the test via its `JUnitRunner`. The `test.name` system property is an indicator that `jtreg` runs the test, I could switch to another one documented here: https://openjdk.org/jtreg/tag-spec.html#testvars
>
> Perhaps it would be better to replace this non-obvious declarative guard with a programmatic `Assumptions....` statement within the test method. 🤔
> The assertion(s) in the test only make sense, when jtreg runs the test via its JUnitRunner.
Since this is a self test in the jtreg project, would it be the case that a test marked as `@run junit` will always be run by the `JUnitRunner`? So even the assumption I think is probably isn't needed.
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/248#discussion_r1969125262
More information about the jtreg-dev
mailing list