RFR: 7903920: Support building jtreg on FreeBSD
Christian Stein
cstein at openjdk.org
Fri Jan 24 20:49:35 UTC 2025
On Sat, 14 Dec 2024 11:03:38 GMT, snake66 <duke at openjdk.org> wrote:
>> On FreeBSD we need to use GNU gmake instead of the BSD make program.
>
> This work is done on behalf of The FreeBSD Foundation. https://oca.opensource.oracle.com/api/v1/members/public?&search=FreeBSD
Thanks for creating the PR, @snake66 - can you please create a JBS issue for this change? Happy to help if needed: https://bugs.openjdk.org/browse/CODETOOLS
@jonathan-gibbons wrote in https://github.com/openjdk/jtreg/commit/8a66b3b8f8f844f442a74f1d651cfc03f9231bb7#commitcomment-150335752
> Stylistically, it would be more in keeping to determine the absolute path on FreeBSD, instead of just relying on $PATH. You can do this either by checking the OS name or by checking in standard well-known places in order to determine an absolute path. See examples of other variables nearby.
Seems like this change avoids relying on `$PATH`. Do you also consider doing something similar for `zip` and `unzip` in this change set?
-------------
PR Comment: https://git.openjdk.org/jtreg/pull/237#issuecomment-2543058251
More information about the jtreg-dev
mailing list