RFR: 7903935: --verify-exclude existence check misses tests with failing requires

[Christian Stein]

On Tue, 21 Jan 2025 14:20:25 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:

> The current implementation relies on
>   getResultsIterator
> which in turn calls into
>   TestResultTable.getIterator(filters)
> passing into jtharness. That seems to currently filter out tests that don't meet the local "requires" criteria. Thus we fail to collect all "existing" tests in to a set to compare with.
> 
> The fix seems to be to explicitly pass an empty list of filters into
>   TestResultTable.getIterator(filters)
> as this will make
>   TRT_Iterator.wouldAccept()
> accept every test.

Looks good to me.

-------------

Marked as reviewed by cstein (Committer).

PR Review: https://git.openjdk.org/jtreg/pull/243#pullrequestreview-2583357092