Integrated: 7903935: --verify-exclude existence check misses tests with failing requires

Ludvig Janiuk lujaniuk at openjdk.org
Fri Jan 31 09:13:00 UTC 2025


On Tue, 21 Jan 2025 14:20:25 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:

> The current implementation relies on
>   getResultsIterator
> which in turn calls into
>   TestResultTable.getIterator(filters)
> passing into jtharness. That seems to currently filter out tests that don't meet the local "requires" criteria. Thus we fail to collect all "existing" tests in to a set to compare with.
> 
> The fix seems to be to explicitly pass an empty list of filters into
>   TestResultTable.getIterator(filters)
> as this will make
>   TRT_Iterator.wouldAccept()
> accept every test.

This pull request has now been integrated.

Changeset: 60909fe0
Author:    Ludvig Janiuk <lujaniuk at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/60909fe0785f1d1a3397dd644de7b42c3542121a
Stats:     10 lines in 1 file changed: 9 ins; 0 del; 1 mod

7903935: --verify-exclude existence check misses tests with failing requires

Reviewed-by: cstein, iris

-------------

PR: https://git.openjdk.org/jtreg/pull/243


More information about the jtreg-dev mailing list