From lmesnik at openjdk.org Tue Jul 1 14:21:59 2025 From: lmesnik at openjdk.org (Leonid Mesnik) Date: Tue, 1 Jul 2025 14:21:59 GMT Subject: Integrated: 7902847: Class directory of a test case should be always used to compile a library In-Reply-To: References: Message-ID: On Tue, 25 Mar 2025 17:46:40 GMT, Leonid Mesnik wrote: > The classes from test libraries can be compiled implicitly as a test dependency or explicitly with @build tag. > > For first case > Test library used as a source path during test compilation and library classes as well as test classes are compiled into class directory. > > For 2nd case > The library classes are compiled using @build tag and library classes are placed into some shared location. > > These 2 cases might be mixed in the single test and can have part of library classes compiled into shared directory and part compiled into test classes directory. > > jtreg uses classfiles to check if source code should be compiled. Let we have 2 classes LibA and Lib that extends LibA. > So if class LibA might be compiled into test class directory while LibB is compiled into library directory. Later jtreg can try to use LibB class without and compilation because LibB already exists. Thus the CNFE will be thrown. > > The another possible problem, is that the library code might include test code for libraries like "/" and "/vmTestbase" > so any test classes with same packages would be compiled into the same location because they are treated as library classes. So for tree like this: > test1/Test.java > test2/Test.java > with both tests having > > @library "/" > @build Test > > we are going just to have one Test class in library directory. > > The only reliable fix would be don't use shared class directory at all and compile all libraries for each test. Although it looks like huge performance overhead, the impact is low. The libraries are not often compiled using build tag. > > Times for tier1 execution with fix: > test-results/jtreg_test_lib_test_tier1/text/timeStats.txt:Total elapsed time 0m 28s > test-results/jtreg_test_hotspot_jtreg_tier1/text/timeStats.txt:Total elapsed time 18m 14s > test-results/jtreg_test_jdk_tier1/text/timeStats.txt:Total elapsed time 15m 8s > test-results/jtreg_test_langtools_tier1/text/timeStats.txt:Total elapsed time 7m 59s > > and before fix > test-results/jtreg_test_lib_test_tier1/text/timeStats.txt:Total elapsed time 0m 32s > test-results/jtreg_test_hotspot_jtreg_tier1/text/timeStats.txt:Total elapsed time 17m 51s > test-results/jtreg_test_jdk_tier1/text/timeStats.txt:Total elapsed time 14m 49s > test-results/jtreg_test_langtools_tier1/text/timeStats.txt:Total elapsed time 7m 56s > > The full fix might require more testing and adding testcase. > Please note that there are plans to work on the > https://bugs.openjdk.org/browse/CODETOOLS-7903882 > and > https://bugs.openjdk.org/browse/JDK-8346058 > So ... This pull request has now been integrated. Changeset: 0a8cbb5c Author: Leonid Mesnik Committer: Christian Stein URL: https://git.openjdk.org/jtreg/commit/0a8cbb5cfa6f0d82db4bae5843a066529c39dbf4 Stats: 271 lines in 13 files changed: 225 ins; 12 del; 34 mod 7902847: Class directory of a test case should be always used to compile a library Reviewed-by: cstein ------------- PR: https://git.openjdk.org/jtreg/pull/256 From cstein at openjdk.org Tue Jul 1 16:01:15 2025 From: cstein at openjdk.org (Christian Stein) Date: Tue, 1 Jul 2025 16:01:15 GMT Subject: RFR: 7904053: Update version to 8.0 Message-ID: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> Please review this trivial change updating the version to `8.0`; the upcoming release version of jtreg. ------------- Commit messages: - 7904053: Update version to 8.0 Changes: https://git.openjdk.org/jtreg/pull/271/files Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=271&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904053 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jtreg/pull/271.diff Fetch: git fetch https://git.openjdk.org/jtreg.git pull/271/head:pull/271 PR: https://git.openjdk.org/jtreg/pull/271 From iris at openjdk.org Tue Jul 1 16:12:02 2025 From: iris at openjdk.org (Iris Clark) Date: Tue, 1 Jul 2025 16:12:02 GMT Subject: RFR: 7904053: Update version to 8.0 In-Reply-To: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> References: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> Message-ID: On Tue, 1 Jul 2025 15:56:23 GMT, Christian Stein wrote: > Please review this trivial change updating the version to `8.0`; the upcoming release version of jtreg. Marked as reviewed by iris (Reviewer). ------------- PR Review: https://git.openjdk.org/jtreg/pull/271#pullrequestreview-2976108096 From ihse at openjdk.org Tue Jul 1 17:35:52 2025 From: ihse at openjdk.org (Magnus Ihse Bursie) Date: Tue, 1 Jul 2025 17:35:52 GMT Subject: RFR: 7904053: Update version to 8.0 In-Reply-To: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> References: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> Message-ID: On Tue, 1 Jul 2025 15:56:23 GMT, Christian Stein wrote: > Please review this trivial change updating the version to `8.0`; the upcoming release version of jtreg. :shipit: ------------- Marked as reviewed by ihse (Author). PR Review: https://git.openjdk.org/jtreg/pull/271#pullrequestreview-2976388437 From jpai at openjdk.org Wed Jul 2 01:59:49 2025 From: jpai at openjdk.org (Jaikiran Pai) Date: Wed, 2 Jul 2025 01:59:49 GMT Subject: RFR: 7904053: Update version to 8.0 In-Reply-To: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> References: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> Message-ID: On Tue, 1 Jul 2025 15:56:23 GMT, Christian Stein wrote: > Please review this trivial change updating the version to `8.0`; the upcoming release version of jtreg. Marked as reviewed by jpai (Reviewer). Hello Christian, the GitHub actions job has a test failure which might need investigation before integrating the change. ------------- PR Review: https://git.openjdk.org/jtreg/pull/271#pullrequestreview-2977368070 PR Comment: https://git.openjdk.org/jtreg/pull/271#issuecomment-3026087756 From cstein at openjdk.org Wed Jul 2 11:00:06 2025 From: cstein at openjdk.org (Christian Stein) Date: Wed, 2 Jul 2025 11:00:06 GMT Subject: RFR: 7904053: Update version to 8.0 [v2] In-Reply-To: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> References: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> Message-ID: > Please review this trivial change updating the version to `8.0`; the upcoming release version of jtreg. Christian Stein has updated the pull request incrementally with one additional commit since the last revision: Reverting change temporarily ------------- Changes: - all: https://git.openjdk.org/jtreg/pull/271/files - new: https://git.openjdk.org/jtreg/pull/271/files/a17df384..490c7fd0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jtreg&pr=271&range=01 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=271&range=00-01 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jtreg/pull/271.diff Fetch: git fetch https://git.openjdk.org/jtreg.git pull/271/head:pull/271 PR: https://git.openjdk.org/jtreg/pull/271 From cstein at openjdk.org Wed Jul 2 11:14:52 2025 From: cstein at openjdk.org (Christian Stein) Date: Wed, 2 Jul 2025 11:14:52 GMT Subject: RFR: 7904053: Update version to 8.0 [v2] In-Reply-To: References: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> Message-ID: <8q7pvo1PfXdQh4K0aNxZIAZ5O_1k8Z15XhT7Ip9RMqg=.66780ffd-f651-4d4d-8790-11fa993561d3@github.com> On Wed, 2 Jul 2025 11:00:06 GMT, Christian Stein wrote: >> Please review this trivial change updating the version to `8.0`; the upcoming release version of jtreg. > > Christian Stein has updated the pull request incrementally with one additional commit since the last revision: > > Reverting change temporarily _Investigating..._ ------------- PR Comment: https://git.openjdk.org/jtreg/pull/271#issuecomment-3027460689 From cstein at openjdk.org Wed Jul 2 11:24:57 2025 From: cstein at openjdk.org (Christian Stein) Date: Wed, 2 Jul 2025 11:24:57 GMT Subject: RFR: 7904053: Update version to 8.0 [v2] In-Reply-To: References: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> Message-ID: On Wed, 2 Jul 2025 11:00:06 GMT, Christian Stein wrote: >> Please review this trivial change updating the version to `8.0`; the upcoming release version of jtreg. > > Christian Stein has updated the pull request incrementally with one additional commit since the last revision: > > Reverting change temporarily ? `Error: Unexpected exception occurred! java.lang.IllegalArgumentException: Invalid version string: '8.0-dev+0'` java.lang.IllegalArgumentException: Invalid version string: '8.0-dev+0' at java.base/java.lang.Runtime$Version.parse(Runtime.java:1033) at com.sun.javatest.regtest.tool.Version.(Version.java:76) at com.sun.javatest.regtest.tool.Version.getCurrent(Version.java:46) at com.sun.javatest.regtest.tool.Tool.run(Tool.java:1142) at com.sun.javatest.regtest.tool.Tool.run(Tool.java:1072) at com.sun.javatest.regtest.tool.Tool.main(Tool.java:148) at com.sun.javatest.regtest.Main.main(Main.java:46) ------------- PR Comment: https://git.openjdk.org/jtreg/pull/271#issuecomment-3027497740 From cstein at openjdk.org Wed Jul 2 11:31:50 2025 From: cstein at openjdk.org (Christian Stein) Date: Wed, 2 Jul 2025 11:31:50 GMT Subject: RFR: 7904053: Update version to 8.0 [v3] In-Reply-To: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> References: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> Message-ID: > Please review this trivial change updating the version to `8.0`; the upcoming release version of jtreg. Christian Stein has updated the pull request incrementally with one additional commit since the last revision: Update make/build-support/version-numbers ------------- Changes: - all: https://git.openjdk.org/jtreg/pull/271/files - new: https://git.openjdk.org/jtreg/pull/271/files/490c7fd0..ca917f89 Webrevs: - full: https://webrevs.openjdk.org/?repo=jtreg&pr=271&range=02 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=271&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jtreg/pull/271.diff Fetch: git fetch https://git.openjdk.org/jtreg.git pull/271/head:pull/271 PR: https://git.openjdk.org/jtreg/pull/271 From cstein at openjdk.org Wed Jul 2 11:31:51 2025 From: cstein at openjdk.org (Christian Stein) Date: Wed, 2 Jul 2025 11:31:51 GMT Subject: RFR: 7904053: Update version to 8.0 [v2] In-Reply-To: References: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> Message-ID: <8VsYA_sKMmNGc2WiybggBeawvqU9zB909wLN0jf9vmM=.91ccbf70-328c-4206-bd63-8fb4e407c71f@github.com> On Wed, 2 Jul 2025 11:00:06 GMT, Christian Stein wrote: >> Please review this trivial change updating the version to `8.0`; the upcoming release version of jtreg. > > Christian Stein has updated the pull request incrementally with one additional commit since the last revision: > > Reverting change temporarily A trailing `.0` is not permitted. Will change the version number to `8`. make/build-support/version-numbers line 27: > 25: > 26: # Will be 8.0 again... > 27: JTREG_VERSION=7.6 Suggestion: JTREG_VERSION=8 ------------- PR Comment: https://git.openjdk.org/jtreg/pull/271#issuecomment-3027509031 PR Review Comment: https://git.openjdk.org/jtreg/pull/271#discussion_r2179811733 From jpai at openjdk.org Wed Jul 2 11:59:52 2025 From: jpai at openjdk.org (Jaikiran Pai) Date: Wed, 2 Jul 2025 11:59:52 GMT Subject: RFR: 7904053: Update version to 8.0 [v3] In-Reply-To: References: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> Message-ID: On Wed, 2 Jul 2025 11:31:50 GMT, Christian Stein wrote: >> Please review this trivial change updating the version to `8.0`; the upcoming release version of jtreg. > > Christian Stein has updated the pull request incrementally with one additional commit since the last revision: > > Update make/build-support/version-numbers Marked as reviewed by jpai (Reviewer). ------------- PR Review: https://git.openjdk.org/jtreg/pull/271#pullrequestreview-2978861619 From jpai at openjdk.org Wed Jul 2 11:59:52 2025 From: jpai at openjdk.org (Jaikiran Pai) Date: Wed, 2 Jul 2025 11:59:52 GMT Subject: RFR: 7904053: Update version to 8.0 [v2] In-Reply-To: <8VsYA_sKMmNGc2WiybggBeawvqU9zB909wLN0jf9vmM=.91ccbf70-328c-4206-bd63-8fb4e407c71f@github.com> References: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> <8VsYA_sKMmNGc2WiybggBeawvqU9zB909wLN0jf9vmM=.91ccbf70-328c-4206-bd63-8fb4e407c71f@github.com> Message-ID: On Wed, 2 Jul 2025 11:26:15 GMT, Christian Stein wrote: > A trailing `.0` is not permitted. Will change the version number to `8`. It's surprising that it's not allowed, but at least the change you now have matches what we did for jtreg 7 upgrade too https://github.com/openjdk/jtreg/commit/84ac040e6e9cc281a5bc19a87f5b082e9febb560#diff-fcecdc7ef68dc2023e2fbb7fda5426cc90f0883297952bc98cef0ee4cf3e2ab7L26-R26. So this current change looks good to me. ------------- PR Comment: https://git.openjdk.org/jtreg/pull/271#issuecomment-3027596983 From iris at openjdk.org Wed Jul 2 16:47:55 2025 From: iris at openjdk.org (Iris Clark) Date: Wed, 2 Jul 2025 16:47:55 GMT Subject: RFR: 7904053: Update version to 8.0 [v3] In-Reply-To: References: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> Message-ID: On Wed, 2 Jul 2025 11:31:50 GMT, Christian Stein wrote: >> Please review this trivial change updating the version to `8.0`; the upcoming release version of jtreg. > > Christian Stein has updated the pull request incrementally with one additional commit since the last revision: > > Update make/build-support/version-numbers Marked as reviewed by iris (Reviewer). ------------- PR Review: https://git.openjdk.org/jtreg/pull/271#pullrequestreview-2979911422 From cstein at openjdk.org Thu Jul 3 07:05:57 2025 From: cstein at openjdk.org (Christian Stein) Date: Thu, 3 Jul 2025 07:05:57 GMT Subject: Integrated: 7904053: Update version to 8 In-Reply-To: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> References: <5MOIAyRsopV9fH6eSL2Z--HgBooYXg-81O0T3YnNAoc=.46c215d6-b488-4859-a921-be573bb63a81@github.com> Message-ID: On Tue, 1 Jul 2025 15:56:23 GMT, Christian Stein wrote: > Please review this trivial change updating the version to `8.0`; the upcoming release version of jtreg. This pull request has now been integrated. Changeset: 4c1ef357 Author: Christian Stein URL: https://git.openjdk.org/jtreg/commit/4c1ef3570a4aaaa1151116eec5e3e661f6642a52 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 7904053: Update version to 8 Reviewed-by: iris, ihse, jpai ------------- PR: https://git.openjdk.org/jtreg/pull/271 From cstein at openjdk.org Mon Jul 7 14:03:09 2025 From: cstein at openjdk.org (Christian Stein) Date: Mon, 7 Jul 2025 14:03:09 GMT Subject: RFR: 7904055: Update jtreg to bundle JUnit 5.13.3 Message-ID: Please review this change to update jtreg to bundle JUnit 5.13.3 - instead of 5.13.2, which has some minor regressions. Find details at: https://docs.junit.org/5.13.3/release-notes/ Checksum `75af1fcbac5f10637d96c07555113b097f2eae4f` copied from here: - [junit-platform-console-standalone-1.13.3.jar.sha1](https://repo1.maven.org/maven2/org/junit/platform/junit-platform-console-standalone/1.13.3/junit-platform-console-standalone-1.13.3.jar.sha1) ------------- Commit messages: - 7904055: Update jtreg to bundle JUnit 5.13.3 Changes: https://git.openjdk.org/jtreg/pull/272/files Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=272&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904055 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jtreg/pull/272.diff Fetch: git fetch https://git.openjdk.org/jtreg.git pull/272/head:pull/272 PR: https://git.openjdk.org/jtreg/pull/272 From iris at openjdk.org Mon Jul 7 16:03:52 2025 From: iris at openjdk.org (Iris Clark) Date: Mon, 7 Jul 2025 16:03:52 GMT Subject: RFR: 7904055: Update jtreg to bundle JUnit 5.13.3 In-Reply-To: References: Message-ID: <3vYT69zTrJgbWm2oMM8CRjvHB0oqEJh6zpQlIbP7oVU=.160af29f-f8bf-45fb-8d24-7867b2bd3a60@github.com> On Mon, 7 Jul 2025 13:58:29 GMT, Christian Stein wrote: > Please review this change to update jtreg to bundle JUnit 5.13.3 - instead of 5.13.2, which has some minor regressions. Find details at: https://docs.junit.org/5.13.3/release-notes/ > > Checksum `75af1fcbac5f10637d96c07555113b097f2eae4f` copied from here: > - [junit-platform-console-standalone-1.13.3.jar.sha1](https://repo1.maven.org/maven2/org/junit/platform/junit-platform-console-standalone/1.13.3/junit-platform-console-standalone-1.13.3.jar.sha1) Marked as reviewed by iris (Reviewer). ------------- PR Review: https://git.openjdk.org/jtreg/pull/272#pullrequestreview-2994463031 From cstein at openjdk.org Tue Jul 8 05:49:39 2025 From: cstein at openjdk.org (Christian Stein) Date: Tue, 8 Jul 2025 05:49:39 GMT Subject: Integrated: 7904055: Update jtreg to bundle JUnit 5.13.3 In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 13:58:29 GMT, Christian Stein wrote: > Please review this change to update jtreg to bundle JUnit 5.13.3 - instead of 5.13.2, which has some minor regressions. Find details at: https://docs.junit.org/5.13.3/release-notes/ > > Checksum `75af1fcbac5f10637d96c07555113b097f2eae4f` copied from here: > - [junit-platform-console-standalone-1.13.3.jar.sha1](https://repo1.maven.org/maven2/org/junit/platform/junit-platform-console-standalone/1.13.3/junit-platform-console-standalone-1.13.3.jar.sha1) This pull request has now been integrated. Changeset: 64d4a062 Author: Christian Stein URL: https://git.openjdk.org/jtreg/commit/64d4a06270079e5972377e6d27a6ff5ee20e650a Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 7904055: Update jtreg to bundle JUnit 5.13.3 Reviewed-by: iris ------------- PR: https://git.openjdk.org/jtreg/pull/272 From cstein at openjdk.org Tue Jul 8 05:49:39 2025 From: cstein at openjdk.org (Christian Stein) Date: Tue, 8 Jul 2025 05:49:39 GMT Subject: RFR: 7904055: Update jtreg to bundle JUnit 5.13.3 [v2] In-Reply-To: References: Message-ID: > Please review this change to update jtreg to bundle JUnit 5.13.3 - instead of 5.13.2, which has some minor regressions. Find details at: https://docs.junit.org/5.13.3/release-notes/ > > Checksum `75af1fcbac5f10637d96c07555113b097f2eae4f` copied from here: > - [junit-platform-console-standalone-1.13.3.jar.sha1](https://repo1.maven.org/maven2/org/junit/platform/junit-platform-console-standalone/1.13.3/junit-platform-console-standalone-1.13.3.jar.sha1) Christian Stein has updated the pull request incrementally with one additional commit since the last revision: Update CHANGELOG.md [skip ci] ------------- Changes: - all: https://git.openjdk.org/jtreg/pull/272/files - new: https://git.openjdk.org/jtreg/pull/272/files/7e4ea7fd..5587e232 Webrevs: - full: https://webrevs.openjdk.org/?repo=jtreg&pr=272&range=01 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=272&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jtreg/pull/272.diff Fetch: git fetch https://git.openjdk.org/jtreg.git pull/272/head:pull/272 PR: https://git.openjdk.org/jtreg/pull/272 From cstein at openjdk.org Tue Jul 8 06:29:54 2025 From: cstein at openjdk.org (Christian Stein) Date: Tue, 8 Jul 2025 06:29:54 GMT Subject: RFR: 7904021: Parsing group files using non-UTF-8 encoding fails In-Reply-To: <35KNELPODav-BiVnxzITTKeQ4XidiUix4AgoIj1Ovjk=.d157b637-2a6f-4bdb-b709-60a26241d3ce@github.com> References: <35KNELPODav-BiVnxzITTKeQ4XidiUix4AgoIj1Ovjk=.d157b637-2a6f-4bdb-b709-60a26241d3ce@github.com> Message-ID: On Thu, 5 Jun 2025 04:35:14 GMT, Pasam Soujanya wrote: > We make use of jtreg to execute openjdk tests for JDK11/17/21 releases on non-UTF-8 returning platforms. We found latest jtreg code is using Files.newBufferedReader(path) to read group files data(TEST.GROUPS) from openjdk via GroupManager (https://github.com/openjdk/jtreg/blob/master/src/share/classes/com/sun/javatest/regtest/config/GroupManager.java#L102C44-L102C61). > > This code defaults to return BufferedReader as UTF-8 instance. We see discrepancies when using this version of jtreg on non-UTF-8 platforms where defaultCharset() is non-UTF-8(JDK11 and JDK17). > > Hence, we would like to propose a fix of using default.Charset() with Files.newBufferedWriter(Path path, Charset cs) instead of Files.newBufferedReader(path) and Files.readString(Path) to Files.readString(Path,Charset cs) in below jtreg files : > https://github.com/openjdk/jtreg/blob/master/src/share/classes/com/sun/javatest/regtest/config/GroupManager.java#L102C44-L102C61 > https://github.com/openjdk/jtreg/blob/master/src/share/classes/com/sun/javatest/regtest/config/ExtraPropDefns.java#L309 > > We've also tested this fix on OpenJDK supported platforms like Linux, Windows, MAC. > > --------- > ### Progress > - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer)) > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.org/jtreg.git pull/267/head:pull/267` \ > `$ git checkout pull/267` > > Update a local copy of the PR: \ > `$ git checkout pull/267` \ > `$ git pull https://git.openjdk.org/jtreg.git pull/267/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 267` > > View PR using the GUI difftool: \ > `$ git pr show -t 267` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.org/jtreg/pull/267.diff > >
>
Using Webrev > > [Link to Webrev Comment](https://git.openjdk.org/jtreg/pull/267#issuecomment-2942734568) >
Marked as reviewed by cstein (Reviewer). Right, using `Charset.defaultCharset()` would also enable support of `file.encoding`. And before the conversion to use NIO, the `Properties.load(InputStream)` method was used. It has: > Reads a property list (key and element pairs) from the input byte stream. The input stream is in a simple line-oriented format as specified in load(Reader) and is assumed to use the `ISO 8859-1` character encoding; that is each byte is one Latin1 character. Characters not in Latin1, and certain special characters, are represented in keys and elements using Unicode escapes as defined in section @jls 3.3 of The Java Language Specification Since jtreg 7, with [CODETOOLS-7903091](https://bugs.openjdk.org/browse/CODETOOLS-7903091) included, the `Properties.load(Reader)` is called - which gets the now UTF-8 encoded reader from `Files.newBufferedReader(file)`. Thus, all-in-all, your change resolves a regression. In the light of that, I'll approve and sponsor this pull request. ------------- PR Review: https://git.openjdk.org/jtreg/pull/267#pullrequestreview-2996153112 PR Comment: https://git.openjdk.org/jtreg/pull/267#issuecomment-3047536087 From duke at openjdk.org Tue Jul 8 08:05:54 2025 From: duke at openjdk.org (duke) Date: Tue, 8 Jul 2025 08:05:54 GMT Subject: RFR: 7904021: Parsing group files using non-UTF-8 encoding fails In-Reply-To: <35KNELPODav-BiVnxzITTKeQ4XidiUix4AgoIj1Ovjk=.d157b637-2a6f-4bdb-b709-60a26241d3ce@github.com> References: <35KNELPODav-BiVnxzITTKeQ4XidiUix4AgoIj1Ovjk=.d157b637-2a6f-4bdb-b709-60a26241d3ce@github.com> Message-ID: On Thu, 5 Jun 2025 04:35:14 GMT, Pasam Soujanya wrote: > We make use of jtreg to execute openjdk tests for JDK11/17/21 releases on non-UTF-8 returning platforms. We found latest jtreg code is using Files.newBufferedReader(path) to read group files data(TEST.GROUPS) from openjdk via GroupManager (https://github.com/openjdk/jtreg/blob/master/src/share/classes/com/sun/javatest/regtest/config/GroupManager.java#L102C44-L102C61). > > This code defaults to return BufferedReader as UTF-8 instance. We see discrepancies when using this version of jtreg on non-UTF-8 platforms where defaultCharset() is non-UTF-8(JDK11 and JDK17). > > Hence, we would like to propose a fix of using default.Charset() with Files.newBufferedWriter(Path path, Charset cs) instead of Files.newBufferedReader(path) and Files.readString(Path) to Files.readString(Path,Charset cs) in below jtreg files : > https://github.com/openjdk/jtreg/blob/master/src/share/classes/com/sun/javatest/regtest/config/GroupManager.java#L102C44-L102C61 > https://github.com/openjdk/jtreg/blob/master/src/share/classes/com/sun/javatest/regtest/config/ExtraPropDefns.java#L309 > > We've also tested this fix on OpenJDK supported platforms like Linux, Windows, MAC. > > --------- > ### Progress > - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer)) > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.org/jtreg.git pull/267/head:pull/267` \ > `$ git checkout pull/267` > > Update a local copy of the PR: \ > `$ git checkout pull/267` \ > `$ git pull https://git.openjdk.org/jtreg.git pull/267/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 267` > > View PR using the GUI difftool: \ > `$ git pr show -t 267` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.org/jtreg/pull/267.diff > >
>
Using Webrev > > [Link to Webrev Comment](https://git.openjdk.org/jtreg/pull/267#issuecomment-2942734568) >
@psoujany Your change (at version 6f38fe91d1cebe368fab9d7acf4a17dd97b6f651) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jtreg/pull/267#issuecomment-3047803954 From duke at openjdk.org Tue Jul 8 08:09:55 2025 From: duke at openjdk.org (Pasam Soujanya) Date: Tue, 8 Jul 2025 08:09:55 GMT Subject: Integrated: 7904021: Parsing group files using non-UTF-8 encoding fails In-Reply-To: <35KNELPODav-BiVnxzITTKeQ4XidiUix4AgoIj1Ovjk=.d157b637-2a6f-4bdb-b709-60a26241d3ce@github.com> References: <35KNELPODav-BiVnxzITTKeQ4XidiUix4AgoIj1Ovjk=.d157b637-2a6f-4bdb-b709-60a26241d3ce@github.com> Message-ID: On Thu, 5 Jun 2025 04:35:14 GMT, Pasam Soujanya wrote: > We make use of jtreg to execute openjdk tests for JDK11/17/21 releases on non-UTF-8 returning platforms. We found latest jtreg code is using Files.newBufferedReader(path) to read group files data(TEST.GROUPS) from openjdk via GroupManager (https://github.com/openjdk/jtreg/blob/master/src/share/classes/com/sun/javatest/regtest/config/GroupManager.java#L102C44-L102C61). > > This code defaults to return BufferedReader as UTF-8 instance. We see discrepancies when using this version of jtreg on non-UTF-8 platforms where defaultCharset() is non-UTF-8(JDK11 and JDK17). > > Hence, we would like to propose a fix of using default.Charset() with Files.newBufferedWriter(Path path, Charset cs) instead of Files.newBufferedReader(path) and Files.readString(Path) to Files.readString(Path,Charset cs) in below jtreg files : > https://github.com/openjdk/jtreg/blob/master/src/share/classes/com/sun/javatest/regtest/config/GroupManager.java#L102C44-L102C61 > https://github.com/openjdk/jtreg/blob/master/src/share/classes/com/sun/javatest/regtest/config/ExtraPropDefns.java#L309 > > We've also tested this fix on OpenJDK supported platforms like Linux, Windows, MAC. > > --------- > ### Progress > - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer)) > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.org/jtreg.git pull/267/head:pull/267` \ > `$ git checkout pull/267` > > Update a local copy of the PR: \ > `$ git checkout pull/267` \ > `$ git pull https://git.openjdk.org/jtreg.git pull/267/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 267` > > View PR using the GUI difftool: \ > `$ git pr show -t 267` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.org/jtreg/pull/267.diff > >
>
Using Webrev > > [Link to Webrev Comment](https://git.openjdk.org/jtreg/pull/267#issuecomment-2942734568) >
This pull request has now been integrated. Changeset: 439cb91b Author: Pasam Soujanya Committer: Christian Stein URL: https://git.openjdk.org/jtreg/commit/439cb91b690acda994166d6fd5f16dcd150393f1 Stats: 4 lines in 2 files changed: 2 ins; 0 del; 2 mod 7904021: Parsing group files using non-UTF-8 encoding fails Reviewed-by: cstein ------------- PR: https://git.openjdk.org/jtreg/pull/267 From duke at openjdk.org Thu Jul 10 09:03:54 2025 From: duke at openjdk.org (Pasam Soujanya) Date: Thu, 10 Jul 2025 09:03:54 GMT Subject: RFR: 7904021: Parsing group files using non-UTF-8 encoding fails In-Reply-To: References: <35KNELPODav-BiVnxzITTKeQ4XidiUix4AgoIj1Ovjk=.d157b637-2a6f-4bdb-b709-60a26241d3ce@github.com> Message-ID: On Tue, 8 Jul 2025 06:27:20 GMT, Christian Stein wrote: >> We make use of jtreg to execute openjdk tests for JDK11/17/21 releases on non-UTF-8 returning platforms. We found latest jtreg code is using Files.newBufferedReader(path) to read group files data(TEST.GROUPS) from openjdk via GroupManager (https://github.com/openjdk/jtreg/blob/master/src/share/classes/com/sun/javatest/regtest/config/GroupManager.java#L102C44-L102C61). >> >> This code defaults to return BufferedReader as UTF-8 instance. We see discrepancies when using this version of jtreg on non-UTF-8 platforms where defaultCharset() is non-UTF-8(JDK11 and JDK17). >> >> Hence, we would like to propose a fix of using default.Charset() with Files.newBufferedWriter(Path path, Charset cs) instead of Files.newBufferedReader(path) and Files.readString(Path) to Files.readString(Path,Charset cs) in below jtreg files : >> https://github.com/openjdk/jtreg/blob/master/src/share/classes/com/sun/javatest/regtest/config/GroupManager.java#L102C44-L102C61 >> https://github.com/openjdk/jtreg/blob/master/src/share/classes/com/sun/javatest/regtest/config/ExtraPropDefns.java#L309 >> >> We've also tested this fix on OpenJDK supported platforms like Linux, Windows, MAC. >> >> --------- >> ### Progress >> - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer)) >> - [x] Change must not contain extraneous whitespace >> - [x] Commit message must refer to an issue >> >> >> >> ### Reviewing >>
Using git >> >> Checkout this PR locally: \ >> `$ git fetch https://git.openjdk.org/jtreg.git pull/267/head:pull/267` \ >> `$ git checkout pull/267` >> >> Update a local copy of the PR: \ >> `$ git checkout pull/267` \ >> `$ git pull https://git.openjdk.org/jtreg.git pull/267/head` >> >>
>>
Using Skara CLI tools >> >> Checkout this PR locally: \ >> `$ git pr checkout 267` >> >> View PR using the GUI difftool: \ >> `$ git pr show -t 267` >> >>
>>
Using diff file >> >> Download this PR as a diff file: \ >> https://git.openjdk.org/jtreg/pull/267.diff >> >>
>>
Using Webrev >> >> [Link to Webrev Comment](https://git.openjdk.org/jtreg/pull/267#issuecomment-2942734568) >>
> > Right, using `Charset.defaultCharset()` would also enable support of `file.encoding`. > > And before the conversion to use NIO, the `Properties.load(InputStream)` method was used. It has: > >> Reads a property list (key and element pairs) from the input byte stream. The input stream is in a simple line-oriented format as specified in load(Reader) and is assumed to use the `ISO 8859-1` character encoding; that is each byte is one Latin1 character. Characters not in Latin1, and certain special characters, are represented in keys and elements using Unicode escapes as defined in section @jls 3.3 of The Java Language Specification > > > Since jtreg 7, with [CODETOOLS-7903091](https://bugs.openjdk.org/browse/CODETOOLS-7903091) included, the `Properties.load(Reader)` is called - which gets the now UTF-8 encoded reader from `Files.newBufferedReader(file)`. > > Thus, all-in-all, your change resolves a regression. In the light of that, I'll approve and sponsor this pull request. Hi @sormuras , I would like to have this change in https://github.com/openjdk/jtreg/tree/branch-7.1%2Bx, could you please let me know if I need to raise another PR with the same changeset. Thank you. ------------- PR Comment: https://git.openjdk.org/jtreg/pull/267#issuecomment-3056435671 From cstein at openjdk.org Thu Jul 10 15:23:38 2025 From: cstein at openjdk.org (Christian Stein) Date: Thu, 10 Jul 2025 15:23:38 GMT Subject: RFR: 7904062: Release jtreg 8 Message-ID: Please review this change preparing the release of jtreg 8. This commit only updates the `CHANGELOG.md` file to include a selected set of noteworthy changes under the new *8* section. The `make/build-support/version-numbers` file is already good to go for the initial 8.x release. ------------- Commit messages: - 7904062: Release jtreg 8 Changes: https://git.openjdk.org/jtreg/pull/273/files Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=273&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904062 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jtreg/pull/273.diff Fetch: git fetch https://git.openjdk.org/jtreg.git pull/273/head:pull/273 PR: https://git.openjdk.org/jtreg/pull/273 From iris at openjdk.org Thu Jul 10 15:31:03 2025 From: iris at openjdk.org (Iris Clark) Date: Thu, 10 Jul 2025 15:31:03 GMT Subject: RFR: 7904062: Release jtreg 8 In-Reply-To: References: Message-ID: On Thu, 10 Jul 2025 15:18:42 GMT, Christian Stein wrote: > Please review this change preparing the release of jtreg 8. > > This commit only updates the `CHANGELOG.md` file to include > a selected set of noteworthy changes under the new *8* section. > > The `make/build-support/version-numbers` file is already good > to go for the initial 8.x release. Marked as reviewed by iris (Reviewer). ------------- PR Review: https://git.openjdk.org/jtreg/pull/273#pullrequestreview-3006253051 From cstein at openjdk.org Thu Jul 10 15:44:53 2025 From: cstein at openjdk.org (Christian Stein) Date: Thu, 10 Jul 2025 15:44:53 GMT Subject: Integrated: 7904062: Release jtreg 8 In-Reply-To: References: Message-ID: On Thu, 10 Jul 2025 15:18:42 GMT, Christian Stein wrote: > Please review this change preparing the release of jtreg 8. > > This commit only updates the `CHANGELOG.md` file to include > a selected set of noteworthy changes under the new *8* section. > > The `make/build-support/version-numbers` file is already good > to go for the initial 8.x release. This pull request has now been integrated. Changeset: 81c6097e Author: Christian Stein URL: https://git.openjdk.org/jtreg/commit/81c6097e2637cf6757bdfd5697d4777948e91f7a Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod 7904062: Release jtreg 8 Reviewed-by: iris ------------- PR: https://git.openjdk.org/jtreg/pull/273 From cstein at openjdk.org Fri Jul 11 09:37:06 2025 From: cstein at openjdk.org (Christian Stein) Date: Fri, 11 Jul 2025 09:37:06 GMT Subject: RFR: 7904063: Update version to 8.1 Message-ID: Please review this trivial change starting the development of jtreg 8.1 This PR also fixes comparison links in `CHANGELOG.md` by using the correct build tag: `jtreg-8+2` ------------- Commit messages: - 7904063: Update version to 8.1 Changes: https://git.openjdk.org/jtreg/pull/274/files Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=274&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904063 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jtreg/pull/274.diff Fetch: git fetch https://git.openjdk.org/jtreg.git pull/274/head:pull/274 PR: https://git.openjdk.org/jtreg/pull/274