RFR: 7903955: jtreg doesn't support .jasm in patch module [v3]

Jaikiran Pai jpai at openjdk.org
Wed Mar 5 12:51:23 UTC 2025


On Wed, 5 Mar 2025 12:39:46 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Please review this change to support compilation of `.jasm` in patched modules.
>> 
>> Prior to this commit an extra check for `module != null` was the only difference when treating `.java` source files and JASM-related files. With that check removed, the handling of both types of source files could be merged.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Always run ModLibsTest targets

`ModLibsTest.gmk` requires a copyright year update.

Other than that, the change looks OK to me. But I don't have the necessary background about why there was a `module != null` check (which has now been removed in this PR) in this part of the code. My suggestion would be to wait for a few days to see if Jon @jonathan-gibbons has any inputs on the history or this change in general.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jtreg/pull/249#pullrequestreview-2661010083


More information about the jtreg-dev mailing list