RFR: 7903963: Fix "Run Configuration" Window Freeze Issue [v2]

Oleksii Sylichenko duke at openjdk.org
Fri Mar 7 17:30:19 UTC 2025


On Fri, 7 Mar 2025 15:29:08 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Oleksii Sylichenko has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   7903963: Fix "Run Configuration" Window Freeze Issue
>>   - remove `final` from local variables
>
> plugins/idea/src/main/java/com/oracle/plugin/jtreg/configuration/ui/JTRegConfigurable.java line 147:
> 
>> 145: 
>> 146:         final String alternativeJrePath;
>> 147:         final boolean alternativeJREPathEnabled;
> 
> I've discussed with my colleague, and in general we'd like to not have `final` on local variables, as it doesn't really add much value, but does introduce extra visual clutter. I know some parts of the plugin don't follow that rule, but we shouldn't add more of it.
> 
> Please remove `final` from local variables.

done

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/250#discussion_r1985437185


More information about the jtreg-dev mailing list