RFR: 7903965: Fix Launching Tests from Context Menu [v3]

Oleksii Sylichenko duke at openjdk.org
Mon Mar 10 14:11:59 UTC 2025


On Mon, 10 Mar 2025 12:34:54 GMT, Oleksii Sylichenko <duke at openjdk.org> wrote:

>> plugins/idea/src/main/java/com/oracle/plugin/jtreg/util/JTRegUtils.java line 94:
>> 
>>> 92:     public static final Predicate<PsiElement> IS_DIR_ELEMENT = PsiDirectory.class::isInstance;
>>> 93:     public static final Predicate<PsiElement> IS_FILE_ELEMENT = PsiFile.class::isInstance;
>>> 94:     public static final Predicate<PsiElement> IS_FILE_OR_DIR_ELEMENT = IS_FILE_ELEMENT.or(IS_DIR_ELEMENT);
>> 
>> Why are these all predicates? I'd much prefer a set of static methods. These predicates make the logic harder to follow.
>
> ok, no problem, I will replace them with methods.

done: 8f97b8d0f2fa0e08e9b705df8e30b6b72c4fe6cc

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/252#discussion_r1987363546


More information about the jtreg-dev mailing list