RFR: 7903965: Fix Launching Tests from Context Menu [v4]
Jorn Vernee
jvernee at openjdk.org
Mon Mar 10 18:33:11 UTC 2025
On Mon, 10 Mar 2025 16:47:09 GMT, Oleksii Sylichenko <duke at openjdk.org> wrote:
>> I'm not talking about `getVirtualFile`, I'm talking about the call to `getContainingFile`, inside `nameForElement`. If `element` is a `PsiDirectory`, then `getContainingFile` will return `null` (looking at the impl in `PsiDirectoryImpl`):
>> 
>
> Ok, so the `JTRegDirectoryConfigurationProducer` class is not needed because directory processing will be handled by the 'class producer', and I will take care of additional `null` checks.
>
> Therefore, we don't need `JTRegClassConfigurationProducer` as the only child of `JTRegConfigurationProducer`, so I propose moving all its code to the parent class and removing it as well.
>
> Would that be okay?
That sounds good
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/252#discussion_r1987820091
More information about the jtreg-dev
mailing list