RFR: 7903965: Fix Launching Tests from Context Menu [v5]
Oleksii Sylichenko
duke at openjdk.org
Tue Mar 11 16:35:56 UTC 2025
On Mon, 10 Mar 2025 12:21:51 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> plugins/idea/src/main/java/com/oracle/plugin/jtreg/configuration/producers/JTRegConfigurationProducer.java line 128:
>>
>>> 126:
>>> 127: if (IS_THIRD_PARTY_TEST_ELEMENT.test(e)) {
>>> 128: final PsiElement identifyingElement = ((PsiNameIdentifierOwner) e).getIdentifyingElement();
>>
>> Suggestion:
>>
>> PsiElement identifyingElement = ((PsiNameIdentifierOwner) e).getIdentifyingElement();
>
> Also, I notice that this is code is trying to return a `PsiIdentifier` so that `getQuery` and `nameForElement` will keep working. It might be better to change those methods to work on `PsiMethod` and `PsiClass`, and then use the current `e` as return value directly.
done: fc97ec59d91a1625577509ff342e8d4c1b96ade8
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/252#discussion_r1989699264
More information about the jtreg-dev
mailing list