From cstein at openjdk.org Fri May 2 10:30:35 2025 From: cstein at openjdk.org (Christian Stein) Date: Fri, 2 May 2025 10:30:35 GMT Subject: RFR: 7903081: Update asmtools and remove jcov traces Message-ID: _work in progress..._ Blocked by AsmTools requiring JDK 17 (or above) to be built: https://github.com/openjdk/asmtools/blob/7ea57726a181b819c4b6331b19160c4fce238b11/build/build.properties#L30-L31 ------------- Commit messages: - Update to use asmtools 8.1 - 7903081: Update asmtools and remove jcov traces Changes: https://git.openjdk.org/jtreg/pull/228/files Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=228&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903081 Stats: 14 lines in 3 files changed: 0 ins; 7 del; 7 mod Patch: https://git.openjdk.org/jtreg/pull/228.diff Fetch: git fetch https://git.openjdk.org/jtreg.git pull/228/head:pull/228 PR: https://git.openjdk.org/jtreg/pull/228 From cstein at openjdk.org Fri May 2 10:30:35 2025 From: cstein at openjdk.org (Christian Stein) Date: Fri, 2 May 2025 10:30:35 GMT Subject: RFR: 7903081: Update asmtools and remove jcov traces In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 09:49:43 GMT, Christian Stein wrote: > _work in progress..._ > > Blocked by AsmTools requiring JDK 17 (or above) to be built: https://github.com/openjdk/asmtools/blob/7ea57726a181b819c4b6331b19160c4fce238b11/build/build.properties#L30-L31 Now also blocked by an unreleased bugfix in the Ant `build.xml` producing: /home/runner/work/jtreg/jtreg/build/deps/asmtools/src/asmtools-8.0-b09/build/build.xml:179: . Current java version is 21 The build should be started by java 17 or above @lkuskov would it be possible to release `asmtools` 8.1 with the updated regex (commit https://github.com/openjdk/asmtools/commit/949fb1dfcc54fd5bffbda012fe689ff059999c9f)? ------------- PR Comment: https://git.openjdk.org/jtreg/pull/228#issuecomment-2682170773 From lkuskov at openjdk.org Fri May 2 10:30:35 2025 From: lkuskov at openjdk.org (Leonid Kuskov) Date: Fri, 2 May 2025 10:30:35 GMT Subject: RFR: 7903081: Update asmtools and remove jcov traces In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 09:49:43 GMT, Christian Stein wrote: > _work in progress..._ > > Blocked by AsmTools requiring JDK 17 (or above) to be built: https://github.com/openjdk/asmtools/blob/7ea57726a181b819c4b6331b19160c4fce238b11/build/build.properties#L30-L31 Hi Christian, Unfortunately, despite being the integrator of the commit, I can't set a tag `/tag at8.1` for it: [949fb1d](https://github.com/openjdk/asmtools/commit/279512c2c649f59a0c15f1ae2caa31b9ed695ea5) Any tips? Thanks, Leonid ------------- PR Comment: https://git.openjdk.org/jtreg/pull/228#issuecomment-2683574662 From jpai at openjdk.org Mon May 5 12:40:18 2025 From: jpai at openjdk.org (Jaikiran Pai) Date: Mon, 5 May 2025 12:40:18 GMT Subject: RFR: 7903081: Update asmtools and remove jcov traces In-Reply-To: References: Message-ID: On Tue, 24 Sep 2024 09:49:43 GMT, Christian Stein wrote: > _work in progress..._ > > Blocked by AsmTools requiring JDK 17 (or above) to be built: https://github.com/openjdk/asmtools/blob/7ea57726a181b819c4b6331b19160c4fce238b11/build/build.properties#L30-L31 Hello Christian, the upgrade looks reasonable to me. Now that we enforce Java 17 for building jtreg, I think we should also update the `doc/building.md` which currently states: > It must be a recent build of JDK 11 or later. make/build-support/asmtools/version-numbers line 26: > 24: # > 25: > 26: DEFAULT_ASMTOOLS_SRC_TAG=8.1 The copyright year on this file will need an update. ------------- PR Comment: https://git.openjdk.org/jtreg/pull/228#issuecomment-2850858951 PR Review Comment: https://git.openjdk.org/jtreg/pull/228#discussion_r2073361455 From cstein at openjdk.org Mon May 5 14:41:37 2025 From: cstein at openjdk.org (Christian Stein) Date: Mon, 5 May 2025 14:41:37 GMT Subject: RFR: 7903081: Update asmtools and remove jcov traces [v2] In-Reply-To: References: Message-ID: <87aWqBDO5kcpVrJLrQ6RjQEOTlBTuhOJg4ooRW5452w=.8126ddc0-a302-4fdd-abaa-30529411bdf4@github.com> > _work in progress..._ > > Blocked by AsmTools requiring JDK 17 (or above) to be built: https://github.com/openjdk/asmtools/blob/7ea57726a181b819c4b6331b19160c4fce238b11/build/build.properties#L30-L31 Christian Stein has updated the pull request incrementally with two additional commits since the last revision: - Specify JDK 17 is required to build jtreg - Update copyright year ------------- Changes: - all: https://git.openjdk.org/jtreg/pull/228/files - new: https://git.openjdk.org/jtreg/pull/228/files/0e88a367..34944da2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jtreg&pr=228&range=01 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=228&range=00-01 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jtreg/pull/228.diff Fetch: git fetch https://git.openjdk.org/jtreg.git pull/228/head:pull/228 PR: https://git.openjdk.org/jtreg/pull/228 From cstein at openjdk.org Mon May 5 14:41:37 2025 From: cstein at openjdk.org (Christian Stein) Date: Mon, 5 May 2025 14:41:37 GMT Subject: RFR: 7903081: Update asmtools and remove jcov traces [v2] In-Reply-To: References:

Message-ID: On Mon, 5 May 2025 12:37:44 GMT, Jaikiran Pai wrote: >> Christian Stein has updated the pull request incrementally with two additional commits since the last revision: >> >> - Specify JDK 17 is required to build jtreg >> - Update copyright year > > make/build-support/asmtools/version-numbers line 26: > >> 24: # >> 25: >> 26: DEFAULT_ASMTOOLS_SRC_TAG=8.1 > > The copyright year on this file will need an update. Done. ------------- PR Review Comment: https://git.openjdk.org/jtreg/pull/228#discussion_r2073580091 From lujaniuk at openjdk.org Tue May 6 08:05:27 2025 From: lujaniuk at openjdk.org (Ludvig Janiuk) Date: Tue, 6 May 2025 08:05:27 GMT Subject: RFR: 7903081: Update asmtools and remove jcov traces [v2] In-Reply-To: <87aWqBDO5kcpVrJLrQ6RjQEOTlBTuhOJg4ooRW5452w=.8126ddc0-a302-4fdd-abaa-30529411bdf4@github.com> References: <87aWqBDO5kcpVrJLrQ6RjQEOTlBTuhOJg4ooRW5452w=.8126ddc0-a302-4fdd-abaa-30529411bdf4@github.com> Message-ID: On Mon, 5 May 2025 14:41:37 GMT, Christian Stein wrote: >> _work in progress..._ >> >> Blocked by AsmTools requiring JDK 17 (or above) to be built: https://github.com/openjdk/asmtools/blob/7ea57726a181b819c4b6331b19160c4fce238b11/build/build.properties#L30-L31 > > Christian Stein has updated the pull request incrementally with two additional commits since the last revision: > > - Specify JDK 17 is required to build jtreg > - Update copyright year Being able to test older JDK's with jtreg is important. Do I understand it right that this PR would make it impossible to run with a JDK pre-17, with no workaround possible? ------------- PR Comment: https://git.openjdk.org/jtreg/pull/228#issuecomment-2853629491 From duke at openjdk.org Tue May 6 09:55:08 2025 From: duke at openjdk.org (snake66) Date: Tue, 6 May 2025 09:55:08 GMT Subject: RFR: 7904002: @compile directives with args after file name fail after 7903955 Message-ID: This work is sponsored by The FreeBSD Foundation ------------- Commit messages: - 7904002: compile directives with args after file name fail after 7903955 Changes: https://git.openjdk.org/jtreg/pull/261/files Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=261&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904002 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jtreg/pull/261.diff Fetch: git fetch https://git.openjdk.org/jtreg.git pull/261/head:pull/261 PR: https://git.openjdk.org/jtreg/pull/261 From cstein at openjdk.org Tue May 6 11:43:25 2025 From: cstein at openjdk.org (Christian Stein) Date: Tue, 6 May 2025 11:43:25 GMT Subject: RFR: 7904002: @compile directives with args after file name fail after 7903955 In-Reply-To: References: Message-ID: On Tue, 6 May 2025 09:49:07 GMT, snake66 wrote: > This work is sponsored by The FreeBSD Foundation Please add a self-test covering the `@compile Test.java -XDrawDiagnostics` case. ------------- Changes requested by cstein (Reviewer). PR Review: https://git.openjdk.org/jtreg/pull/261#pullrequestreview-2817939846 From duke at openjdk.org Tue May 6 12:55:38 2025 From: duke at openjdk.org (snake66) Date: Tue, 6 May 2025 12:55:38 GMT Subject: RFR: 7904004: Run jtreg GHA workflows for FreeBSD Message-ID: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com> GitHub Actions does not natively support FreeBSD, so we use the vmactions/freebsd-vm action as a base to run the tests in a VM under an Ubuntu runner. This work is sponsored by The FreeBSD Foundation. ------------- Commit messages: - 7904004: Run jtreg GHA workflows for FreeBSD Changes: https://git.openjdk.org/jtreg/pull/262/files Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=262&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904004 Stats: 27 lines in 1 file changed: 27 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jtreg/pull/262.diff Fetch: git fetch https://git.openjdk.org/jtreg.git pull/262/head:pull/262 PR: https://git.openjdk.org/jtreg/pull/262 From duke at openjdk.org Tue May 6 13:27:42 2025 From: duke at openjdk.org (snake66) Date: Tue, 6 May 2025 13:27:42 GMT Subject: RFR: 7904002: @compile directives with args after file name fail after 7903955 [v2] In-Reply-To: References: Message-ID: > This work is sponsored by The FreeBSD Foundation snake66 has updated the pull request incrementally with one additional commit since the last revision: Add test case for @compile with trailing args ------------- Changes: - all: https://git.openjdk.org/jtreg/pull/261/files - new: https://git.openjdk.org/jtreg/pull/261/files/37bd6ed6..2ef29f35 Webrevs: - full: https://webrevs.openjdk.org/?repo=jtreg&pr=261&range=01 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=261&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jtreg/pull/261.diff Fetch: git fetch https://git.openjdk.org/jtreg.git pull/261/head:pull/261 PR: https://git.openjdk.org/jtreg/pull/261 From cstein at openjdk.org Tue May 6 15:50:30 2025 From: cstein at openjdk.org (Christian Stein) Date: Tue, 6 May 2025 15:50:30 GMT Subject: RFR: 7904002: @compile directives with args after file name fail after 7903955 [v2] In-Reply-To: References:

Message-ID: <7iHTl38h-beM2y3w5V5W4ByASoP5fr6ay3jxXrK9FxY=.f29f6a41-bc8f-4ad5-9833-8778eb5d4b02@github.com> On Tue, 6 May 2025 13:27:42 GMT, snake66 wrote: >> This work is sponsored by The FreeBSD Foundation > > snake66 has updated the pull request incrementally with one additional commit since the last revision: > > Add test case for @compile with trailing args test/javacVMOptions/Test.java line 28: > 26: * @compile Test.java > 27: * @compile -J-DmyProperty=123 -processor Test -proc:only Test.java > 28: * @compile Test.java -XDrawDiagnostic Please, also insert a line reading ` * @bug 7902510 7904002` under the ` * @test` line. And update the copyright years to read: `* Copyright (c) 2019, 2025, Oracle and/or its affiliates. All rights reserved.` ------------- PR Review Comment: https://git.openjdk.org/jtreg/pull/261#discussion_r2075768009 From cstein at openjdk.org Tue May 6 16:14:25 2025 From: cstein at openjdk.org (Christian Stein) Date: Tue, 6 May 2025 16:14:25 GMT Subject: RFR: 7904004: Run jtreg GHA workflows for FreeBSD In-Reply-To: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com> References: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com> Message-ID: On Tue, 6 May 2025 12:52:18 GMT, snake66 wrote: > GitHub Actions does not natively support FreeBSD, so we use the vmactions/freebsd-vm action as a base to run the tests in a VM under an Ubuntu runner. > > This work is sponsored by The FreeBSD Foundation. .github/workflows/test.yml line 73: > 71: sysctl hw.usermem > 72: pw user add -n action -m > 73: su action -c 'git config --global --add safe.directory /home/runner/work/jtreg/jtreg && bash make/build.sh --jdk /usr/local/openjdk21 && bash build/make.sh test' Could the `git` configuration and two make calls be split into dedicated lines? ------------- PR Review Comment: https://git.openjdk.org/jtreg/pull/262#discussion_r2075813241 From duke at openjdk.org Tue May 6 17:51:30 2025 From: duke at openjdk.org (snake66) Date: Tue, 6 May 2025 17:51:30 GMT Subject: RFR: 7904004: Run jtreg GHA workflows for FreeBSD In-Reply-To: References: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com> Message-ID: <3dosqTcJpJMTwDBUJDrkOsrfVvLZ9RN0rLIP3e5bDyI=.efabf470-1295-4aec-81a7-65a9db7862d1@github.com> On Tue, 6 May 2025 16:12:18 GMT, Christian Stein wrote: >> GitHub Actions does not natively support FreeBSD, so we use the vmactions/freebsd-vm action as a base to run the tests in a VM under an Ubuntu runner. >> >> This work is sponsored by The FreeBSD Foundation. > > .github/workflows/test.yml line 73: > >> 71: sysctl hw.usermem >> 72: pw user add -n action -m >> 73: su action -c 'git config --global --add safe.directory /home/runner/work/jtreg/jtreg && bash make/build.sh --jdk /usr/local/openjdk21 && bash build/make.sh test' > > Could the `git` configuration and two make calls be split into dedicated lines? Probably, I'll give it a try! ------------- PR Review Comment: https://git.openjdk.org/jtreg/pull/262#discussion_r2075980077 From duke at openjdk.org Tue May 6 17:53:26 2025 From: duke at openjdk.org (snake66) Date: Tue, 6 May 2025 17:53:26 GMT Subject: RFR: 7904002: @compile directives with args after file name fail after 7903955 [v2] In-Reply-To: <7iHTl38h-beM2y3w5V5W4ByASoP5fr6ay3jxXrK9FxY=.f29f6a41-bc8f-4ad5-9833-8778eb5d4b02@github.com> References:

<7iHTl38h-beM2y3w5V5W4ByASoP5fr6ay3jxXrK9FxY=.f29f6a41-bc8f-4ad5-9833-8778eb5d4b02@github.com> Message-ID: On Tue, 6 May 2025 15:48:07 GMT, Christian Stein wrote: >> snake66 has updated the pull request incrementally with one additional commit since the last revision: >> >> Add test case for @compile with trailing args > > test/javacVMOptions/Test.java line 28: > >> 26: * @compile Test.java >> 27: * @compile -J-DmyProperty=123 -processor Test -proc:only Test.java >> 28: * @compile Test.java -XDrawDiagnostic > > Please, also insert a line reading ` * @bug 7902510 7904002` under the ` * @test` line. > > And update the copyright years to read: `* Copyright (c) 2019, 2025, Oracle and/or its affiliates. All rights reserved.` Sure! Would it be better to add a separate test case for it instead of just adding another `@compile` line to this one? ------------- PR Review Comment: https://git.openjdk.org/jtreg/pull/261#discussion_r2075984063 From cstein at openjdk.org Wed May 7 05:32:24 2025 From: cstein at openjdk.org (Christian Stein) Date: Wed, 7 May 2025 05:32:24 GMT Subject: RFR: 7904002: @compile directives with args after file name fail after 7903955 [v2] In-Reply-To: References:

<7iHTl38h-beM2y3w5V5W4ByASoP5fr6ay3jxXrK9FxY=.f29f6a41-bc8f-4ad5-9833-8778eb5d4b02@github.com> Message-ID: On Tue, 6 May 2025 17:51:08 GMT, snake66 wrote: >> test/javacVMOptions/Test.java line 28: >> >>> 26: * @compile Test.java >>> 27: * @compile -J-DmyProperty=123 -processor Test -proc:only Test.java >>> 28: * @compile Test.java -XDrawDiagnostic >> >> Please, also insert a line reading ` * @bug 7902510 7904002` under the ` * @test` line. >> >> And update the copyright years to read: `* Copyright (c) 2019, 2025, Oracle and/or its affiliates. All rights reserved.` > > Sure! > > Would it be better to add a separate test case for it instead of just adding another `@compile` line to this one? Doesn't have to be a dedicated test per issue; as long as the issue numbers are recorded via the `@bug` tag. Bonus points for adding `@comment` lines. ------------- PR Review Comment: https://git.openjdk.org/jtreg/pull/261#discussion_r2076816151 From duke at openjdk.org Wed May 7 09:44:41 2025 From: duke at openjdk.org (snake66) Date: Wed, 7 May 2025 09:44:41 GMT Subject: RFR: 7904002: @compile directives with args after file name fail after 7903955 [v3] In-Reply-To: References: Message-ID: > This work is sponsored by The FreeBSD Foundation snake66 has updated the pull request incrementally with two additional commits since the last revision: - Update copyright notice - Add @bug and @comment tags ------------- Changes: - all: https://git.openjdk.org/jtreg/pull/261/files - new: https://git.openjdk.org/jtreg/pull/261/files/2ef29f35..23a1e2ef Webrevs: - full: https://webrevs.openjdk.org/?repo=jtreg&pr=261&range=02 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=261&range=01-02 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jtreg/pull/261.diff Fetch: git fetch https://git.openjdk.org/jtreg.git pull/261/head:pull/261 PR: https://git.openjdk.org/jtreg/pull/261 From cstein at openjdk.org Wed May 7 10:05:29 2025 From: cstein at openjdk.org (Christian Stein) Date: Wed, 7 May 2025 10:05:29 GMT Subject: RFR: 7904002: @compile directives with args after file name fail after 7903955 [v3] In-Reply-To: References:

Message-ID: On Wed, 7 May 2025 09:44:41 GMT, snake66 wrote: >> This work is sponsored by The FreeBSD Foundation > > snake66 has updated the pull request incrementally with two additional commits since the last revision: > > - Update copyright notice > - Add @bug and @comment tags Looks good to me ------------- Marked as reviewed by cstein (Reviewer). PR Review: https://git.openjdk.org/jtreg/pull/261#pullrequestreview-2821176854 From duke at openjdk.org Wed May 7 10:47:22 2025 From: duke at openjdk.org (snake66) Date: Wed, 7 May 2025 10:47:22 GMT Subject: RFR: 7904004: Run jtreg GHA workflows for FreeBSD [v2] In-Reply-To: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com> References: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com> Message-ID: > GitHub Actions does not natively support FreeBSD, so we use the vmactions/freebsd-vm action as a base to run the tests in a VM under an Ubuntu runner. > > This work is sponsored by The FreeBSD Foundation. snake66 has updated the pull request incrementally with one additional commit since the last revision: Split long line in workflow ------------- Changes: - all: https://git.openjdk.org/jtreg/pull/262/files - new: https://git.openjdk.org/jtreg/pull/262/files/0788637c..d8f66b75 Webrevs: - full: https://webrevs.openjdk.org/?repo=jtreg&pr=262&range=01 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=262&range=00-01 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jtreg/pull/262.diff Fetch: git fetch https://git.openjdk.org/jtreg.git pull/262/head:pull/262 PR: https://git.openjdk.org/jtreg/pull/262 From duke at openjdk.org Wed May 7 10:49:25 2025 From: duke at openjdk.org (snake66) Date: Wed, 7 May 2025 10:49:25 GMT Subject: RFR: 7904002: @compile directives with args after file name fail after 7903955 [v3] In-Reply-To: References:

Message-ID: <89IxzU1y-FplCZk1m1SI7PqL3FfOQvnjORaHsi3PXEE=.1cef9f5a-308e-42f5-a487-105953c7c76e@github.com> On Wed, 7 May 2025 10:02:27 GMT, Christian Stein wrote: >> snake66 has updated the pull request incrementally with two additional commits since the last revision: >> >> - Update copyright notice >> - Add @bug and @comment tags > > Looks good to me @sormuras Thanks for the review and help! ------------- PR Comment: https://git.openjdk.org/jtreg/pull/261#issuecomment-2858082374 From duke at openjdk.org Wed May 7 10:49:26 2025 From: duke at openjdk.org (duke) Date: Wed, 7 May 2025 10:49:26 GMT Subject: RFR: 7904002: @compile directives with args after file name fail after 7903955 [v3] In-Reply-To: References:

Message-ID: <7GVYbDcBukZLvjrNdP4qD4QVysqZvGZdRuox-lWU-8U=.8b57eed6-4130-4b76-8b81-0234d41b01ab@github.com> On Wed, 7 May 2025 09:44:41 GMT, snake66 wrote: >> This work is sponsored by The FreeBSD Foundation > > snake66 has updated the pull request incrementally with two additional commits since the last revision: > > - Update copyright notice > - Add @bug and @comment tags @snake66 Your change (at version 23a1e2ef08ed4fa9cb1674d1640473666520b91a) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jtreg/pull/261#issuecomment-2858087632 From cstein at openjdk.org Wed May 7 10:54:39 2025 From: cstein at openjdk.org (Christian Stein) Date: Wed, 7 May 2025 10:54:39 GMT Subject: RFR: 7904004: Run jtreg GHA workflows for FreeBSD [v2] In-Reply-To: References: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com> Message-ID: On Wed, 7 May 2025 10:47:22 GMT, snake66 wrote: >> GitHub Actions does not natively support FreeBSD, so we use the vmactions/freebsd-vm action as a base to run the tests in a VM under an Ubuntu runner. >> >> This work is sponsored by The FreeBSD Foundation. > > snake66 has updated the pull request incrementally with one additional commit since the last revision: > > Split long line in workflow .github/workflows/test.yml line 73: > 71: sysctl hw.usermem > 72: pw user add -n action -m > 73: su action -c 'git config --global --add safe.directory /home/runner/work/jtreg/jtreg' Looks much better now, thanks for splitting the line into three calls. Can the hard-coded `/home/runner/work/jtreg/jtreg` path be replaced with some inline `pwd` evaluation? Would make it more future-proof if parent paths are changed. .github/workflows/test.yml line 74: > 72: pw user add -n action -m > 73: su action -c 'git config --global --add safe.directory /home/runner/work/jtreg/jtreg' > 74: su action -c 'bash make/build.sh --jdk /usr/local/openjdk21' I assume that the hard-coded `/usr/local/openjdk21` is well-defined and stable for `pkg ... openjdk21 ...` calls. Or is there an environment variable (`JAVA_HOME`?) being set that can be read out and used here? ------------- PR Review Comment: https://git.openjdk.org/jtreg/pull/262#discussion_r2077354169 PR Review Comment: https://git.openjdk.org/jtreg/pull/262#discussion_r2077356931 From duke at openjdk.org Wed May 7 10:54:40 2025 From: duke at openjdk.org (snake66) Date: Wed, 7 May 2025 10:54:40 GMT Subject: RFR: 7904004: Run jtreg GHA workflows for FreeBSD [v2] In-Reply-To: References: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com>

Message-ID: On Wed, 7 May 2025 10:50:03 GMT, Christian Stein wrote: >> snake66 has updated the pull request incrementally with one additional commit since the last revision: >> >> Split long line in workflow > > .github/workflows/test.yml line 73: > >> 71: sysctl hw.usermem >> 72: pw user add -n action -m >> 73: su action -c 'git config --global --add safe.directory /home/runner/work/jtreg/jtreg' > > Looks much better now, thanks for splitting the line into three calls. > > Can the hard-coded `/home/runner/work/jtreg/jtreg` path be replaced with some inline `pwd` evaluation? Would make it more future-proof if parent paths are changed. Good point! I'll look into it. Should probably be able to use `$(pwd)` or something. ------------- PR Review Comment: https://git.openjdk.org/jtreg/pull/262#discussion_r2077356545 From duke at openjdk.org Wed May 7 11:42:28 2025 From: duke at openjdk.org (snake66) Date: Wed, 7 May 2025 11:42:28 GMT Subject: RFR: 7904004: Run jtreg GHA workflows for FreeBSD [v2] In-Reply-To: References: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com>

Message-ID: On Wed, 7 May 2025 10:51:58 GMT, Christian Stein wrote: >> snake66 has updated the pull request incrementally with one additional commit since the last revision: >> >> Split long line in workflow > > .github/workflows/test.yml line 74: > >> 72: pw user add -n action -m >> 73: su action -c 'git config --global --add safe.directory /home/runner/work/jtreg/jtreg' >> 74: su action -c 'bash make/build.sh --jdk /usr/local/openjdk21' > > I assume that the hard-coded `/usr/local/openjdk21` is well-defined and stable for `pkg ... openjdk21 ...` calls. Or is there an environment variable (`JAVA_HOME`?) being set that can be read out and used here? While it's technically possible to change the prefix from `/usr/local`, this is the default unless explicitly changed. There are ways to get the path without hardcoding it, but I'm not sure it's worth the effort here: % JAVAVM_DRYRUN=1 javavm 2>/dev/null |grep JAVA_HOME|cut -d '=' -f 2 /usr/local/openjdk21 ------------- PR Review Comment: https://git.openjdk.org/jtreg/pull/262#discussion_r2077434056 From duke at openjdk.org Wed May 7 12:31:11 2025 From: duke at openjdk.org (snake66) Date: Wed, 7 May 2025 12:31:11 GMT Subject: RFR: 7904004: Run jtreg GHA workflows for FreeBSD [v3] In-Reply-To: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com> References: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com> Message-ID: > GitHub Actions does not natively support FreeBSD, so we use the vmactions/freebsd-vm action as a base to run the tests in a VM under an Ubuntu runner. > > This work is sponsored by The FreeBSD Foundation. snake66 has updated the pull request incrementally with one additional commit since the last revision: Use $(pwd) for path to checked out source dir ------------- Changes: - all: https://git.openjdk.org/jtreg/pull/262/files - new: https://git.openjdk.org/jtreg/pull/262/files/d8f66b75..1e0623ce Webrevs: - full: https://webrevs.openjdk.org/?repo=jtreg&pr=262&range=02 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=262&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jtreg/pull/262.diff Fetch: git fetch https://git.openjdk.org/jtreg.git pull/262/head:pull/262 PR: https://git.openjdk.org/jtreg/pull/262 From cstein at openjdk.org Wed May 7 12:38:28 2025 From: cstein at openjdk.org (Christian Stein) Date: Wed, 7 May 2025 12:38:28 GMT Subject: RFR: 7904004: Run jtreg GHA workflows for FreeBSD [v2] In-Reply-To: References: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com>

Message-ID: <0hwmpOWeodF5iXP_ZGkGDgBgnPIqvxyyVOScRdgFjEo=.9964471d-0378-4f8c-a9ef-d12426f076b1@github.com> On Wed, 7 May 2025 11:39:28 GMT, snake66 wrote: >> .github/workflows/test.yml line 74: >> >>> 72: pw user add -n action -m >>> 73: su action -c 'git config --global --add safe.directory /home/runner/work/jtreg/jtreg' >>> 74: su action -c 'bash make/build.sh --jdk /usr/local/openjdk21' >> >> I assume that the hard-coded `/usr/local/openjdk21` is well-defined and stable for `pkg ... openjdk21 ...` calls. Or is there an environment variable (`JAVA_HOME`?) being set that can be read out and used here? > > While it's technically possible to change the prefix from `/usr/local`, this is the default unless explicitly changed. > > There are ways to get the path without hardcoding it, but I'm not sure it's worth the effort here: > > > % JAVAVM_DRYRUN=1 javavm 2>/dev/null |grep JAVA_HOME|cut -d '=' -f 2 > /usr/local/openjdk21 The default is good-enough here, I guess. Otherwise, it would be more elegant to specify a custom location for the installation and then pass it later to subsequent processes. ------------- PR Review Comment: https://git.openjdk.org/jtreg/pull/262#discussion_r2077524883 From cstein at openjdk.org Wed May 7 13:28:40 2025 From: cstein at openjdk.org (Christian Stein) Date: Wed, 7 May 2025 13:28:40 GMT Subject: RFR: 7904004: Run jtreg GHA workflows for FreeBSD [v3] In-Reply-To: References: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com> Message-ID: On Wed, 7 May 2025 12:31:11 GMT, snake66 wrote: >> GitHub Actions does not natively support FreeBSD, so we use the vmactions/freebsd-vm action as a base to run the tests in a VM under an Ubuntu runner. >> >> This work is sponsored by The FreeBSD Foundation. > > snake66 has updated the pull request incrementally with one additional commit since the last revision: > > Use $(pwd) for path to checked out source dir Running for almost an hour now and repeating `VM is booting` over and over. This does not bode well... ![image](https://github.com/user-attachments/assets/18c1a10b-746a-4461-819d-e275736fadbb) ------------- PR Comment: https://git.openjdk.org/jtreg/pull/262#issuecomment-2858593282 From duke at openjdk.org Wed May 7 13:33:29 2025 From: duke at openjdk.org (snake66) Date: Wed, 7 May 2025 13:33:29 GMT Subject: RFR: 7904004: Run jtreg GHA workflows for FreeBSD [v3] In-Reply-To: References: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com>

Message-ID: On Wed, 7 May 2025 13:25:49 GMT, Christian Stein wrote: > Running for almost an hour now and repeating `VM is booting` over and over. This does not bode well... No, tried restarting it. Not seen this happen before. ------------- PR Comment: https://git.openjdk.org/jtreg/pull/262#issuecomment-2858627101 From cstein at openjdk.org Wed May 7 13:48:28 2025 From: cstein at openjdk.org (Christian Stein) Date: Wed, 7 May 2025 13:48:28 GMT Subject: RFR: 7904002: @compile directives with args after file name fail after 7903955 [v3] In-Reply-To: References:

Message-ID: On Wed, 7 May 2025 13:53:21 GMT, Christian Stein wrote: >> snake66 has updated the pull request incrementally with two additional commits since the last revision: >> >> - Update copyright notice >> - Add @bug and @comment tags > > Thank you, Harald! @sormuras Thank you! ------------- PR Comment: https://git.openjdk.org/jtreg/pull/261#issuecomment-2858700656 From duke at openjdk.org Wed May 7 13:57:30 2025 From: duke at openjdk.org (snake66) Date: Wed, 7 May 2025 13:57:30 GMT Subject: Integrated: 7904002: @compile directives with args after file name fail after 7903955 In-Reply-To: References: Message-ID: On Tue, 6 May 2025 09:49:07 GMT, snake66 wrote: > This work is sponsored by The FreeBSD Foundation This pull request has now been integrated. Changeset: 08368145 Author: Harald Eilertsen Committer: Christian Stein URL: https://git.openjdk.org/jtreg/commit/08368145d7114803bc6cabe2dec163b597f70fc4 Stats: 10 lines in 2 files changed: 8 ins; 0 del; 2 mod 7904002: @compile directives with args after file name fail after 7903955 Reviewed-by: cstein ------------- PR: https://git.openjdk.org/jtreg/pull/261 From ihse at openjdk.org Wed May 7 14:04:32 2025 From: ihse at openjdk.org (Magnus Ihse Bursie) Date: Wed, 7 May 2025 14:04:32 GMT Subject: RFR: 7904004: Run jtreg GHA workflows for FreeBSD [v3] In-Reply-To: References: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com> Message-ID: On Wed, 7 May 2025 12:31:11 GMT, snake66 wrote: >> GitHub Actions does not natively support FreeBSD, so we use the vmactions/freebsd-vm action as a base to run the tests in a VM under an Ubuntu runner. >> >> This work is sponsored by The FreeBSD Foundation. > > snake66 has updated the pull request incrementally with one additional commit since the last revision: > > Use $(pwd) for path to checked out source dir Seems fine to me. ------------- Marked as reviewed by ihse (Author). PR Review: https://git.openjdk.org/jtreg/pull/262#pullrequestreview-2821890071 From duke at openjdk.org Wed May 7 14:11:30 2025 From: duke at openjdk.org (snake66) Date: Wed, 7 May 2025 14:11:30 GMT Subject: RFR: 7904004: Run jtreg GHA workflows for FreeBSD [v3] In-Reply-To: References: <2_5Glpj26LKCaQkzVI5jYRMZ25L93dYGTRLq3D31kRI=.adcd75a7-bbad-48e7-b28b-15cce797e06b@github.com> Message-ID: On Wed, 7 May 2025 12:31:11 GMT, snake66 wrote: >> GitHub Actions does not natively support FreeBSD, so we use the vmactions/freebsd-vm action as a base to run the tests in a VM under an Ubuntu runner. >> >> This work is sponsored by The FreeBSD Foundation. > > snake66 has updated the pull request incrementally with one additional commit since the last revision: > > Use $(pwd) for path to checked out source dir Seems to be a known issue, and happens now and again: https://github.com/vmactions/freebsd-vm/issues/91 I understand if that's a showstopper for now. ------------- PR Comment: https://git.openjdk.org/jtreg/pull/262#issuecomment-2858746524 From cstein at openjdk.org Wed May 7 14:20:39 2025 From: cstein at openjdk.org (Christian Stein) Date: Wed, 7 May 2025 14:20:39 GMT Subject: RFR: 7903519 : jtreg/jtharness is missing features for basic crash testing In-Reply-To: <1k_V7Eg7B_QW6-WNSNhWWezgOgfLFLnS5zK85TfTiZ0=.b616aac4-079f-4023-adb6-7e4542c7d856@github.com> References: <1k_V7Eg7B_QW6-WNSNhWWezgOgfLFLnS5zK85TfTiZ0=.b616aac4-079f-4023-adb6-7e4542c7d856@github.com> Message-ID: On Wed, 6 Nov 2024 01:45:22 GMT, andrlos wrote: > provides SPI for enabling external status transformations of failed tests > > this is a continuation of efforts after https://github.com/openjdk/jtharness/pull/59 > > Requires newest jtharness build (not even tagged yet) that includes above mentioned change to be compiled succesfully > > The main idea is to provide a unified StatusTransformer interface, that can be externally implemented by users and added to a classpath in a separate jar to allow modifications of test execution status based on some elementary analysis. This can be easily used for crashtesting (filtering out only tests with jvm crashes). What I still don't get is that you want to address a global goal "basic crash testing" with a very local mechanism, like something similar to JUnit 4 "TestRule". I think a solution lies in between your lines: > it proved to be much harder to filter them after, as the `hs_err_pid` log is not being copied, plus we have many tests that run via a shell script, so a generic jvm watcher is not an option as would be the option with jvm agent that we use for junit testing.. we need to cover cases, where jvm crashes even tho it has been run via a shell script (or multiple levels of scripts) and watching for `hs_err_pid.log` proved to be the most reliable and universal approach. So, what about making sure that `jtreg` copies `hs_err_pid` files correctly? ------------- PR Comment: https://git.openjdk.org/jtreg/pull/235#issuecomment-2858774418