From jvernee at openjdk.org  Mon Nov  3 15:16:49 2025
From: jvernee at openjdk.org (Jorn Vernee)
Date: Mon, 3 Nov 2025 15:16:49 GMT
Subject: RFR: 7904110: IDEA plugin: Update plugin for new message format
 [v2]
In-Reply-To: <d-0QgpPbWNAMQ9UxvMXFEyzW_Vdxhbu8ZJN5n0QdVvU=.81923932-98e4-4776-b535-c1bcd648d649@github.com>
References: <d-0QgpPbWNAMQ9UxvMXFEyzW_Vdxhbu8ZJN5n0QdVvU=.81923932-98e4-4776-b535-c1bcd648d649@github.com>
Message-ID: <1kW6RWv8Lj6OkHcGZIqhz7WsFyKvVOS7TeiASRWmLuQ=.9eadbe72-975c-41a6-af49-a8bf99c6c315@github.com>

> The JUnit output was updated to include a timestamp in https://github.com/openjdk/jtreg/commit/470718a0637fbfd9a883de66e7955a4c26e05760
> 
> This patch updates the parser in the idea plugin to be able to handle the timestamps.

Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:

  Use regex + fix parsing of SKIPPED tests

-------------

Changes:
  - all: https://git.openjdk.org/jtreg/pull/300/files
  - new: https://git.openjdk.org/jtreg/pull/300/files/4d22c4dc..b535ad74

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jtreg&pr=300&range=01
 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=300&range=00-01

  Stats: 49 lines in 1 file changed: 21 ins; 10 del; 18 mod
  Patch: https://git.openjdk.org/jtreg/pull/300.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/300/head:pull/300

PR: https://git.openjdk.org/jtreg/pull/300

From jvernee at openjdk.org  Mon Nov  3 15:16:51 2025
From: jvernee at openjdk.org (Jorn Vernee)
Date: Mon, 3 Nov 2025 15:16:51 GMT
Subject: RFR: 7904110: IDEA plugin: Update plugin for new message format
 [v2]
In-Reply-To: <5hOQLT48S1xKTbw4Wp0UArATLZfTqq76mW7QFmzPGM4=.9f07381d-af12-43b0-a670-53d18bd2ae1b@github.com>
References: <d-0QgpPbWNAMQ9UxvMXFEyzW_Vdxhbu8ZJN5n0QdVvU=.81923932-98e4-4776-b535-c1bcd648d649@github.com>
 <5hOQLT48S1xKTbw4Wp0UArATLZfTqq76mW7QFmzPGM4=.9f07381d-af12-43b0-a670-53d18bd2ae1b@github.com>
Message-ID: <Hevi0UTjTGlwEtfkkXEKjxhjPryh5vanYcJmLhVKGFw=.bd6073a8-cf71-4427-9056-f5ecc0c78e3b@github.com>

On Fri, 31 Oct 2025 19:02:06 GMT, Christian Stein <cstein at openjdk.org> wrote:

> This might be a bit too lenient in some cases, but also supports the new message format.

Yeah, you're right. I've pushed another commit that uses a regex to look for the pattern we are interested in. That should be much more robust.

I also noticed that SKIPPED tests were not being parsed correctly, because they do not have a corresponding `STARTED` message as the parser currently expects. So, I've change the code to expect either:
- a `STARTED` message, in which case we will look for a `SUCCESSFUL` or `FAILED` message, and treat all the lines in between as `stderr` output from the test.
- a `SKIPPED` message, in which case we also look for a 'reason' message on the same line, but after that continue looking for the next test's output.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/300#issuecomment-3481043250

From jvernee at openjdk.org  Mon Nov  3 15:16:53 2025
From: jvernee at openjdk.org (Jorn Vernee)
Date: Mon, 3 Nov 2025 15:16:53 GMT
Subject: RFR: 7904110: IDEA plugin: Update plugin for new message format
 [v2]
In-Reply-To: <1kW6RWv8Lj6OkHcGZIqhz7WsFyKvVOS7TeiASRWmLuQ=.9eadbe72-975c-41a6-af49-a8bf99c6c315@github.com>
References: <d-0QgpPbWNAMQ9UxvMXFEyzW_Vdxhbu8ZJN5n0QdVvU=.81923932-98e4-4776-b535-c1bcd648d649@github.com>
 <1kW6RWv8Lj6OkHcGZIqhz7WsFyKvVOS7TeiASRWmLuQ=.9eadbe72-975c-41a6-af49-a8bf99c6c315@github.com>
Message-ID: <Tmm9LTZzEIjOljMi3GE7Jb7QPN20xBoii9yS4x8glnI=.6e937ba6-8c11-40ca-97d3-eecd5deec0b1@github.com>

On Mon, 3 Nov 2025 15:13:49 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> The JUnit output was updated to include a timestamp in https://github.com/openjdk/jtreg/commit/470718a0637fbfd9a883de66e7955a4c26e05760
>> 
>> This patch updates the parser in the idea plugin to be able to handle the timestamps.
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use regex + fix parsing of SKIPPED tests

plugins/idea/src/main/java/com/oracle/plugin/jtreg/runtime/JTRegTestListener.java line 252:

> 250: 
> 251:             private record Iteration(int num, String name) {
> 252:                 private static final Pattern PATTERN = Pattern.compile("\\[(?<num>\\d+)] (?<name>.*)");

The `'` characters here are now included in the `JUNIT_TEST_START` pattern.

plugins/idea/src/main/java/com/oracle/plugin/jtreg/runtime/JTRegTestListener.java line 312:

> 310:                     String[] lineParts = line.split(" ");
> 311:                     String duration = lineParts[lineParts.length -1]; // e.g. '[64ms]'
> 312:                     duration = duration.substring(1, duration.length() - 3); // drop '[' and 'ms]'

This parsing is now also handled by the regex.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/300#discussion_r2486828742
PR Review Comment: https://git.openjdk.org/jtreg/pull/300#discussion_r2486832899

From cstein at openjdk.org  Mon Nov  3 16:29:33 2025
From: cstein at openjdk.org (Christian Stein)
Date: Mon, 3 Nov 2025 16:29:33 GMT
Subject: RFR: 7904110: IDEA plugin: Update plugin for new message format
 [v2]
In-Reply-To: <1kW6RWv8Lj6OkHcGZIqhz7WsFyKvVOS7TeiASRWmLuQ=.9eadbe72-975c-41a6-af49-a8bf99c6c315@github.com>
References: <d-0QgpPbWNAMQ9UxvMXFEyzW_Vdxhbu8ZJN5n0QdVvU=.81923932-98e4-4776-b535-c1bcd648d649@github.com>
 <1kW6RWv8Lj6OkHcGZIqhz7WsFyKvVOS7TeiASRWmLuQ=.9eadbe72-975c-41a6-af49-a8bf99c6c315@github.com>
Message-ID: <yCi95CgWGFGDodHX6HRBiNuw3nekEmb_UxWgNBM7Zxw=.f369608a-779d-464a-bac7-218f97a30fb3@github.com>

On Mon, 3 Nov 2025 15:16:49 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> The JUnit output was updated to include a timestamp in https://github.com/openjdk/jtreg/commit/470718a0637fbfd9a883de66e7955a4c26e05760
>> 
>> This patch updates the parser in the idea plugin to be able to handle the timestamps.
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use regex + fix parsing of SKIPPED tests

> That should be much more robust.

It is. Re-approved.

-------------

Marked as reviewed by cstein (Reviewer).

PR Review: https://git.openjdk.org/jtreg/pull/300#pullrequestreview-3411873447

From cstein at openjdk.org  Mon Nov  3 16:29:36 2025
From: cstein at openjdk.org (Christian Stein)
Date: Mon, 3 Nov 2025 16:29:36 GMT
Subject: RFR: 7904110: IDEA plugin: Update plugin for new message format
 [v2]
In-Reply-To: <Tmm9LTZzEIjOljMi3GE7Jb7QPN20xBoii9yS4x8glnI=.6e937ba6-8c11-40ca-97d3-eecd5deec0b1@github.com>
References: <d-0QgpPbWNAMQ9UxvMXFEyzW_Vdxhbu8ZJN5n0QdVvU=.81923932-98e4-4776-b535-c1bcd648d649@github.com>
 <1kW6RWv8Lj6OkHcGZIqhz7WsFyKvVOS7TeiASRWmLuQ=.9eadbe72-975c-41a6-af49-a8bf99c6c315@github.com>
 <Tmm9LTZzEIjOljMi3GE7Jb7QPN20xBoii9yS4x8glnI=.6e937ba6-8c11-40ca-97d3-eecd5deec0b1@github.com>
Message-ID: <DBE2KaQ1jEn4Wk9Bz8QZ828IaUvRKMMVSb5j0-vphic=.ce929fbb-335e-4e6e-b4ce-d3c9ba0b7d5d@github.com>

On Mon, 3 Nov 2025 15:12:39 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use regex + fix parsing of SKIPPED tests
>
> plugins/idea/src/main/java/com/oracle/plugin/jtreg/runtime/JTRegTestListener.java line 252:
> 
>> 250: 
>> 251:             private record Iteration(int num, String name) {
>> 252:                 private static final Pattern PATTERN = Pattern.compile("\\[(?<num>\\d+)] (?<name>.*)");
> 
> The `'` characters here are now included in the `JUNIT_TEST_START` pattern.

Good!

> plugins/idea/src/main/java/com/oracle/plugin/jtreg/runtime/JTRegTestListener.java line 312:
> 
>> 310:                     String[] lineParts = line.split(" ");
>> 311:                     String duration = lineParts[lineParts.length -1]; // e.g. '[64ms]'
>> 312:                     duration = duration.substring(1, duration.length() - 3); // drop '[' and 'ms]'
> 
> This parsing is now also handled by the regex.

Better!

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/300#discussion_r2487104534
PR Review Comment: https://git.openjdk.org/jtreg/pull/300#discussion_r2487104971

From jvernee at openjdk.org  Mon Nov  3 16:42:13 2025
From: jvernee at openjdk.org (Jorn Vernee)
Date: Mon, 3 Nov 2025 16:42:13 GMT
Subject: RFR: 7904110: IDEA plugin: Update plugin for new message format
 [v3]
In-Reply-To: <d-0QgpPbWNAMQ9UxvMXFEyzW_Vdxhbu8ZJN5n0QdVvU=.81923932-98e4-4776-b535-c1bcd648d649@github.com>
References: <d-0QgpPbWNAMQ9UxvMXFEyzW_Vdxhbu8ZJN5n0QdVvU=.81923932-98e4-4776-b535-c1bcd648d649@github.com>
Message-ID: <dPt2KC3CiruO86xg6Tcdcanu0pdnrEp6h9ivYW6UY2U=.90ad22e1-ba67-48a4-bd6c-a9e43f6e2bbd@github.com>

> The JUnit output was updated to include a timestamp in https://github.com/openjdk/jtreg/commit/470718a0637fbfd9a883de66e7955a4c26e05760
> 
> This patch updates the parser in the idea plugin to be able to handle the timestamps.

Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:

  Add readme updates

-------------

Changes:
  - all: https://git.openjdk.org/jtreg/pull/300/files
  - new: https://git.openjdk.org/jtreg/pull/300/files/b535ad74..73ce4540

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jtreg&pr=300&range=02
 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=300&range=01-02

  Stats: 10 lines in 2 files changed: 3 ins; 6 del; 1 mod
  Patch: https://git.openjdk.org/jtreg/pull/300.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/300/head:pull/300

PR: https://git.openjdk.org/jtreg/pull/300

From cstein at openjdk.org  Mon Nov  3 16:42:14 2025
From: cstein at openjdk.org (Christian Stein)
Date: Mon, 3 Nov 2025 16:42:14 GMT
Subject: RFR: 7904110: IDEA plugin: Update plugin for new message format
 [v3]
In-Reply-To: <dPt2KC3CiruO86xg6Tcdcanu0pdnrEp6h9ivYW6UY2U=.90ad22e1-ba67-48a4-bd6c-a9e43f6e2bbd@github.com>
References: <d-0QgpPbWNAMQ9UxvMXFEyzW_Vdxhbu8ZJN5n0QdVvU=.81923932-98e4-4776-b535-c1bcd648d649@github.com>
 <dPt2KC3CiruO86xg6Tcdcanu0pdnrEp6h9ivYW6UY2U=.90ad22e1-ba67-48a4-bd6c-a9e43f6e2bbd@github.com>
Message-ID: <5zDVv1XO0umufB4ygDPbLYm5vljX10_NNxSz51IMhf0=.3e837608-260d-4d3b-a30a-e1addd304a54@github.com>

On Mon, 3 Nov 2025 16:38:59 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> The JUnit output was updated to include a timestamp in https://github.com/openjdk/jtreg/commit/470718a0637fbfd9a883de66e7955a4c26e05760
>> 
>> This patch updates the parser in the idea plugin to be able to handle the timestamps.
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add readme updates

Marked as reviewed by cstein (Reviewer).

-------------

PR Review: https://git.openjdk.org/jtreg/pull/300#pullrequestreview-3411920835

From jvernee at openjdk.org  Mon Nov  3 16:42:16 2025
From: jvernee at openjdk.org (Jorn Vernee)
Date: Mon, 3 Nov 2025 16:42:16 GMT
Subject: RFR: 7904110: IDEA plugin: Update plugin for new message format
 [v2]
In-Reply-To: <1kW6RWv8Lj6OkHcGZIqhz7WsFyKvVOS7TeiASRWmLuQ=.9eadbe72-975c-41a6-af49-a8bf99c6c315@github.com>
References: <d-0QgpPbWNAMQ9UxvMXFEyzW_Vdxhbu8ZJN5n0QdVvU=.81923932-98e4-4776-b535-c1bcd648d649@github.com>
 <1kW6RWv8Lj6OkHcGZIqhz7WsFyKvVOS7TeiASRWmLuQ=.9eadbe72-975c-41a6-af49-a8bf99c6c315@github.com>
Message-ID: <0QSeGTXzgc8TPSiOCf5qJi5B4_LUQ8a6UsOgxp5VtgE=.d97e27d1-4b56-494b-af76-cb0dcc917b99@github.com>

On Mon, 3 Nov 2025 15:16:49 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> The JUnit output was updated to include a timestamp in https://github.com/openjdk/jtreg/commit/470718a0637fbfd9a883de66e7955a4c26e05760
>> 
>> This patch updates the parser in the idea plugin to be able to handle the timestamps.
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use regex + fix parsing of SKIPPED tests

Per request, I've also added the readme updates from https://github.com/openjdk/jtreg/pull/24

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/300#issuecomment-3481454763

From jvernee at openjdk.org  Mon Nov  3 16:42:17 2025
From: jvernee at openjdk.org (Jorn Vernee)
Date: Mon, 3 Nov 2025 16:42:17 GMT
Subject: Integrated: 7904110: IDEA plugin: Update plugin for new message format
In-Reply-To: <d-0QgpPbWNAMQ9UxvMXFEyzW_Vdxhbu8ZJN5n0QdVvU=.81923932-98e4-4776-b535-c1bcd648d649@github.com>
References: <d-0QgpPbWNAMQ9UxvMXFEyzW_Vdxhbu8ZJN5n0QdVvU=.81923932-98e4-4776-b535-c1bcd648d649@github.com>
Message-ID: <Bo7DBrkYtZwI0BOuzSigrMFX0akBpXu1bkeLqYNH74w=.24dcd952-c912-4111-a2a4-9d42152f78f3@github.com>

On Fri, 31 Oct 2025 18:08:52 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> The JUnit output was updated to include a timestamp in https://github.com/openjdk/jtreg/commit/470718a0637fbfd9a883de66e7955a4c26e05760
> 
> This patch updates the parser in the idea plugin to be able to handle the timestamps.

This pull request has now been integrated.

Changeset: a6a32dd7
Author:    Jorn Vernee <jvernee at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/a6a32dd7c8250b4c06e904ccc94ffbcd8f009a43
Stats:     59 lines in 3 files changed: 25 ins; 16 del; 18 mod

7904110: IDEA plugin: Update plugin for new message format

Reviewed-by: cstein

-------------

PR: https://git.openjdk.org/jtreg/pull/300