RFR: 7904105: intermittent test failure in CleanupDirTests.agentvm.conc
Jaikiran Pai
jpai at openjdk.org
Tue Oct 28 08:48:40 UTC 2025
On Tue, 28 Oct 2025 03:12:34 GMT, Vladimir Petko <vpetko at openjdk.org> wrote:
> jtharness does not synchronize calls to Observer. Synchronized keyword needs to be added when processing shared state.
>
> ---------
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
>
> ### Error
> ⚠️ The pull request body must not be empty.
>
>
>
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
>
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.org/jtreg.git pull/297/head:pull/297` \
> `$ git checkout pull/297`
>
> Update a local copy of the PR: \
> `$ git checkout pull/297` \
> `$ git pull https://git.openjdk.org/jtreg.git pull/297/head`
>
> </details>
> <details><summary>Using Skara CLI tools</summary>
>
> Checkout this PR locally: \
> `$ git pr checkout 297`
>
> View PR using the GUI difftool: \
> `$ git pr show -t 297`
>
> </details>
> <details><summary>Using diff file</summary>
>
> Download this PR as a diff file: \
> <a href="https://git.openjdk.org/jtreg/pull/297.diff">https://git.openjdk.org/jtreg/pull/297.diff</a>
>
> </details>
Hello Vladimir, we have seen intermittent failure in this test too, but i haven't had a chance to look deeper.
`TestStats` deals with counts in several different methods, so I'm not completely sure the proposed change is enough or the best way to address this. It may be that the code in `TestStats` itself might need to be addressed in some manner.
-------------
PR Comment: https://git.openjdk.org/jtreg/pull/297#issuecomment-3455233085
More information about the jtreg-dev
mailing list