RFR: 7904074: Introduce a way to disallow certain test actions
Christian Stein
cstein at openjdk.org
Sat Sep 6 13:59:27 UTC 2025
On Fri, 5 Sep 2025 12:01:33 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this enhancement which introduces the ability to configure test actions which are disallowed to be used in test definitions? This addresses https://bugs.openjdk.org/browse/CODETOOLS-7904074.
>
> This introduces a new `disallowedActions` test configuration, which can be set in `TEST.ROOT` or `TEST.properties` file(s) to allow projects to configure test actions that aren't allowed for those projects. For example, the JDK project could be configured with:
>
>
> disallowedActions=applet
>
> so that any new (or existing) test definitions with a `@run applet` will cause those tests to error.
>
> A new self test has been introduced which verifies this feature. I have also run manual tests to make sure that this feature can be used in the JDK.
Implementation and tests look good!
Nit: too many `final` modifiers introduced, compared to prior-art code.
-------------
Marked as reviewed by cstein (Reviewer).
PR Review: https://git.openjdk.org/jtreg/pull/285#pullrequestreview-3192808655
More information about the jtreg-dev
mailing list