RFR: 7904153: JTReg should include crash log data in the failure node for xml reports [v2]
Jaikiran Pai
jpai at openjdk.org
Wed Feb 18 17:56:40 UTC 2026
On Wed, 18 Feb 2026 17:53:31 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> The system we use (AWS CodeBuild) for running JTReg understands Junit/testNG xml files. For failed tests, it makes the text from the `failure` node easy to access from the UI. I appreciate that these xml files already have `system.err` and `system.out` nodes, but the tooling we use doesn't expose the data here (and I cannot change that tooling). Also, the current implementation takes the first section of `stderr` or `stdout`, which is often empty and comes from the `javac` portion of the test run.
>
> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>
> Use the last output for a section to get the failure. Only do this for the failure node
src/share/classes/com/sun/javatest/regtest/report/XMLWriter.java line 273:
> 271: line.contains("SIGABRT") || line.contains("problematic frame") ||
> 272: line.contains("Internal Error") || line.contains("fatal error"))) {
> 273: inCrash = true;
It feels a bit arbitrary that we are looking for this content to detect a test which has caused a JVM crash. In the systems where these jtreg generated XML reports are being used, are the JVM crash files (hs_err...) not being generated? Wouldn't those already have the necessary crash details? I am guessing that even if these 100 odd lines were to be printed out in the XML report, the actual hs_err file would still be needed to understand what caused the crash.
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/316#discussion_r2822790574
More information about the jtreg-dev
mailing list