RFR: 7904141: JTReg should support running compact source files [v7]
Jaikiran Pai
jpai at openjdk.org
Thu Feb 19 15:42:27 UTC 2026
On Thu, 19 Feb 2026 07:47:09 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Please review this change that adds support for running [JEP 512: Compact Source Files and Instance Main Methods](https://openjdk.org/jeps/512) as jtreg `main` tests.
>>
>> This pull request also adds JDK 25 to the GHA-based CI workflow and updates to use newer GitHub actions: `actions/checkout at v6` and `actions/setup-java at v5`
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>
> Address review suggestions
test/compactsourcefile/CompactSourceFileTest.gmk line 8:
> 6: # under the terms of the GNU General Public License version 2 only, as
> 7: # published by the Free Software Foundation. Oracle designates this
> 8: # particular file as subject to the "Classpath" exception as provided
Looks like a copy/paste error - Classpath exceptions aren't needed for test files.
test/compactsourcefile/CompactSourceFileTest.gmk line 28:
> 26: #----------------------------------------------------------------------
> 27:
> 28: ifdef JDK8HOME
I think we should instead do `ifndef JDK25HOME` here and verify that the jtreg test fails when the Java version is lesser than 25.
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/313#discussion_r2828579640
PR Review Comment: https://git.openjdk.org/jtreg/pull/313#discussion_r2828589502
More information about the jtreg-dev
mailing list