From jpai at openjdk.org  Mon Jan  5 14:29:18 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Mon, 5 Jan 2026 14:29:18 GMT
Subject: RFR: 7904125: JUnit test discovery issues must result in jtreg test
 failure
Message-ID: <IDSq6do6yy9cDnYRcTFmzb7okE3xx99-IWsSXCWo_tA=.ae27c4ee-736d-4c7e-af7b-186f1c1056e2@github.com>

Can I please get a review of this change which proposes to fail a jtreg test if there were  any junit test engine discovery errors? This addresses https://bugs.openjdk.org/browse/CODETOOLS-7904125.

This change should prevent issues like https://bugs.openjdk.org/browse/JDK-8374434 where the warning is being logged by junit but they go unnoticed because there's no test failure raised for those issues.

A new self test has been introduced to reproduce the issue and verify the change.

-------------

Commit messages:
 - copyright year
 - add code comment
 - add self test
 - 7904125: Report JUnit issues encountered during test discovery

Changes: https://git.openjdk.org/jtreg/pull/304/files
  Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=304&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904125
  Stats: 105 lines in 4 files changed: 104 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jtreg/pull/304.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/304/head:pull/304

PR: https://git.openjdk.org/jtreg/pull/304

From jpai at openjdk.org  Tue Jan  6 05:34:34 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 6 Jan 2026 05:34:34 GMT
Subject: RFR: 7904126: PrintWriter(s) used by jtreg for agent logging aren't
 using autoFlush
Message-ID: <85KtA4ckuTaxc6qMYaWPp4QRcFYyZGTUTKGMrLTzEgc=.991c06bf-2e35-4872-bebf-f26f759091ca@github.com>

Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7904126? 

With this change the logs written out to agent.trace and agentServer.<id>.trace should now have these log message more promptly written out and thus help debug and unexpected test failures. Furthermore, the explicit flush() that was done in https://bugs.openjdk.org/browse/CODETOOLS-7903470 has now been replaced with the use of this autoFlush=true to avoid having to explicitly flush() at any call sites where the logger is used to write out the logs.

Given the nature of the change no new self tests have been introduced.

-------------

Commit messages:
 - 7904126: PrintWriter(s) used by jtreg for agent logging aren't using autoFlush

Changes: https://git.openjdk.org/jtreg/pull/305/files
  Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=305&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904126
  Stats: 6 lines in 2 files changed: 0 ins; 1 del; 5 mod
  Patch: https://git.openjdk.org/jtreg/pull/305.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/305/head:pull/305

PR: https://git.openjdk.org/jtreg/pull/305

From cstein at openjdk.org  Wed Jan  7 09:12:42 2026
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 7 Jan 2026 09:12:42 GMT
Subject: RFR: 7904125: JUnit test discovery issues must result in jtreg
 test failure
In-Reply-To: <IDSq6do6yy9cDnYRcTFmzb7okE3xx99-IWsSXCWo_tA=.ae27c4ee-736d-4c7e-af7b-186f1c1056e2@github.com>
References: <IDSq6do6yy9cDnYRcTFmzb7okE3xx99-IWsSXCWo_tA=.ae27c4ee-736d-4c7e-af7b-186f1c1056e2@github.com>
Message-ID: <d_dtkPEQ2E7T0-wpk937eL0PQBguufibpaKwUggg4J8=.5e631a77-135b-4349-81d5-76e480bcf0f2@github.com>

On Mon, 5 Jan 2026 14:22:01 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to fail a jtreg test if there were  any junit test engine discovery errors? This addresses https://bugs.openjdk.org/browse/CODETOOLS-7904125.
> 
> This change should prevent issues like https://bugs.openjdk.org/browse/JDK-8374434 where the warning is being logged by junit but they go unnoticed because there's no test failure raised for those issues.
> 
> A new self test has been introduced to reproduce the issue and verify the change.

Looks good.

-------------

Marked as reviewed by cstein (Reviewer).

PR Review: https://git.openjdk.org/jtreg/pull/304#pullrequestreview-3633952835

From jpai at openjdk.org  Wed Jan  7 10:05:13 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Wed, 7 Jan 2026 10:05:13 GMT
Subject: RFR: 7904125: JUnit test discovery issues must result in jtreg
 test failure
In-Reply-To: <IDSq6do6yy9cDnYRcTFmzb7okE3xx99-IWsSXCWo_tA=.ae27c4ee-736d-4c7e-af7b-186f1c1056e2@github.com>
References: <IDSq6do6yy9cDnYRcTFmzb7okE3xx99-IWsSXCWo_tA=.ae27c4ee-736d-4c7e-af7b-186f1c1056e2@github.com>
Message-ID: <UqRstyk8EKQO2Mf9X2mi2LuJwktiVdvy0jqf-Wowb0U=.33146bbe-c401-4272-bf0b-fc31fd3f0975@github.com>

On Mon, 5 Jan 2026 14:22:01 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to fail a jtreg test if there were  any junit test engine discovery errors? This addresses https://bugs.openjdk.org/browse/CODETOOLS-7904125.
> 
> This change should prevent issues like https://bugs.openjdk.org/browse/JDK-8374434 where the warning is being logged by junit but they go unnoticed because there's no test failure raised for those issues.
> 
> A new self test has been introduced to reproduce the issue and verify the change.

Thank you Christian for the review.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/304#issuecomment-3718111858

From jpai at openjdk.org  Wed Jan  7 10:05:15 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Wed, 7 Jan 2026 10:05:15 GMT
Subject: Integrated: 7904125: JUnit test discovery issues must result in jtreg
 test failure
In-Reply-To: <IDSq6do6yy9cDnYRcTFmzb7okE3xx99-IWsSXCWo_tA=.ae27c4ee-736d-4c7e-af7b-186f1c1056e2@github.com>
References: <IDSq6do6yy9cDnYRcTFmzb7okE3xx99-IWsSXCWo_tA=.ae27c4ee-736d-4c7e-af7b-186f1c1056e2@github.com>
Message-ID: <Ioei82iu9z8d-oWpkRftIYefoJRWx4sSCO8pU1wpBaY=.ca06f224-791b-418c-b665-986dddb68aaf@github.com>

On Mon, 5 Jan 2026 14:22:01 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to fail a jtreg test if there were  any junit test engine discovery errors? This addresses https://bugs.openjdk.org/browse/CODETOOLS-7904125.
> 
> This change should prevent issues like https://bugs.openjdk.org/browse/JDK-8374434 where the warning is being logged by junit but they go unnoticed because there's no test failure raised for those issues.
> 
> A new self test has been introduced to reproduce the issue and verify the change.

This pull request has now been integrated.

Changeset: 0d4599af
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/0d4599affce64a7bc599e335cfb4836bf2f06818
Stats:     105 lines in 4 files changed: 104 ins; 0 del; 1 mod

7904125: JUnit test discovery issues must result in jtreg test failure

Reviewed-by: cstein

-------------

PR: https://git.openjdk.org/jtreg/pull/304

From cstein at openjdk.org  Wed Jan  7 11:06:52 2026
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 7 Jan 2026 11:06:52 GMT
Subject: RFR: 7904126: PrintWriter(s) used by jtreg for agent logging
 aren't using autoFlush
In-Reply-To: <85KtA4ckuTaxc6qMYaWPp4QRcFYyZGTUTKGMrLTzEgc=.991c06bf-2e35-4872-bebf-f26f759091ca@github.com>
References: <85KtA4ckuTaxc6qMYaWPp4QRcFYyZGTUTKGMrLTzEgc=.991c06bf-2e35-4872-bebf-f26f759091ca@github.com>
Message-ID: <GOlksPHsg6Fw1g0g_sylf_3IhELkPW6ldJEvl_T3Ld4=.4dc814ce-1239-4f02-8a79-f943ae696f55@github.com>

On Tue, 6 Jan 2026 05:27:48 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7904126? 
> 
> With this change the logs written out to agent.trace and agentServer.<id>.trace should now have these log message more promptly written out and thus help debug and unexpected test failures. Furthermore, the explicit flush() that was done in https://bugs.openjdk.org/browse/CODETOOLS-7903470 has now been replaced with the use of this autoFlush=true to avoid having to explicitly flush() at any call sites where the logger is used to write out the logs.
> 
> Given the nature of the change no new self tests have been introduced.

Looks reasonable.

-------------

Marked as reviewed by cstein (Reviewer).

PR Review: https://git.openjdk.org/jtreg/pull/305#pullrequestreview-3634368684

From jpai at openjdk.org  Wed Jan  7 11:31:58 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Wed, 7 Jan 2026 11:31:58 GMT
Subject: RFR: 7904126: PrintWriter(s) used by jtreg for agent logging
 aren't using autoFlush
In-Reply-To: <85KtA4ckuTaxc6qMYaWPp4QRcFYyZGTUTKGMrLTzEgc=.991c06bf-2e35-4872-bebf-f26f759091ca@github.com>
References: <85KtA4ckuTaxc6qMYaWPp4QRcFYyZGTUTKGMrLTzEgc=.991c06bf-2e35-4872-bebf-f26f759091ca@github.com>
Message-ID: <UzuSdMS3QMvxeBNpvhW6sTjweity0iLC7GcyQfDVK2o=.e21e7f68-8b2b-492f-b135-6df4f6711142@github.com>

On Tue, 6 Jan 2026 05:27:48 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7904126? 
> 
> With this change the logs written out to agent.trace and agentServer.<id>.trace should now have these log message more promptly written out and thus help debug and unexpected test failures. Furthermore, the explicit flush() that was done in https://bugs.openjdk.org/browse/CODETOOLS-7903470 has now been replaced with the use of this autoFlush=true to avoid having to explicitly flush() at any call sites where the logger is used to write out the logs.
> 
> Given the nature of the change no new self tests have been introduced.

Thank you for the review, Christian.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/305#issuecomment-3718427269

From jpai at openjdk.org  Wed Jan  7 11:31:59 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Wed, 7 Jan 2026 11:31:59 GMT
Subject: Integrated: 7904126: PrintWriter(s) used by jtreg for agent logging
 aren't using autoFlush
In-Reply-To: <85KtA4ckuTaxc6qMYaWPp4QRcFYyZGTUTKGMrLTzEgc=.991c06bf-2e35-4872-bebf-f26f759091ca@github.com>
References: <85KtA4ckuTaxc6qMYaWPp4QRcFYyZGTUTKGMrLTzEgc=.991c06bf-2e35-4872-bebf-f26f759091ca@github.com>
Message-ID: <fOvqZVnaV0p4Mcl6F-oaBRIOy384NKs_p96OMoMjIEM=.5603ddb9-ce90-4be1-a4fd-94699046c061@github.com>

On Tue, 6 Jan 2026 05:27:48 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7904126? 
> 
> With this change the logs written out to agent.trace and agentServer.<id>.trace should now have these log message more promptly written out and thus help debug and unexpected test failures. Furthermore, the explicit flush() that was done in https://bugs.openjdk.org/browse/CODETOOLS-7903470 has now been replaced with the use of this autoFlush=true to avoid having to explicitly flush() at any call sites where the logger is used to write out the logs.
> 
> Given the nature of the change no new self tests have been introduced.

This pull request has now been integrated.

Changeset: 328147bd
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/328147bd1f6e188102a5c3ba9541dc1cd383220f
Stats:     6 lines in 2 files changed: 0 ins; 1 del; 5 mod

7904126: PrintWriter(s) used by jtreg for agent logging aren't using autoFlush

Reviewed-by: cstein

-------------

PR: https://git.openjdk.org/jtreg/pull/305

From cstein at openjdk.org  Wed Jan  7 16:30:01 2026
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 7 Jan 2026 16:30:01 GMT
Subject: RFR: 7904129: Update jtreg to bundle JUnit 5.14.2
Message-ID: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>

Please review this change updating the JUnit version to [5.14.2](https://docs.junit.org/5.14.2/release-notes.html).

-------------

Commit messages:
 - 7904129: Update jtreg to bundle JUnit 5.14.2

Changes: https://git.openjdk.org/jtreg/pull/306/files
  Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=306&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904129
  Stats: 5 lines in 2 files changed: 1 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jtreg/pull/306.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/306/head:pull/306

PR: https://git.openjdk.org/jtreg/pull/306

From jpai at openjdk.org  Thu Jan  8 01:12:10 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Thu, 8 Jan 2026 01:12:10 GMT
Subject: RFR: 7904129: Update jtreg to bundle JUnit 5.14.2
In-Reply-To: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>
References: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>
Message-ID: <rUdP-yacWSXVj3BIsv8zT4H5jUV0ZsqxMNnSTtUEFlA=.360b4a43-ae0e-441f-b213-19068e11d207@github.com>

On Wed, 7 Jan 2026 15:54:41 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change updating the JUnit version to [5.14.2](https://docs.junit.org/5.14.2/release-notes.html).

This looks OK to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jtreg/pull/306#pullrequestreview-3637341800

From cstein at openjdk.org  Thu Jan  8 15:25:59 2026
From: cstein at openjdk.org (Christian Stein)
Date: Thu, 8 Jan 2026 15:25:59 GMT
Subject: RFR: 7904129: Update jtreg to bundle JUnit 5.14.2
In-Reply-To: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>
References: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>
Message-ID: <DBRrTLkDgAahr0t42-Hhfd-UFqCviACARmptKSoZ0Qk=.52fc562e-5083-4869-9933-2d229cbe207f@github.com>

On Wed, 7 Jan 2026 15:54:41 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change updating the JUnit version to [5.14.2](https://docs.junit.org/5.14.2/release-notes.html).

make/build-support/version-numbers line 45:

> 43: # JUnit 5 = JUnit Platform 1.y.z + JUnit Jupiter 5.y.z + JUnit Vintage 5.y.z
> 44: DEFAULT_JUNIT_VERSION=1.14.2
> 45: DEFAULT_JUNIT_JAR_CHECKSUM=99b3e0fe1df38e5eea763c168c033c030a4bd46c

Checksum copied from https://repo1.maven.org/maven2/org/junit/platform/junit-platform-console-standalone/1.14.2/junit-platform-console-standalone-1.14.2.jar.sha1

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/306#discussion_r2672784957

From iris at openjdk.org  Thu Jan  8 18:15:53 2026
From: iris at openjdk.org (Iris Clark)
Date: Thu, 8 Jan 2026 18:15:53 GMT
Subject: RFR: 7904129: Update jtreg to bundle JUnit 5.14.2
In-Reply-To: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>
References: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>
Message-ID: <e4fmd4a2RmhmySmS_O2Dw1iO0Xu3qzeeCn6nIMjKtyM=.fd3a23e8-de3f-4d76-ac61-147eb097e5ec@github.com>

On Wed, 7 Jan 2026 15:54:41 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change updating the JUnit version to [5.14.2](https://docs.junit.org/5.14.2/release-notes.html).

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/jtreg/pull/306#pullrequestreview-3640632023