From jpai at openjdk.org  Mon Jan  5 14:29:18 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Mon, 5 Jan 2026 14:29:18 GMT
Subject: RFR: 7904125: JUnit test discovery issues must result in jtreg test
 failure
Message-ID: <IDSq6do6yy9cDnYRcTFmzb7okE3xx99-IWsSXCWo_tA=.ae27c4ee-736d-4c7e-af7b-186f1c1056e2@github.com>

Can I please get a review of this change which proposes to fail a jtreg test if there were  any junit test engine discovery errors? This addresses https://bugs.openjdk.org/browse/CODETOOLS-7904125.

This change should prevent issues like https://bugs.openjdk.org/browse/JDK-8374434 where the warning is being logged by junit but they go unnoticed because there's no test failure raised for those issues.

A new self test has been introduced to reproduce the issue and verify the change.

-------------

Commit messages:
 - copyright year
 - add code comment
 - add self test
 - 7904125: Report JUnit issues encountered during test discovery

Changes: https://git.openjdk.org/jtreg/pull/304/files
  Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=304&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904125
  Stats: 105 lines in 4 files changed: 104 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jtreg/pull/304.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/304/head:pull/304

PR: https://git.openjdk.org/jtreg/pull/304

From jpai at openjdk.org  Tue Jan  6 05:34:34 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 6 Jan 2026 05:34:34 GMT
Subject: RFR: 7904126: PrintWriter(s) used by jtreg for agent logging aren't
 using autoFlush
Message-ID: <85KtA4ckuTaxc6qMYaWPp4QRcFYyZGTUTKGMrLTzEgc=.991c06bf-2e35-4872-bebf-f26f759091ca@github.com>

Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7904126? 

With this change the logs written out to agent.trace and agentServer.<id>.trace should now have these log message more promptly written out and thus help debug and unexpected test failures. Furthermore, the explicit flush() that was done in https://bugs.openjdk.org/browse/CODETOOLS-7903470 has now been replaced with the use of this autoFlush=true to avoid having to explicitly flush() at any call sites where the logger is used to write out the logs.

Given the nature of the change no new self tests have been introduced.

-------------

Commit messages:
 - 7904126: PrintWriter(s) used by jtreg for agent logging aren't using autoFlush

Changes: https://git.openjdk.org/jtreg/pull/305/files
  Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=305&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904126
  Stats: 6 lines in 2 files changed: 0 ins; 1 del; 5 mod
  Patch: https://git.openjdk.org/jtreg/pull/305.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/305/head:pull/305

PR: https://git.openjdk.org/jtreg/pull/305

From cstein at openjdk.org  Wed Jan  7 09:12:42 2026
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 7 Jan 2026 09:12:42 GMT
Subject: RFR: 7904125: JUnit test discovery issues must result in jtreg
 test failure
In-Reply-To: <IDSq6do6yy9cDnYRcTFmzb7okE3xx99-IWsSXCWo_tA=.ae27c4ee-736d-4c7e-af7b-186f1c1056e2@github.com>
References: <IDSq6do6yy9cDnYRcTFmzb7okE3xx99-IWsSXCWo_tA=.ae27c4ee-736d-4c7e-af7b-186f1c1056e2@github.com>
Message-ID: <d_dtkPEQ2E7T0-wpk937eL0PQBguufibpaKwUggg4J8=.5e631a77-135b-4349-81d5-76e480bcf0f2@github.com>

On Mon, 5 Jan 2026 14:22:01 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to fail a jtreg test if there were  any junit test engine discovery errors? This addresses https://bugs.openjdk.org/browse/CODETOOLS-7904125.
> 
> This change should prevent issues like https://bugs.openjdk.org/browse/JDK-8374434 where the warning is being logged by junit but they go unnoticed because there's no test failure raised for those issues.
> 
> A new self test has been introduced to reproduce the issue and verify the change.

Looks good.

-------------

Marked as reviewed by cstein (Reviewer).

PR Review: https://git.openjdk.org/jtreg/pull/304#pullrequestreview-3633952835

From jpai at openjdk.org  Wed Jan  7 10:05:13 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Wed, 7 Jan 2026 10:05:13 GMT
Subject: RFR: 7904125: JUnit test discovery issues must result in jtreg
 test failure
In-Reply-To: <IDSq6do6yy9cDnYRcTFmzb7okE3xx99-IWsSXCWo_tA=.ae27c4ee-736d-4c7e-af7b-186f1c1056e2@github.com>
References: <IDSq6do6yy9cDnYRcTFmzb7okE3xx99-IWsSXCWo_tA=.ae27c4ee-736d-4c7e-af7b-186f1c1056e2@github.com>
Message-ID: <UqRstyk8EKQO2Mf9X2mi2LuJwktiVdvy0jqf-Wowb0U=.33146bbe-c401-4272-bf0b-fc31fd3f0975@github.com>

On Mon, 5 Jan 2026 14:22:01 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to fail a jtreg test if there were  any junit test engine discovery errors? This addresses https://bugs.openjdk.org/browse/CODETOOLS-7904125.
> 
> This change should prevent issues like https://bugs.openjdk.org/browse/JDK-8374434 where the warning is being logged by junit but they go unnoticed because there's no test failure raised for those issues.
> 
> A new self test has been introduced to reproduce the issue and verify the change.

Thank you Christian for the review.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/304#issuecomment-3718111858

From jpai at openjdk.org  Wed Jan  7 10:05:15 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Wed, 7 Jan 2026 10:05:15 GMT
Subject: Integrated: 7904125: JUnit test discovery issues must result in jtreg
 test failure
In-Reply-To: <IDSq6do6yy9cDnYRcTFmzb7okE3xx99-IWsSXCWo_tA=.ae27c4ee-736d-4c7e-af7b-186f1c1056e2@github.com>
References: <IDSq6do6yy9cDnYRcTFmzb7okE3xx99-IWsSXCWo_tA=.ae27c4ee-736d-4c7e-af7b-186f1c1056e2@github.com>
Message-ID: <Ioei82iu9z8d-oWpkRftIYefoJRWx4sSCO8pU1wpBaY=.ca06f224-791b-418c-b665-986dddb68aaf@github.com>

On Mon, 5 Jan 2026 14:22:01 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to fail a jtreg test if there were  any junit test engine discovery errors? This addresses https://bugs.openjdk.org/browse/CODETOOLS-7904125.
> 
> This change should prevent issues like https://bugs.openjdk.org/browse/JDK-8374434 where the warning is being logged by junit but they go unnoticed because there's no test failure raised for those issues.
> 
> A new self test has been introduced to reproduce the issue and verify the change.

This pull request has now been integrated.

Changeset: 0d4599af
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/0d4599affce64a7bc599e335cfb4836bf2f06818
Stats:     105 lines in 4 files changed: 104 ins; 0 del; 1 mod

7904125: JUnit test discovery issues must result in jtreg test failure

Reviewed-by: cstein

-------------

PR: https://git.openjdk.org/jtreg/pull/304

From cstein at openjdk.org  Wed Jan  7 11:06:52 2026
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 7 Jan 2026 11:06:52 GMT
Subject: RFR: 7904126: PrintWriter(s) used by jtreg for agent logging
 aren't using autoFlush
In-Reply-To: <85KtA4ckuTaxc6qMYaWPp4QRcFYyZGTUTKGMrLTzEgc=.991c06bf-2e35-4872-bebf-f26f759091ca@github.com>
References: <85KtA4ckuTaxc6qMYaWPp4QRcFYyZGTUTKGMrLTzEgc=.991c06bf-2e35-4872-bebf-f26f759091ca@github.com>
Message-ID: <GOlksPHsg6Fw1g0g_sylf_3IhELkPW6ldJEvl_T3Ld4=.4dc814ce-1239-4f02-8a79-f943ae696f55@github.com>

On Tue, 6 Jan 2026 05:27:48 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7904126? 
> 
> With this change the logs written out to agent.trace and agentServer.<id>.trace should now have these log message more promptly written out and thus help debug and unexpected test failures. Furthermore, the explicit flush() that was done in https://bugs.openjdk.org/browse/CODETOOLS-7903470 has now been replaced with the use of this autoFlush=true to avoid having to explicitly flush() at any call sites where the logger is used to write out the logs.
> 
> Given the nature of the change no new self tests have been introduced.

Looks reasonable.

-------------

Marked as reviewed by cstein (Reviewer).

PR Review: https://git.openjdk.org/jtreg/pull/305#pullrequestreview-3634368684

From jpai at openjdk.org  Wed Jan  7 11:31:58 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Wed, 7 Jan 2026 11:31:58 GMT
Subject: RFR: 7904126: PrintWriter(s) used by jtreg for agent logging
 aren't using autoFlush
In-Reply-To: <85KtA4ckuTaxc6qMYaWPp4QRcFYyZGTUTKGMrLTzEgc=.991c06bf-2e35-4872-bebf-f26f759091ca@github.com>
References: <85KtA4ckuTaxc6qMYaWPp4QRcFYyZGTUTKGMrLTzEgc=.991c06bf-2e35-4872-bebf-f26f759091ca@github.com>
Message-ID: <UzuSdMS3QMvxeBNpvhW6sTjweity0iLC7GcyQfDVK2o=.e21e7f68-8b2b-492f-b135-6df4f6711142@github.com>

On Tue, 6 Jan 2026 05:27:48 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7904126? 
> 
> With this change the logs written out to agent.trace and agentServer.<id>.trace should now have these log message more promptly written out and thus help debug and unexpected test failures. Furthermore, the explicit flush() that was done in https://bugs.openjdk.org/browse/CODETOOLS-7903470 has now been replaced with the use of this autoFlush=true to avoid having to explicitly flush() at any call sites where the logger is used to write out the logs.
> 
> Given the nature of the change no new self tests have been introduced.

Thank you for the review, Christian.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/305#issuecomment-3718427269

From jpai at openjdk.org  Wed Jan  7 11:31:59 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Wed, 7 Jan 2026 11:31:59 GMT
Subject: Integrated: 7904126: PrintWriter(s) used by jtreg for agent logging
 aren't using autoFlush
In-Reply-To: <85KtA4ckuTaxc6qMYaWPp4QRcFYyZGTUTKGMrLTzEgc=.991c06bf-2e35-4872-bebf-f26f759091ca@github.com>
References: <85KtA4ckuTaxc6qMYaWPp4QRcFYyZGTUTKGMrLTzEgc=.991c06bf-2e35-4872-bebf-f26f759091ca@github.com>
Message-ID: <fOvqZVnaV0p4Mcl6F-oaBRIOy384NKs_p96OMoMjIEM=.5603ddb9-ce90-4be1-a4fd-94699046c061@github.com>

On Tue, 6 Jan 2026 05:27:48 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7904126? 
> 
> With this change the logs written out to agent.trace and agentServer.<id>.trace should now have these log message more promptly written out and thus help debug and unexpected test failures. Furthermore, the explicit flush() that was done in https://bugs.openjdk.org/browse/CODETOOLS-7903470 has now been replaced with the use of this autoFlush=true to avoid having to explicitly flush() at any call sites where the logger is used to write out the logs.
> 
> Given the nature of the change no new self tests have been introduced.

This pull request has now been integrated.

Changeset: 328147bd
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/328147bd1f6e188102a5c3ba9541dc1cd383220f
Stats:     6 lines in 2 files changed: 0 ins; 1 del; 5 mod

7904126: PrintWriter(s) used by jtreg for agent logging aren't using autoFlush

Reviewed-by: cstein

-------------

PR: https://git.openjdk.org/jtreg/pull/305

From cstein at openjdk.org  Wed Jan  7 16:30:01 2026
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 7 Jan 2026 16:30:01 GMT
Subject: RFR: 7904129: Update jtreg to bundle JUnit 5.14.2
Message-ID: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>

Please review this change updating the JUnit version to [5.14.2](https://docs.junit.org/5.14.2/release-notes.html).

-------------

Commit messages:
 - 7904129: Update jtreg to bundle JUnit 5.14.2

Changes: https://git.openjdk.org/jtreg/pull/306/files
  Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=306&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904129
  Stats: 5 lines in 2 files changed: 1 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jtreg/pull/306.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/306/head:pull/306

PR: https://git.openjdk.org/jtreg/pull/306

From jpai at openjdk.org  Thu Jan  8 01:12:10 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Thu, 8 Jan 2026 01:12:10 GMT
Subject: RFR: 7904129: Update jtreg to bundle JUnit 5.14.2
In-Reply-To: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>
References: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>
Message-ID: <rUdP-yacWSXVj3BIsv8zT4H5jUV0ZsqxMNnSTtUEFlA=.360b4a43-ae0e-441f-b213-19068e11d207@github.com>

On Wed, 7 Jan 2026 15:54:41 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change updating the JUnit version to [5.14.2](https://docs.junit.org/5.14.2/release-notes.html).

This looks OK to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jtreg/pull/306#pullrequestreview-3637341800

From cstein at openjdk.org  Thu Jan  8 15:25:59 2026
From: cstein at openjdk.org (Christian Stein)
Date: Thu, 8 Jan 2026 15:25:59 GMT
Subject: RFR: 7904129: Update jtreg to bundle JUnit 5.14.2
In-Reply-To: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>
References: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>
Message-ID: <DBRrTLkDgAahr0t42-Hhfd-UFqCviACARmptKSoZ0Qk=.52fc562e-5083-4869-9933-2d229cbe207f@github.com>

On Wed, 7 Jan 2026 15:54:41 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change updating the JUnit version to [5.14.2](https://docs.junit.org/5.14.2/release-notes.html).

make/build-support/version-numbers line 45:

> 43: # JUnit 5 = JUnit Platform 1.y.z + JUnit Jupiter 5.y.z + JUnit Vintage 5.y.z
> 44: DEFAULT_JUNIT_VERSION=1.14.2
> 45: DEFAULT_JUNIT_JAR_CHECKSUM=99b3e0fe1df38e5eea763c168c033c030a4bd46c

Checksum copied from https://repo1.maven.org/maven2/org/junit/platform/junit-platform-console-standalone/1.14.2/junit-platform-console-standalone-1.14.2.jar.sha1

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/306#discussion_r2672784957

From iris at openjdk.org  Thu Jan  8 18:15:53 2026
From: iris at openjdk.org (Iris Clark)
Date: Thu, 8 Jan 2026 18:15:53 GMT
Subject: RFR: 7904129: Update jtreg to bundle JUnit 5.14.2
In-Reply-To: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>
References: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>
Message-ID: <e4fmd4a2RmhmySmS_O2Dw1iO0Xu3qzeeCn6nIMjKtyM=.fd3a23e8-de3f-4d76-ac61-147eb097e5ec@github.com>

On Wed, 7 Jan 2026 15:54:41 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change updating the JUnit version to [5.14.2](https://docs.junit.org/5.14.2/release-notes.html).

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/jtreg/pull/306#pullrequestreview-3640632023

From cstein at openjdk.org  Fri Jan  9 09:33:05 2026
From: cstein at openjdk.org (Christian Stein)
Date: Fri, 9 Jan 2026 09:33:05 GMT
Subject: Integrated: 7904129: Update jtreg to bundle JUnit 5.14.2
In-Reply-To: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>
References: <WK6fUD3ur4McJC5nDHQ7EIuwwjYMwQk9lsclZ_q4SyY=.9a115778-c21c-4959-b5ff-ea5e1f12895f@github.com>
Message-ID: <SBIhhyPdKaXzJMlR1vOMNXbAOTt89c7In17jKnhWst8=.491b3f84-9c35-4c1d-8104-943714f87081@github.com>

On Wed, 7 Jan 2026 15:54:41 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change updating the JUnit version to [5.14.2](https://docs.junit.org/5.14.2/release-notes.html).

This pull request has now been integrated.

Changeset: 7420a770
Author:    Christian Stein <cstein at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/7420a770b304239bcf04d19c5447e029c36811ac
Stats:     5 lines in 2 files changed: 1 ins; 0 del; 4 mod

7904129: Update jtreg to bundle JUnit 5.14.2

Reviewed-by: jpai, iris

-------------

PR: https://git.openjdk.org/jtreg/pull/306

From cstein at openjdk.org  Fri Jan  9 09:40:42 2026
From: cstein at openjdk.org (Christian Stein)
Date: Fri, 9 Jan 2026 09:40:42 GMT
Subject: RFR: 7904130: Update jtreg to bundle AsmTools 9.1
Message-ID: <zm-jN_WJit8XMQ0swcK-wemhTI1BF6pisR-hz-yLB94=.e0a995fa-7c32-46dc-917a-92aee1e94809@github.com>

Please review this change for jtreg to bundle AsmTools 9.1

The SHA1 checksum was computed and verified from the Source code `.zip` file attached to https://github.com/openjdk/asmtools/releases/tag/9.1-b01

-------------

Commit messages:
 - 7904130: Update jtreg to bundle AsmTools 9.1

Changes: https://git.openjdk.org/jtreg/pull/307/files
  Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=307&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904130
  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jtreg/pull/307.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/307/head:pull/307

PR: https://git.openjdk.org/jtreg/pull/307

From jpai at openjdk.org  Fri Jan  9 16:55:40 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Fri, 9 Jan 2026 16:55:40 GMT
Subject: RFR: 7904130: Update jtreg to bundle AsmTools 9.1
In-Reply-To: <zm-jN_WJit8XMQ0swcK-wemhTI1BF6pisR-hz-yLB94=.e0a995fa-7c32-46dc-917a-92aee1e94809@github.com>
References: <zm-jN_WJit8XMQ0swcK-wemhTI1BF6pisR-hz-yLB94=.e0a995fa-7c32-46dc-917a-92aee1e94809@github.com>
Message-ID: <HZYJGjpT0wxD-VbcXxrLqsEHkh3DXc2sNR_XQE7WJ_M=.112eba0e-3a71-4576-8cdf-9dac1a3949f1@github.com>

On Fri, 9 Jan 2026 09:33:20 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change for jtreg to bundle AsmTools 9.1
> 
> The SHA1 checksum was computed and verified from the Source code `.zip` file attached to https://github.com/openjdk/asmtools/releases/tag/9.1-b01

Looks good to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jtreg/pull/307#pullrequestreview-3644766786

From iris at openjdk.org  Fri Jan  9 17:23:41 2026
From: iris at openjdk.org (Iris Clark)
Date: Fri, 9 Jan 2026 17:23:41 GMT
Subject: RFR: 7904130: Update jtreg to bundle AsmTools 9.1
In-Reply-To: <zm-jN_WJit8XMQ0swcK-wemhTI1BF6pisR-hz-yLB94=.e0a995fa-7c32-46dc-917a-92aee1e94809@github.com>
References: <zm-jN_WJit8XMQ0swcK-wemhTI1BF6pisR-hz-yLB94=.e0a995fa-7c32-46dc-917a-92aee1e94809@github.com>
Message-ID: <F9HZtARBZy05t1DFgXfpXrKDWvX8yF0IXe2jmtIy7qw=.9538f55e-95aa-4368-ad89-3e33869a1cd5@github.com>

On Fri, 9 Jan 2026 09:33:20 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change for jtreg to bundle AsmTools 9.1
> 
> The SHA1 checksum was computed and verified from the Source code `.zip` file attached to https://github.com/openjdk/asmtools/releases/tag/9.1-b01

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/jtreg/pull/307#pullrequestreview-3644862355

From cstein at openjdk.org  Sun Jan 11 08:44:29 2026
From: cstein at openjdk.org (Christian Stein)
Date: Sun, 11 Jan 2026 08:44:29 GMT
Subject: Integrated: 7904130: Update jtreg to bundle AsmTools 9.1
In-Reply-To: <zm-jN_WJit8XMQ0swcK-wemhTI1BF6pisR-hz-yLB94=.e0a995fa-7c32-46dc-917a-92aee1e94809@github.com>
References: <zm-jN_WJit8XMQ0swcK-wemhTI1BF6pisR-hz-yLB94=.e0a995fa-7c32-46dc-917a-92aee1e94809@github.com>
Message-ID: <0nA7JYCEf6u6CILdOpo4vpvdRA0-1Ueb7Kavx9Oupr8=.689d2089-376d-4a9a-b640-d84098464162@github.com>

On Fri, 9 Jan 2026 09:33:20 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change for jtreg to bundle AsmTools 9.1
> 
> The SHA1 checksum was computed and verified from the Source code `.zip` file attached to https://github.com/openjdk/asmtools/releases/tag/9.1-b01

This pull request has now been integrated.

Changeset: 137539ea
Author:    Christian Stein <cstein at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/137539ea585670557d5590b0fd7a0cf795cbc67a
Stats:     4 lines in 2 files changed: 0 ins; 0 del; 4 mod

7904130: Update jtreg to bundle AsmTools 9.1

Reviewed-by: jpai, iris

-------------

PR: https://git.openjdk.org/jtreg/pull/307

From jpai at openjdk.org  Fri Jan 16 11:40:28 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Fri, 16 Jan 2026 11:40:28 GMT
Subject: RFR: 7904133: jtreg doesn't generate an error when @key tag is used
 more than once in a test definition
Message-ID: <ehuv-PbCuKXsXfFWJM_87RND2O7mJRTMms67eRu5syg=.c85214db-39f4-4abf-b927-2dee21499586@github.com>

Can I please get a review of this change which proposes to enforce the rule that `@key` in a test definition is expected to be used only once, as noted in the tag spec here https://openjdk.org/jtreg/tag-spec.html:

> The @key tag may be used at most once in a given test.

I decided to make it an error because the tag spec already notes that this isn't expected to be used more than once. So this should fail a test and generate attention instead of its current behaviour of silently using the second `@key`. Generating a warning, I think, doesn't help this case.

A new self test has been added to reproduce the issue and verify the fix.

-------------

Commit messages:
 - 7904133: jtreg doesn't generate an error when @key tag is used more than once in a test definition

Changes: https://git.openjdk.org/jtreg/pull/308/files
  Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=308&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904133
  Stats: 51 lines in 4 files changed: 43 ins; 2 del; 6 mod
  Patch: https://git.openjdk.org/jtreg/pull/308.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/308/head:pull/308

PR: https://git.openjdk.org/jtreg/pull/308

From cstein at openjdk.org  Fri Jan 16 11:40:28 2026
From: cstein at openjdk.org (Christian Stein)
Date: Fri, 16 Jan 2026 11:40:28 GMT
Subject: RFR: 7904133: jtreg doesn't generate an error when @key tag is
 used more than once in a test definition
In-Reply-To: <ehuv-PbCuKXsXfFWJM_87RND2O7mJRTMms67eRu5syg=.c85214db-39f4-4abf-b927-2dee21499586@github.com>
References: <ehuv-PbCuKXsXfFWJM_87RND2O7mJRTMms67eRu5syg=.c85214db-39f4-4abf-b927-2dee21499586@github.com>
Message-ID: <Cux2E-M9Zx01Q2WobBb4RsYj-dRFCCbjubxWppV3CvM=.0470a266-72d3-4c58-99ef-c8249809fadc@github.com>

On Fri, 16 Jan 2026 11:30:02 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to enforce the rule that `@key` in a test definition is expected to be used only once, as noted in the tag spec here https://openjdk.org/jtreg/tag-spec.html:
> 
>> The @key tag may be used at most once in a given test.
> 
> I decided to make it an error because the tag spec already notes that this isn't expected to be used more than once. So this should fail a test and generate attention instead of its current behaviour of silently using the second `@key`. Generating a warning, I think, doesn't help this case.
> 
> A new self test has been added to reproduce the issue and verify the fix.

Thanks for addressing this bug, Jaikiran.

Did you run this change against a larger set (the JDK tests) to see whether multiple key tags are present and need manual fixing?

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/308#issuecomment-3759645786

From jpai at openjdk.org  Fri Jan 16 11:45:20 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Fri, 16 Jan 2026 11:45:20 GMT
Subject: RFR: 7904133: jtreg doesn't generate an error when @key tag is
 used more than once in a test definition
In-Reply-To: <ehuv-PbCuKXsXfFWJM_87RND2O7mJRTMms67eRu5syg=.c85214db-39f4-4abf-b927-2dee21499586@github.com>
References: <ehuv-PbCuKXsXfFWJM_87RND2O7mJRTMms67eRu5syg=.c85214db-39f4-4abf-b927-2dee21499586@github.com>
Message-ID: <63dj3tNXKkcBSLtsX5GZ-pt-C_rTnh_CwXc5zBsAI0c=.d04e9cf1-ca75-4be8-a0f1-2a5463eda93e@github.com>

On Fri, 16 Jan 2026 11:30:02 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to enforce the rule that `@key` in a test definition is expected to be used only once, as noted in the tag spec here https://openjdk.org/jtreg/tag-spec.html:
> 
>> The @key tag may be used at most once in a given test.
> 
> I decided to make it an error because the tag spec already notes that this isn't expected to be used more than once. So this should fail a test and generate attention instead of its current behaviour of silently using the second `@key`. Generating a warning, I think, doesn't help this case.
> 
> A new self test has been added to reproduce the issue and verify the fix.

Hello Christian,

> Did you run this change against a larger set (the JDK tests) to see whether multiple key tags are present and need manual fixing?

I will be running a CI run for the JDK after building this jtreg version. I expect some existing tests to be caught with more than one `@key` and will JBS issue(s) as appropriate.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/308#issuecomment-3759663008

From cstein at openjdk.org  Fri Jan 16 12:02:19 2026
From: cstein at openjdk.org (Christian Stein)
Date: Fri, 16 Jan 2026 12:02:19 GMT
Subject: RFR: 7904133: jtreg doesn't generate an error when @key tag is
 used more than once in a test definition
In-Reply-To: <ehuv-PbCuKXsXfFWJM_87RND2O7mJRTMms67eRu5syg=.c85214db-39f4-4abf-b927-2dee21499586@github.com>
References: <ehuv-PbCuKXsXfFWJM_87RND2O7mJRTMms67eRu5syg=.c85214db-39f4-4abf-b927-2dee21499586@github.com>
Message-ID: <c54pnrNJBfyXTykmyVYG_be_hV4vmGOvwzQOPPspdzY=.a60b821a-f503-47c4-9134-b48c3e73e488@github.com>

On Fri, 16 Jan 2026 11:30:02 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to enforce the rule that `@key` in a test definition is expected to be used only once, as noted in the tag spec here https://openjdk.org/jtreg/tag-spec.html:
> 
>> The @key tag may be used at most once in a given test.
> 
> I decided to make it an error because the tag spec already notes that this isn't expected to be used more than once. So this should fail a test and generate attention instead of its current behaviour of silently using the second `@key`. Generating a warning, I think, doesn't help this case.
> 
> A new self test has been added to reproduce the issue and verify the fix.

Marked as reviewed by cstein (Reviewer).

-------------

PR Review: https://git.openjdk.org/jtreg/pull/308#pullrequestreview-3670552021

From jpai at openjdk.org  Sun Jan 18 16:30:41 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Sun, 18 Jan 2026 16:30:41 GMT
Subject: RFR: 7904134: Defaulting to class file version of 52.0 when compiling
 jasm leads to several test failures in the JDK
Message-ID: <HHLQxVOpxVT8jAmVwviMkYYnfG-oEYFu8GyGIiZTe8c=.0ab11eb4-dc5b-413e-a5a5-a7d3c2c2460f@github.com>

Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7904134?

The change here uses the default class file version of 45.3 instead of 52.0. This should prevent the failures we saw in the JDK repo with the current jtreg mainline code. At the same time, this should continue to address https://bugs.openjdk.org/browse/CODETOOLS-7904122 by preventing the warning logged by jasm compilation in the absence of any explicit default class file version.

With this change I've verified locally that some of the failing tests in the JDK now pass. I've also triggered a tier testing of the JDK with this change.

-------------

Commit messages:
 - copyright year
 - 7904134: Defaulting to class file version of 52.0 when compiling jasm leads to several test failures in the JDK

Changes: https://git.openjdk.org/jtreg/pull/309/files
  Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=309&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904134
  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jtreg/pull/309.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/309/head:pull/309

PR: https://git.openjdk.org/jtreg/pull/309

From cstein at openjdk.org  Sun Jan 18 16:55:36 2026
From: cstein at openjdk.org (Christian Stein)
Date: Sun, 18 Jan 2026 16:55:36 GMT
Subject: RFR: 7904134: Defaulting to class file version of 52.0 when
 compiling jasm leads to several test failures in the JDK
In-Reply-To: <HHLQxVOpxVT8jAmVwviMkYYnfG-oEYFu8GyGIiZTe8c=.0ab11eb4-dc5b-413e-a5a5-a7d3c2c2460f@github.com>
References: <HHLQxVOpxVT8jAmVwviMkYYnfG-oEYFu8GyGIiZTe8c=.0ab11eb4-dc5b-413e-a5a5-a7d3c2c2460f@github.com>
Message-ID: <PnkJwzg1dXCUt8DIVM9tl9FhJSOtBeDiI1nsKf7Xiho=.b21b8716-6f54-4a6a-a529-0f3b3dca000e@github.com>

On Sun, 18 Jan 2026 16:25:23 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7904134?
> 
> The change here uses the default class file version of 45.3 instead of 52.0. This should prevent the failures we saw in the JDK repo with the current jtreg mainline code. At the same time, this should continue to address https://bugs.openjdk.org/browse/CODETOOLS-7904122 by preventing the warning logged by jasm compilation in the absence of any explicit default class file version.
> 
> With this change I've verified locally that some of the failing tests in the JDK now pass. I've also triggered a tier testing of the JDK with this change.

Sounds reasonable.

-------------

Marked as reviewed by cstein (Reviewer).

PR Review: https://git.openjdk.org/jtreg/pull/309#pullrequestreview-3675588396

From jpai at openjdk.org  Sun Jan 18 17:43:38 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Sun, 18 Jan 2026 17:43:38 GMT
Subject: RFR: 7904134: Defaulting to class file version of 52.0 when
 compiling jasm leads to several test failures in the JDK
In-Reply-To: <HHLQxVOpxVT8jAmVwviMkYYnfG-oEYFu8GyGIiZTe8c=.0ab11eb4-dc5b-413e-a5a5-a7d3c2c2460f@github.com>
References: <HHLQxVOpxVT8jAmVwviMkYYnfG-oEYFu8GyGIiZTe8c=.0ab11eb4-dc5b-413e-a5a5-a7d3c2c2460f@github.com>
Message-ID: <PK7MbUJxUWFDSLqS51VY-bB-IBscq1j3fUc-vHBzwRI=.07dbbc30-f59c-4fe2-b346-8c9b60755865@github.com>

On Sun, 18 Jan 2026 16:25:23 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7904134?
> 
> The change here uses the default class file version of 45.3 instead of 52.0. This should prevent the failures we saw in the JDK repo with the current jtreg mainline code. At the same time, this should continue to address https://bugs.openjdk.org/browse/CODETOOLS-7904122 by preventing the warning logged by jasm compilation in the absence of any explicit default class file version.
> 
> With this change I've verified locally that some of the failing tests in the JDK now pass. I've also triggered a tier testing of the JDK with this change.

Thank you Christian for the review. tier testing of the JDK with this change went fine without any related issues.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/309#issuecomment-3765532122

From jpai at openjdk.org  Sun Jan 18 17:43:38 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Sun, 18 Jan 2026 17:43:38 GMT
Subject: Integrated: 7904134: Defaulting to class file version of 52.0 when
 compiling jasm leads to several test failures in the JDK
In-Reply-To: <HHLQxVOpxVT8jAmVwviMkYYnfG-oEYFu8GyGIiZTe8c=.0ab11eb4-dc5b-413e-a5a5-a7d3c2c2460f@github.com>
References: <HHLQxVOpxVT8jAmVwviMkYYnfG-oEYFu8GyGIiZTe8c=.0ab11eb4-dc5b-413e-a5a5-a7d3c2c2460f@github.com>
Message-ID: <6sYrzyqRVJXnjxww76b4wdO7DDaSTTePLZXhgZcNkmU=.104e3de0-1a86-4d33-87ed-520d5f95964c@github.com>

On Sun, 18 Jan 2026 16:25:23 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7904134?
> 
> The change here uses the default class file version of 45.3 instead of 52.0. This should prevent the failures we saw in the JDK repo with the current jtreg mainline code. At the same time, this should continue to address https://bugs.openjdk.org/browse/CODETOOLS-7904122 by preventing the warning logged by jasm compilation in the absence of any explicit default class file version.
> 
> With this change I've verified locally that some of the failing tests in the JDK now pass. I've also triggered a tier testing of the JDK with this change.

This pull request has now been integrated.

Changeset: a3b1279c
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/a3b1279cfbe954537e99b45f9c9647b99b9b7f85
Stats:     3 lines in 1 file changed: 0 ins; 0 del; 3 mod

7904134: Defaulting to class file version of 52.0 when compiling jasm leads to several test failures in the JDK

Reviewed-by: cstein

-------------

PR: https://git.openjdk.org/jtreg/pull/309

From cstein at openjdk.org  Tue Jan 20 09:23:11 2026
From: cstein at openjdk.org (Christian Stein)
Date: Tue, 20 Jan 2026 09:23:11 GMT
Subject: RFR: 7904105: intermittent test failure in
 CleanupDirTests.agentvm.conc
In-Reply-To: <PpWO5O6ZIWbFh9WWNNUxY-rjXucaQaHTPPKKf50l5xk=.91e11bfd-fef1-4233-b4b7-84033883fd23@github.com>
References: <WGEdviTCuQCt8O-OUUOVew_mEFVLKn09nQc76y6yEY8=.618db97c-c19f-4181-afdc-33773a508144@github.com>
 <__CbDxfnNzwKsBo_guhAt2RDiTdY42Hc2D-EbKuF5CI=.b4400934-6b56-4829-9bcd-b3bee89d9831@github.com>
 <PpWO5O6ZIWbFh9WWNNUxY-rjXucaQaHTPPKKf50l5xk=.91e11bfd-fef1-4233-b4b7-84033883fd23@github.com>
Message-ID: <VwUgsTnDo6mVsfhO92nrFbJsrJl-E5r-UE59uGgUqk8=.8f336171-5a2c-43c8-8c52-943efd7b6530@github.com>

On Tue, 28 Oct 2025 19:46:50 GMT, Vladimir Petko <vpetko at openjdk.org> wrote:

>> Hello Vladimir, we have seen intermittent failure in this test too, but i haven't had a chance to look deeper.
>> 
>> `TestStats` deals with counts in several different methods, so I'm not completely sure the proposed change is enough or the best way to address this. It may be that the code in `TestStats` itself might need to be addressed in some manner.
>
>> Hello Vladimir, we have seen intermittent failure in this test too, but i haven't had a chance to look deeper.
>> 
>> `TestStats` deals with counts in several different methods, so I'm not completely sure the proposed change is enough or the best way to address this. It may be that the code in `TestStats` itself might need to be addressed in some manner.
> 
> Hi, 
> 
> I have tried using atomics in TestStats and the implementation looked ugly / required a lot of refactoring. 
> 
> jtreg only updates counts using jtharness Observer callbacks. We already use `synchonzied` keyword in Observer callbacks[1] as the TestRunner spawns multiple threads if we specify concurrency > 1. I have used Intellij Idea to find all inheritors of BasicObserver and added synchronization. 
> 
> Maybe the better way would be to synchronize in jtharness itself to avoid  doing it in the client code? 
> Hmm, this is probably impossible unless we want to make a breaking change and remove `notifier` field from `Script` class. 
> 
> [1] https://github.com/openjdk/jtreg/blob/34ccc66ec89651637811678a17d3f810b4ac0780/src/share/classes/com/sun/javatest/regtest/report/ElapsedTimeHandler.java#L64

@vpa1977 do you want to issue an `/integrate` comment? I'd like to include this change in the upcoming 8.2 release of jtreg.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/297#issuecomment-3771843070

From cstein at openjdk.org  Tue Jan 20 09:23:45 2026
From: cstein at openjdk.org (Christian Stein)
Date: Tue, 20 Jan 2026 09:23:45 GMT
Subject: RFR: 7904107: AgentOut.othervm.ok should not access
 $(BUILDTESTDIR)/AgentOut.agentvm
In-Reply-To: <cBCzo8OLvIMbrVdSIdLY5zod7PnZY8fnqSzfO14mcJE=.2628f12d-7d4d-4ba1-8b61-f064e3a29cb8@github.com>
References: <cBCzo8OLvIMbrVdSIdLY5zod7PnZY8fnqSzfO14mcJE=.2628f12d-7d4d-4ba1-8b61-f064e3a29cb8@github.com>
Message-ID: <379GmaSV3s2yxvNAzR6mG1xFmx_KtamRzkXflUJxpY4=.0d6ef2b2-6a9d-41d5-bf4b-b662ad24c649@github.com>

On Tue, 28 Oct 2025 03:23:42 GMT, Vladimir Petko <vpetko at openjdk.org> wrote:

> AgentOut.othervm.ok tries to access $(BUILDTESTDIR)/AgentOut.agentvm. This should only happen in AgentOut.agentvm.ok. 
> Add a new target to filter log lines that depends on AgentOut.agentvm.ok.
> 
> Note: tests pass on retry[1]. The test failure is caused by [2]
> 
> [1] https://github.com/vpa1977/jtreg/actions/runs/18863066182
> [2] https://github.com/openjdk/jtreg/pull/297

@vpa1977 do you want to issue an `/integrate` comment? I'd like to include this change in the upcoming 8.2 release of jtreg.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/299#issuecomment-3771845512

From jpai at openjdk.org  Tue Jan 20 09:27:29 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 20 Jan 2026 09:27:29 GMT
Subject: Integrated: 7904133: jtreg doesn't generate an error when @key tag is
 used more than once in a test definition
In-Reply-To: <ehuv-PbCuKXsXfFWJM_87RND2O7mJRTMms67eRu5syg=.c85214db-39f4-4abf-b927-2dee21499586@github.com>
References: <ehuv-PbCuKXsXfFWJM_87RND2O7mJRTMms67eRu5syg=.c85214db-39f4-4abf-b927-2dee21499586@github.com>
Message-ID: <0UZMp2fliDw9foY3y4TtXSxhmn7VTbXkUdrJb3qCVvQ=.c9482cae-343a-4926-a2cc-0d065a637e88@github.com>

On Fri, 16 Jan 2026 11:30:02 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to enforce the rule that `@key` in a test definition is expected to be used only once, as noted in the tag spec here https://openjdk.org/jtreg/tag-spec.html:
> 
>> The @key tag may be used at most once in a given test.
> 
> I decided to make it an error because the tag spec already notes that this isn't expected to be used more than once. So this should fail a test and generate attention instead of its current behaviour of silently using the second `@key`. Generating a warning, I think, doesn't help this case.
> 
> A new self test has been added to reproduce the issue and verify the fix.

This pull request has now been integrated.

Changeset: 05833b34
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/05833b3498cfc0d1a53b247608b3d4eadbcae2d7
Stats:     51 lines in 4 files changed: 43 ins; 2 del; 6 mod

7904133: jtreg doesn't generate an error when @key tag is used more than once in a test definition

Reviewed-by: cstein

-------------

PR: https://git.openjdk.org/jtreg/pull/308

From jpai at openjdk.org  Tue Jan 20 09:27:28 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 20 Jan 2026 09:27:28 GMT
Subject: RFR: 7904133: jtreg doesn't generate an error when @key tag is
 used more than once in a test definition
In-Reply-To: <ehuv-PbCuKXsXfFWJM_87RND2O7mJRTMms67eRu5syg=.c85214db-39f4-4abf-b927-2dee21499586@github.com>
References: <ehuv-PbCuKXsXfFWJM_87RND2O7mJRTMms67eRu5syg=.c85214db-39f4-4abf-b927-2dee21499586@github.com>
Message-ID: <dboB8ZpvFJ0UNyWDEqa6Qo4a-W3irHAzrNsSwGv0cBs=.c6dfa450-84c6-42cc-bcac-40f28563c33a@github.com>

On Fri, 16 Jan 2026 11:30:02 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to enforce the rule that `@key` in a test definition is expected to be used only once, as noted in the tag spec here https://openjdk.org/jtreg/tag-spec.html:
> 
>> The @key tag may be used at most once in a given test.
> 
> I decided to make it an error because the tag spec already notes that this isn't expected to be used more than once. So this should fail a test and generate attention instead of its current behaviour of silently using the second `@key`. Generating a warning, I think, doesn't help this case.
> 
> A new self test has been added to reproduce the issue and verify the fix.

Thank you Christian for the review. The JDK specific test issues are being addressed and this change on its own went fine in the testing. I will go ahead and integrate this now.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/308#issuecomment-3771862074

From duke at openjdk.org  Tue Jan 20 19:23:46 2026
From: duke at openjdk.org (duke)
Date: Tue, 20 Jan 2026 19:23:46 GMT
Subject: RFR: 7904105: intermittent test failure in
 CleanupDirTests.agentvm.conc
In-Reply-To: <WGEdviTCuQCt8O-OUUOVew_mEFVLKn09nQc76y6yEY8=.618db97c-c19f-4181-afdc-33773a508144@github.com>
References: <WGEdviTCuQCt8O-OUUOVew_mEFVLKn09nQc76y6yEY8=.618db97c-c19f-4181-afdc-33773a508144@github.com>
Message-ID: <g-5CEbECu7kWtNOZ0qDgaO8s0cPr7xl5QwtANoXwp2U=.ccb79101-1e54-4616-b6ff-da1f76a9d7df@github.com>

On Tue, 28 Oct 2025 03:12:34 GMT, Vladimir Petko <vpetko at openjdk.org> wrote:

> jtharness does not synchronize calls to Observer. Synchronized keyword needs to be added when processing shared state.

@vpa1977 
Your change (at version e346596f80a35d10d982c336015d1ab33e3ce62e) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/297#issuecomment-3774548042

From duke at openjdk.org  Tue Jan 20 19:23:48 2026
From: duke at openjdk.org (duke)
Date: Tue, 20 Jan 2026 19:23:48 GMT
Subject: RFR: 7904107: AgentOut.othervm.ok should not access
 $(BUILDTESTDIR)/AgentOut.agentvm
In-Reply-To: <cBCzo8OLvIMbrVdSIdLY5zod7PnZY8fnqSzfO14mcJE=.2628f12d-7d4d-4ba1-8b61-f064e3a29cb8@github.com>
References: <cBCzo8OLvIMbrVdSIdLY5zod7PnZY8fnqSzfO14mcJE=.2628f12d-7d4d-4ba1-8b61-f064e3a29cb8@github.com>
Message-ID: <0-2Pq6diY4gPek3Fjlk1jOyVruPuNyjSrnVBmlMUkK0=.8fa987ec-efb2-4f6a-a4f9-6e1ce724360c@github.com>

On Tue, 28 Oct 2025 03:23:42 GMT, Vladimir Petko <vpetko at openjdk.org> wrote:

> AgentOut.othervm.ok tries to access $(BUILDTESTDIR)/AgentOut.agentvm. This should only happen in AgentOut.agentvm.ok. 
> Add a new target to filter log lines that depends on AgentOut.agentvm.ok.
> 
> Note: tests pass on retry[1]. The test failure is caused by [2]
> 
> [1] https://github.com/vpa1977/jtreg/actions/runs/18863066182
> [2] https://github.com/openjdk/jtreg/pull/297

@vpa1977 
Your change (at version 5427b341b1024b81fb1272a67be49aa9d3fb42fa) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/299#issuecomment-3774547369

From vpetko at openjdk.org  Wed Jan 21 15:10:34 2026
From: vpetko at openjdk.org (Vladimir Petko)
Date: Wed, 21 Jan 2026 15:10:34 GMT
Subject: Integrated: 7904107: AgentOut.othervm.ok should not access
 $(BUILDTESTDIR)/AgentOut.agentvm
In-Reply-To: <cBCzo8OLvIMbrVdSIdLY5zod7PnZY8fnqSzfO14mcJE=.2628f12d-7d4d-4ba1-8b61-f064e3a29cb8@github.com>
References: <cBCzo8OLvIMbrVdSIdLY5zod7PnZY8fnqSzfO14mcJE=.2628f12d-7d4d-4ba1-8b61-f064e3a29cb8@github.com>
Message-ID: <wiQg4-vS7pI8jhbqT4OUPSzrgMmuyGV7PoCVlC2pUAQ=.2e85b376-dbf5-421e-8792-faa51543f8aa@github.com>

On Tue, 28 Oct 2025 03:23:42 GMT, Vladimir Petko <vpetko at openjdk.org> wrote:

> AgentOut.othervm.ok tries to access $(BUILDTESTDIR)/AgentOut.agentvm. This should only happen in AgentOut.agentvm.ok. 
> Add a new target to filter log lines that depends on AgentOut.agentvm.ok.
> 
> Note: tests pass on retry[1]. The test failure is caused by [2]
> 
> [1] https://github.com/vpa1977/jtreg/actions/runs/18863066182
> [2] https://github.com/openjdk/jtreg/pull/297

This pull request has now been integrated.

Changeset: ce032339
Author:    Vladimir Petko <vpetko at openjdk.org>
Committer: Christian Stein <cstein at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/ce03233954a524da0836c3491e2fbe791797d82a
Stats:     8 lines in 1 file changed: 4 ins; 2 del; 2 mod

7904107: AgentOut.othervm.ok should not access   $(BUILDTESTDIR)/AgentOut.agentvm

Reviewed-by: cstein

-------------

PR: https://git.openjdk.org/jtreg/pull/299

From vpetko at openjdk.org  Wed Jan 21 15:13:38 2026
From: vpetko at openjdk.org (Vladimir Petko)
Date: Wed, 21 Jan 2026 15:13:38 GMT
Subject: Integrated: 7904105: intermittent test failure in
 CleanupDirTests.agentvm.conc
In-Reply-To: <WGEdviTCuQCt8O-OUUOVew_mEFVLKn09nQc76y6yEY8=.618db97c-c19f-4181-afdc-33773a508144@github.com>
References: <WGEdviTCuQCt8O-OUUOVew_mEFVLKn09nQc76y6yEY8=.618db97c-c19f-4181-afdc-33773a508144@github.com>
Message-ID: <Lr_YfU58Jn9iWX_atOw1KiN0Cu070QmRj66dqwjSKqM=.35f1d50a-7759-4190-ad25-205708365295@github.com>

On Tue, 28 Oct 2025 03:12:34 GMT, Vladimir Petko <vpetko at openjdk.org> wrote:

> jtharness does not synchronize calls to Observer. Synchronized keyword needs to be added when processing shared state.

This pull request has now been integrated.

Changeset: 98a1016f
Author:    Vladimir Petko <vpetko at openjdk.org>
Committer: Christian Stein <cstein at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/98a1016f8bb6ee23eed1d33d72b240ec848617de
Stats:     3 lines in 3 files changed: 0 ins; 0 del; 3 mod

7904105: intermittent test failure in CleanupDirTests.agentvm.conc

Reviewed-by: cstein

-------------

PR: https://git.openjdk.org/jtreg/pull/297

From cstein at openjdk.org  Mon Jan 26 15:50:51 2026
From: cstein at openjdk.org (Christian Stein)
Date: Mon, 26 Jan 2026 15:50:51 GMT
Subject: RFR: 7904135: Release jtreg 8.2
Message-ID: <QVA-jtvGnHNHZch8PU6T2wyGdejSNkITWsjO_B--AQs=.faa2d4c3-c958-4271-b89a-ec9f8b0a14a9@github.com>

Please review this change to update the `CHANGELOG.md` file to include a section about jtreg 8.2

This change also increases the working number to 8.3

-------------

Commit messages:
 - 7904135: Release jtreg 8.2

Changes: https://git.openjdk.org/jtreg/pull/310/files
  Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=310&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904135
  Stats: 12 lines in 2 files changed: 10 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jtreg/pull/310.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/310/head:pull/310

PR: https://git.openjdk.org/jtreg/pull/310

From jpai at openjdk.org  Mon Jan 26 16:01:33 2026
From: jpai at openjdk.org (Jaikiran Pai)
Date: Mon, 26 Jan 2026 16:01:33 GMT
Subject: RFR: 7904135: Release jtreg 8.2
In-Reply-To: <QVA-jtvGnHNHZch8PU6T2wyGdejSNkITWsjO_B--AQs=.faa2d4c3-c958-4271-b89a-ec9f8b0a14a9@github.com>
References: <QVA-jtvGnHNHZch8PU6T2wyGdejSNkITWsjO_B--AQs=.faa2d4c3-c958-4271-b89a-ec9f8b0a14a9@github.com>
Message-ID: <jgqvqM9RZbxY5ee_SwpS99mHaRwRxUGO-ea5uMzacBQ=.21f3d036-dbf3-4e57-8bf9-ac38ee1efdf8@github.com>

On Tue, 20 Jan 2026 12:24:07 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change to update the `CHANGELOG.md` file to include a section about jtreg 8.2
> 
> This change also increases the working number to 8.3

Marked as reviewed by jpai (Reviewer).

-------------

PR Review: https://git.openjdk.org/jtreg/pull/310#pullrequestreview-3706739470

From cstein at openjdk.org  Mon Jan 26 16:11:57 2026
From: cstein at openjdk.org (Christian Stein)
Date: Mon, 26 Jan 2026 16:11:57 GMT
Subject: Integrated: 7904135: Release jtreg 8.2
In-Reply-To: <QVA-jtvGnHNHZch8PU6T2wyGdejSNkITWsjO_B--AQs=.faa2d4c3-c958-4271-b89a-ec9f8b0a14a9@github.com>
References: <QVA-jtvGnHNHZch8PU6T2wyGdejSNkITWsjO_B--AQs=.faa2d4c3-c958-4271-b89a-ec9f8b0a14a9@github.com>
Message-ID: <9ZKIStZFyZC26ang0_8JGGM35Yr7_K84S79UIb6B5sg=.7f58dc2b-9ccf-4d19-9ea2-274371406e38@github.com>

On Tue, 20 Jan 2026 12:24:07 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change to update the `CHANGELOG.md` file to include a section about jtreg 8.2
> 
> This change also increases the working number to 8.3

This pull request has now been integrated.

Changeset: da0976e4
Author:    Christian Stein <cstein at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/da0976e4761602196f7cf5dbfe33cbe4cc5e49db
Stats:     12 lines in 2 files changed: 10 ins; 0 del; 2 mod

7904135: Release jtreg 8.2

Reviewed-by: jpai

-------------

PR: https://git.openjdk.org/jtreg/pull/310

From duke at openjdk.org  Wed Jan 28 06:03:14 2026
From: duke at openjdk.org (duke)
Date: Wed, 28 Jan 2026 06:03:14 GMT
Subject: Withdrawn: 7904101: intermittent failure in StreamsTest.agentvm.ok
In-Reply-To: <QbzFya1bkj9PVpOVTW7jITjrSa_aKqR6hdlZYb9nniY=.a9ad023a-0829-4b43-8fc7-dd9f8a867d86@github.com>
References: <QbzFya1bkj9PVpOVTW7jITjrSa_aKqR6hdlZYb9nniY=.a9ad023a-0829-4b43-8fc7-dd9f8a867d86@github.com>
Message-ID: <FM3YmCypYoQOGRS1Obkzv5j5qYwn4nZ1o4HTUo1amY0=.a47d3864-ab9b-4f77-a25a-f5be9bb00666@github.com>

On Tue, 21 Oct 2025 02:01:40 GMT, Vladimir Petko <vpetko at openjdk.org> wrote:

> FileDescriptor test intermittently fails because the agent's process output capture lacks synchronisation. 
> 
> This PR fixes the issue:
> - Agent VM prints the "process output separator" to stderr and stdout before and after action
> - The main vm uses the marker to stop reading the stream for the current test result section (or a general agent log)
> - The main vm restarts reading the log after updating the test section (or clearing it) until the next marker or the process is shut down.
> 
> Alternative:
>  -Disable the test and make no assumptions about contents of the agent vm process output.
> 
> Testing: tier1 and tier2 tests on mainline jdk (Ubuntu Linux) in agentvm mode.
> 
> 
> make test TEST=":tier1 :tier2" JTREG="TEST_MODE=agentvm"
> 
> ....
> 
> ==============================
> Test summary
> ==============================
>    TEST                                              TOTAL  PASS  FAIL ERROR  SKIP   
>    jtreg:test/hotspot/jtreg:tier1                     3124  2837     0     0   287   
>    jtreg:test/jdk:tier1                               2519  2480     0     0    39   
>    jtreg:test/langtools:tier1                         4670  4660     0     0    10   
>    jtreg:test/jaxp:tier1                                 0     0     0     0     0   
>    jtreg:test/lib-test:tier1                            38    38     0     0     0   
>    jtreg:test/hotspot/jtreg:tier2                      960   913     0     0    47   
>>> jtreg:test/jdk:tier2                               4455  4220     1     0   234 <<
>    jtreg:test/langtools:tier2                           14    12     0     0     2   
>    jtreg:test/jaxp:tier2                               517   516     0     0     1   
>    jtreg:test/docs:tier2                                 4     0     0     0     4   
> ==============================
> TEST FAILURE
> 
> 
> Unrelated failure: test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java
> 
> 
> 
> 
> ---------System.out:(98/7409)----------
> Seed from RandomFactory = 7590698091695474155L
> [15:02:42.244] config SendReceiveMaxSize.setUp(): success [0ms]
> [15:02:42.272] test SendReceiveMaxSize.testGetOption(SendReceiveMaxSize$$Lambda/0x00000000450736f8 at 8d234b9, 65507, /10.201.67.1): success [7ms]
> [15:02:42.273] test SendReceiveMaxSize.testGetOption(SendReceiveMaxSize$$Lambda/0x0000000045073920 at 449629ff, 65507, /10.201.67.1): success [0ms]
> [15:02:42.273] test SendReceiveMaxSize.testGetOption(SendReceiveMaxSize$$Lambda/0x0000000045078000 at 2b071f3f, 65527, java.net.Inet6Address at 22212892): success [0ms]
> [15:0...

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jtreg/pull/295

From syan at openjdk.org  Wed Jan 28 07:07:23 2026
From: syan at openjdk.org (SendaoYan)
Date: Wed, 28 Jan 2026 07:07:23 GMT
Subject: RFR: 7904084: Unset javaOpts and jtregOpts in jtreg.sh [v4]
In-Reply-To: <K4U0-tl4b_m7P2GLdBPm8WMXK7Z9n8AwhQH4D59WoHM=.fb58f7e1-402b-47f7-94ad-ead4f0de53d8@github.com>
References: <K4U0-tl4b_m7P2GLdBPm8WMXK7Z9n8AwhQH4D59WoHM=.fb58f7e1-402b-47f7-94ad-ead4f0de53d8@github.com>
Message-ID: <D2lsjwnJP_l8gkRQgjyI-h9cAOEq3bC7LFUm5xKdI74=.59d3a5be-75cc-4621-ad8d-ad6c965eae56@github.com>

> Hi all,
> 
> In jtreg.sh it will combine all the java options and jtreg options in the `for i in "$@"` loop. SHELL use javaOpts and jtregOpts as global varable by default, this means jtreg.sh will receive the value of javaOpts and jtregOpts outside. I think this unexpected.
> To avoid this siutation, I think we should unset javaOpts and jtregOpts before use it.

SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'openjdk:master' into jbs7904084
 - Merge branch 'openjdk:master' into jbs7904084
 - Merge branch 'openjdk:master' into jbs7904084
 - 7904084: Unset javaOpts and jtregOpts in jtreg.sh

-------------

Changes:
  - all: https://git.openjdk.org/jtreg/pull/291/files
  - new: https://git.openjdk.org/jtreg/pull/291/files/fb3a5dd1..a3076f53

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jtreg&pr=291&range=03
 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=291&range=02-03

  Stats: 196 lines in 18 files changed: 162 ins; 5 del; 29 mod
  Patch: https://git.openjdk.org/jtreg/pull/291.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/291/head:pull/291

PR: https://git.openjdk.org/jtreg/pull/291

From syan at openjdk.org  Wed Jan 28 07:42:26 2026
From: syan at openjdk.org (SendaoYan)
Date: Wed, 28 Jan 2026 07:42:26 GMT
Subject: RFR: 7904083: Print fatal error messages to stderr [v4]
In-Reply-To: <Cw_ooHhtnB9aJdGfvV3u0DMVbL9VW-VGOUEDav4eQBk=.634bdcb6-1ee3-4c91-a790-7df10e2bf9fb@github.com>
References: <Cw_ooHhtnB9aJdGfvV3u0DMVbL9VW-VGOUEDav4eQBk=.634bdcb6-1ee3-4c91-a790-7df10e2bf9fb@github.com>
Message-ID: <SKhAJpcVy0DVZb7GfuSKo6zYlEe4JnkLyQvls4D9N9o=.623a6735-af9d-4c1d-acc6-814c36456a4a@github.com>

> Hi all,
> 
> Currently the fatal error message was print to stderr, shows as below. I think it's bettor to print the fatal error message to stderr.
> 
>> unset JAVA_HOME ; jtreg -version
> No java executable at java
> 
>> unset JAVA_HOME ; jtreg -version > /dev/null
> #nothing
> 
> The `>&2` usage for echo both works on linux and cygwin. I do not have other OS system to verify this change, but I think the risk of this change is low.

SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'openjdk:master' into stderr
 - Merge branch 'openjdk:master' into stderr
 - Merge branch 'openjdk:master' into stderr
 - 7904083: Print fatal error messages to stderr

-------------

Changes:
  - all: https://git.openjdk.org/jtreg/pull/290/files
  - new: https://git.openjdk.org/jtreg/pull/290/files/c03ca794..0a46dc6b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jtreg&pr=290&range=03
 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=290&range=02-03

  Stats: 196 lines in 18 files changed: 162 ins; 5 del; 29 mod
  Patch: https://git.openjdk.org/jtreg/pull/290.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/290/head:pull/290

PR: https://git.openjdk.org/jtreg/pull/290

From cstein at openjdk.org  Wed Jan 28 15:34:12 2026
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 28 Jan 2026 15:34:12 GMT
Subject: RFR: 7904084: Unset javaOpts and jtregOpts in jtreg.sh [v4]
In-Reply-To: <D2lsjwnJP_l8gkRQgjyI-h9cAOEq3bC7LFUm5xKdI74=.59d3a5be-75cc-4621-ad8d-ad6c965eae56@github.com>
References: <K4U0-tl4b_m7P2GLdBPm8WMXK7Z9n8AwhQH4D59WoHM=.fb58f7e1-402b-47f7-94ad-ead4f0de53d8@github.com>
 <D2lsjwnJP_l8gkRQgjyI-h9cAOEq3bC7LFUm5xKdI74=.59d3a5be-75cc-4621-ad8d-ad6c965eae56@github.com>
Message-ID: <rRZFcv4BrO--UbkUvYI0dDk-9KtGg3H4vU0-ixjJClw=.2d257ecc-6b86-4520-975f-8683c269a55f@github.com>

On Wed, 28 Jan 2026 07:07:23 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> 
>> In jtreg.sh it will combine all the java options and jtreg options in the `for i in "$@"` loop. SHELL use javaOpts and jtregOpts as global varable by default, this means jtreg.sh will receive the value of javaOpts and jtregOpts outside. I think this unexpected.
>> To avoid this siutation, I think we should unset javaOpts and jtregOpts before use it.
>
> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into jbs7904084
>  - Merge branch 'openjdk:master' into jbs7904084
>  - Merge branch 'openjdk:master' into jbs7904084
>  - 7904084: Unset javaOpts and jtregOpts in jtreg.sh

Marked as reviewed by cstein (Reviewer).

-------------

PR Review: https://git.openjdk.org/jtreg/pull/291#pullrequestreview-3717376171

From cstein at openjdk.org  Wed Jan 28 15:40:14 2026
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 28 Jan 2026 15:40:14 GMT
Subject: RFR: 7904083: Print fatal error messages to stderr [v4]
In-Reply-To: <SKhAJpcVy0DVZb7GfuSKo6zYlEe4JnkLyQvls4D9N9o=.623a6735-af9d-4c1d-acc6-814c36456a4a@github.com>
References: <Cw_ooHhtnB9aJdGfvV3u0DMVbL9VW-VGOUEDav4eQBk=.634bdcb6-1ee3-4c91-a790-7df10e2bf9fb@github.com>
 <SKhAJpcVy0DVZb7GfuSKo6zYlEe4JnkLyQvls4D9N9o=.623a6735-af9d-4c1d-acc6-814c36456a4a@github.com>
Message-ID: <10XRwI-TkuwzH4sTC_NtGqNDQeOMJ3-MESARBoWj5dY=.e2b706a8-4cc0-43a7-8ffa-f365db1dc3c6@github.com>

On Wed, 28 Jan 2026 07:42:26 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> 
>> Currently the fatal error message was print to stderr, shows as below. I think it's bettor to print the fatal error message to stderr.
>> 
>>> unset JAVA_HOME ; jtreg -version
>> No java executable at java
>> 
>>> unset JAVA_HOME ; jtreg -version > /dev/null
>> #nothing
>> 
>> The `>&2` usage for echo both works on linux and cygwin. I do not have other OS system to verify this change, but I think the risk of this change is low.
>
> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into stderr
>  - Merge branch 'openjdk:master' into stderr
>  - Merge branch 'openjdk:master' into stderr
>  - 7904083: Print fatal error messages to stderr

> [CODETOOLS-7904083](https://bugs.openjdk.org/browse/CODETOOLS-7904083): Print fatal error messages to stderr (Enhancement - P4) ?? Issue is not open.

Please also close this PR after closing the underlying issue.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/290#issuecomment-3812014604

From cstein at openjdk.org  Wed Jan 28 16:17:44 2026
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 28 Jan 2026 16:17:44 GMT
Subject: RFR: 7904143: Release jtreg 8.2.1
Message-ID: <jZgGYz91mPkLX9t6Lbp0DInTxBd9d6VQLFBtUBC8VLs=.bfec2593-19e6-4229-b5ad-6e745eb68b0c@github.com>

Please review this change to set jtreg's version number to `8.2.1` and update the `CHANGELOG.md` file to include a section about jtreg 8.2.1

URL targets used in the `CHANGELOG.md` file will start to work after the resulting commit was tagged. For example: https://git.openjdk.org/jtreg/compare/jtreg-8.2.1+1...master

Note that this an empty fixup release.

-------------

Commit messages:
 - 7904143: Release jtreg 8.2.1

Changes: https://git.openjdk.org/jtreg/pull/311/files
  Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=311&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904143
  Stats: 6 lines in 2 files changed: 4 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jtreg/pull/311.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/311/head:pull/311

PR: https://git.openjdk.org/jtreg/pull/311

From jlahoda at openjdk.org  Wed Jan 28 16:29:42 2026
From: jlahoda at openjdk.org (Jan Lahoda)
Date: Wed, 28 Jan 2026 16:29:42 GMT
Subject: RFR: 7904143: Release jtreg 8.2.1
In-Reply-To: <jZgGYz91mPkLX9t6Lbp0DInTxBd9d6VQLFBtUBC8VLs=.bfec2593-19e6-4229-b5ad-6e745eb68b0c@github.com>
References: <jZgGYz91mPkLX9t6Lbp0DInTxBd9d6VQLFBtUBC8VLs=.bfec2593-19e6-4229-b5ad-6e745eb68b0c@github.com>
Message-ID: <ABjd_cUZ6uxiGkrwDz7Hzg_oQWXfz5qoQIDfKvOG0ZU=.f9e62ce5-dc60-49ec-a6d7-4012198fd6a7@github.com>

On Wed, 28 Jan 2026 16:09:36 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change to set jtreg's version number to `8.2.1` and update the `CHANGELOG.md` file to include a section about jtreg 8.2.1
> 
> URL targets used in the `CHANGELOG.md` file will start to work after the resulting commit was tagged. For example: https://git.openjdk.org/jtreg/compare/jtreg-8.2.1+1...master
> 
> Note that this an empty fixup release.

Looks OK.

-------------

Marked as reviewed by jlahoda (Lead).

PR Review: https://git.openjdk.org/jtreg/pull/311#pullrequestreview-3717694578

From cstein at openjdk.org  Wed Jan 28 16:35:14 2026
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 28 Jan 2026 16:35:14 GMT
Subject: Integrated: 7904143: Release jtreg 8.2.1
In-Reply-To: <jZgGYz91mPkLX9t6Lbp0DInTxBd9d6VQLFBtUBC8VLs=.bfec2593-19e6-4229-b5ad-6e745eb68b0c@github.com>
References: <jZgGYz91mPkLX9t6Lbp0DInTxBd9d6VQLFBtUBC8VLs=.bfec2593-19e6-4229-b5ad-6e745eb68b0c@github.com>
Message-ID: <YKe1yCGgMySRvLc_huaAKEUledqsjPrapw0sVYll2NM=.c3791e1f-c7b3-4e08-ae32-cc6ccff31eac@github.com>

On Wed, 28 Jan 2026 16:09:36 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change to set jtreg's version number to `8.2.1` and update the `CHANGELOG.md` file to include a section about jtreg 8.2.1
> 
> URL targets used in the `CHANGELOG.md` file will start to work after the resulting commit was tagged. For example: https://git.openjdk.org/jtreg/compare/jtreg-8.2.1+1...master
> 
> Note that this an empty fixup release.

This pull request has now been integrated.

Changeset: 5afa26a2
Author:    Christian Stein <cstein at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/5afa26a21f06e3f231982f0d0abc50c33d68167c
Stats:     6 lines in 2 files changed: 4 ins; 0 del; 2 mod

7904143: Release jtreg 8.2.1

Reviewed-by: jlahoda

-------------

PR: https://git.openjdk.org/jtreg/pull/311

From syan at openjdk.org  Thu Jan 29 01:15:29 2026
From: syan at openjdk.org (SendaoYan)
Date: Thu, 29 Jan 2026 01:15:29 GMT
Subject: RFR: 7904083: Print fatal error messages to stderr [v4]
In-Reply-To: <10XRwI-TkuwzH4sTC_NtGqNDQeOMJ3-MESARBoWj5dY=.e2b706a8-4cc0-43a7-8ffa-f365db1dc3c6@github.com>
References: <Cw_ooHhtnB9aJdGfvV3u0DMVbL9VW-VGOUEDav4eQBk=.634bdcb6-1ee3-4c91-a790-7df10e2bf9fb@github.com>
 <SKhAJpcVy0DVZb7GfuSKo6zYlEe4JnkLyQvls4D9N9o=.623a6735-af9d-4c1d-acc6-814c36456a4a@github.com>
 <10XRwI-TkuwzH4sTC_NtGqNDQeOMJ3-MESARBoWj5dY=.e2b706a8-4cc0-43a7-8ffa-f365db1dc3c6@github.com>
Message-ID: <ip7NH172RIoPQIgtjrTFDsk3dh9qWJb02Ny0xFdU0ps=.4398e2ce-6d7a-4a19-9bcd-c903aa454246@github.com>

On Wed, 28 Jan 2026 15:37:09 GMT, Christian Stein <cstein at openjdk.org> wrote:

> > [CODETOOLS-7904083](https://bugs.openjdk.org/browse/CODETOOLS-7904083): Print fatal error messages to stderr (Enhancement - P4) ?? Issue is not open.
> 
> Please also close this PR after closing the underlying issue.

Okey

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/290#issuecomment-3814782669

From syan at openjdk.org  Thu Jan 29 01:15:31 2026
From: syan at openjdk.org (SendaoYan)
Date: Thu, 29 Jan 2026 01:15:31 GMT
Subject: Withdrawn: 7904083: Print fatal error messages to stderr
In-Reply-To: <Cw_ooHhtnB9aJdGfvV3u0DMVbL9VW-VGOUEDav4eQBk=.634bdcb6-1ee3-4c91-a790-7df10e2bf9fb@github.com>
References: <Cw_ooHhtnB9aJdGfvV3u0DMVbL9VW-VGOUEDav4eQBk=.634bdcb6-1ee3-4c91-a790-7df10e2bf9fb@github.com>
Message-ID: <QQPm6IszqXPPDZ-V4u0WigfjfIfBlsPC7oEWUdunicY=.0075812c-bc44-49a5-a9a1-0ffb03f3f17d@github.com>

On Tue, 23 Sep 2025 06:52:38 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> Currently the fatal error message was print to stderr, shows as below. I think it's bettor to print the fatal error message to stderr.
> 
>> unset JAVA_HOME ; jtreg -version
> No java executable at java
> 
>> unset JAVA_HOME ; jtreg -version > /dev/null
> #nothing
> 
> The `>&2` usage for echo both works on linux and cygwin. I do not have other OS system to verify this change, but I think the risk of this change is low.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jtreg/pull/290

From syan at openjdk.org  Thu Jan 29 02:42:15 2026
From: syan at openjdk.org (SendaoYan)
Date: Thu, 29 Jan 2026 02:42:15 GMT
Subject: RFR: 7904084: Unset javaOpts and jtregOpts in jtreg.sh [v2]
In-Reply-To: <pfwa_8F5ajhrnD3tlisRTkvDTesINF7Z6qcy6_gG9Zo=.55f9d549-fc06-4dc0-9053-8fe0b3672d88@github.com>
References: <K4U0-tl4b_m7P2GLdBPm8WMXK7Z9n8AwhQH4D59WoHM=.fb58f7e1-402b-47f7-94ad-ead4f0de53d8@github.com>
 <8WJCZd44tfAGAlVfiyZAR_OFOosCwUz0WDOFi23snuI=.de9c7f05-6d32-4f59-b320-89e9cb244af0@github.com>
 <pfwa_8F5ajhrnD3tlisRTkvDTesINF7Z6qcy6_gG9Zo=.55f9d549-fc06-4dc0-9053-8fe0b3672d88@github.com>
Message-ID: <uc7ls9nZJeCnGBBErVTxaaBWyUjZUUfOGKcFbN9SZ-U=.787abd37-7163-4e22-a7c8-a1dd24b3b8d5@github.com>

On Tue, 2 Dec 2025 12:01:02 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into jbs7904084
>>  - 7904084: Unset javaOpts and jtregOpts in jtreg.sh
>
> Did you see an error when used in combination with another or the same script? If yes, which one(s)?
> 
> There's related prior-art in the script for the `DUALCASE` variable. Which is declard and initialized before each use, and `unset` after each use. Would it be possible to the same for `javaOpts` and `jtregOpts`? Or at least `unset` both after use.
> 
> Another solution would be to introduce script-`local` variables, right?

Thanks for the reviews @sormuras 

Does this PR need second reviewer, or may I integrate this PR now.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/291#issuecomment-3815092641

From liach at openjdk.org  Thu Jan 29 08:08:47 2026
From: liach at openjdk.org (Chen Liang)
Date: Thu, 29 Jan 2026 08:08:47 GMT
Subject: RFR: 7904084: Unset javaOpts and jtregOpts in jtreg.sh [v4]
In-Reply-To: <D2lsjwnJP_l8gkRQgjyI-h9cAOEq3bC7LFUm5xKdI74=.59d3a5be-75cc-4621-ad8d-ad6c965eae56@github.com>
References: <K4U0-tl4b_m7P2GLdBPm8WMXK7Z9n8AwhQH4D59WoHM=.fb58f7e1-402b-47f7-94ad-ead4f0de53d8@github.com>
 <D2lsjwnJP_l8gkRQgjyI-h9cAOEq3bC7LFUm5xKdI74=.59d3a5be-75cc-4621-ad8d-ad6c965eae56@github.com>
Message-ID: <tjejGATfrpUEOMxEkudEpQ8sz_vbhvFG5lUX4-wXcWo=.be0cab1d-de0c-4e9f-a00b-4c8f4148968b@github.com>

On Wed, 28 Jan 2026 07:07:23 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> 
>> In jtreg.sh it will combine all the java options and jtreg options in the `for i in "$@"` loop. SHELL use javaOpts and jtregOpts as global varable by default, this means jtreg.sh will receive the value of javaOpts and jtregOpts outside. I think this unexpected.
>> To avoid this siutation, I think we should unset javaOpts and jtregOpts before use it.
>
> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into jbs7904084
>  - Merge branch 'openjdk:master' into jbs7904084
>  - Merge branch 'openjdk:master' into jbs7904084
>  - 7904084: Unset javaOpts and jtregOpts in jtreg.sh

Clearing variable before loop makes sense.

-------------

Marked as reviewed by liach (no project role).

PR Review: https://git.openjdk.org/jtreg/pull/291#pullrequestreview-3721241834

From cstein at openjdk.org  Thu Jan 29 08:16:44 2026
From: cstein at openjdk.org (Christian Stein)
Date: Thu, 29 Jan 2026 08:16:44 GMT
Subject: RFR: 7904084: Unset javaOpts and jtregOpts in jtreg.sh [v2]
In-Reply-To: <uc7ls9nZJeCnGBBErVTxaaBWyUjZUUfOGKcFbN9SZ-U=.787abd37-7163-4e22-a7c8-a1dd24b3b8d5@github.com>
References: <K4U0-tl4b_m7P2GLdBPm8WMXK7Z9n8AwhQH4D59WoHM=.fb58f7e1-402b-47f7-94ad-ead4f0de53d8@github.com>
 <8WJCZd44tfAGAlVfiyZAR_OFOosCwUz0WDOFi23snuI=.de9c7f05-6d32-4f59-b320-89e9cb244af0@github.com>
 <pfwa_8F5ajhrnD3tlisRTkvDTesINF7Z6qcy6_gG9Zo=.55f9d549-fc06-4dc0-9053-8fe0b3672d88@github.com>
 <uc7ls9nZJeCnGBBErVTxaaBWyUjZUUfOGKcFbN9SZ-U=.787abd37-7163-4e22-a7c8-a1dd24b3b8d5@github.com>
Message-ID: <ECp9zYuEMM475i3QJ09Vy7gFpiPwmVAeDhrDoI3pRRk=.63e1c877-cb06-446f-8887-971bba1d2272@github.com>

On Thu, 29 Jan 2026 02:39:43 GMT, SendaoYan <syan at openjdk.org> wrote:

> [...] may I integrate this PR now.

Yes. Happy to sponsor afterwards.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/291#issuecomment-3816152643

From cstein at openjdk.org  Thu Jan 29 08:34:35 2026
From: cstein at openjdk.org (Christian Stein)
Date: Thu, 29 Jan 2026 08:34:35 GMT
Subject: Integrated: 7904144: Update version to 8.3
Message-ID: <ORk5_qHPELh59JD2O4v7nlfpjzRxpLEQoISaV_Cgo_U=.c3d2bf53-9956-4f1e-aefa-1d9b0c595368@github.com>

Please review this change to update jtreg's version to 8.3

-------------

Commit messages:
 - 7904144: Update JTREG_VERSION to 8.3

Changes: https://git.openjdk.org/jtreg/pull/312/files
  Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=312&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904144
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jtreg/pull/312.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/312/head:pull/312

PR: https://git.openjdk.org/jtreg/pull/312

From jlahoda at openjdk.org  Thu Jan 29 08:34:36 2026
From: jlahoda at openjdk.org (Jan Lahoda)
Date: Thu, 29 Jan 2026 08:34:36 GMT
Subject: Integrated: 7904144: Update version to 8.3
In-Reply-To: <ORk5_qHPELh59JD2O4v7nlfpjzRxpLEQoISaV_Cgo_U=.c3d2bf53-9956-4f1e-aefa-1d9b0c595368@github.com>
References: <ORk5_qHPELh59JD2O4v7nlfpjzRxpLEQoISaV_Cgo_U=.c3d2bf53-9956-4f1e-aefa-1d9b0c595368@github.com>
Message-ID: <vlWtKzsa6RP0VcDZB9C6T9Lus9m0I_olfwkapdHlXvc=.f224b9c2-d13c-46df-bf7d-c4cb9265b621@github.com>

On Thu, 29 Jan 2026 08:24:56 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change to update jtreg's version to 8.3

LGTM

-------------

Marked as reviewed by jlahoda (Lead).

PR Review: https://git.openjdk.org/jtreg/pull/312#pullrequestreview-3721317196

From cstein at openjdk.org  Thu Jan 29 08:34:37 2026
From: cstein at openjdk.org (Christian Stein)
Date: Thu, 29 Jan 2026 08:34:37 GMT
Subject: Integrated: 7904144: Update version to 8.3
In-Reply-To: <ORk5_qHPELh59JD2O4v7nlfpjzRxpLEQoISaV_Cgo_U=.c3d2bf53-9956-4f1e-aefa-1d9b0c595368@github.com>
References: <ORk5_qHPELh59JD2O4v7nlfpjzRxpLEQoISaV_Cgo_U=.c3d2bf53-9956-4f1e-aefa-1d9b0c595368@github.com>
Message-ID: <TApU8l4hvm1cW--RDIRrZumYNXEfbnds6Tb4f4hAfyc=.18419d8d-d7e7-471b-b525-77096dc1720c@github.com>

On Thu, 29 Jan 2026 08:24:56 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change to update jtreg's version to 8.3

This pull request has now been integrated.

Changeset: 1eed6503
Author:    Christian Stein <cstein at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/1eed650345ec03c1fbafc7d79956f86e2b28b354
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

7904144: Update version to 8.3

Reviewed-by: jlahoda

-------------

PR: https://git.openjdk.org/jtreg/pull/312

From duke at openjdk.org  Thu Jan 29 09:39:00 2026
From: duke at openjdk.org (duke)
Date: Thu, 29 Jan 2026 09:39:00 GMT
Subject: RFR: 7904084: Unset javaOpts and jtregOpts in jtreg.sh [v4]
In-Reply-To: <D2lsjwnJP_l8gkRQgjyI-h9cAOEq3bC7LFUm5xKdI74=.59d3a5be-75cc-4621-ad8d-ad6c965eae56@github.com>
References: <K4U0-tl4b_m7P2GLdBPm8WMXK7Z9n8AwhQH4D59WoHM=.fb58f7e1-402b-47f7-94ad-ead4f0de53d8@github.com>
 <D2lsjwnJP_l8gkRQgjyI-h9cAOEq3bC7LFUm5xKdI74=.59d3a5be-75cc-4621-ad8d-ad6c965eae56@github.com>
Message-ID: <xYPTzazHLLZrt6kXu0B1M1caoBIRXI4iusu9rRSwMM0=.cfdcbe8b-1dc0-4450-8479-27f829b68889@github.com>

On Wed, 28 Jan 2026 07:07:23 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> 
>> In jtreg.sh it will combine all the java options and jtreg options in the `for i in "$@"` loop. SHELL use javaOpts and jtregOpts as global varable by default, this means jtreg.sh will receive the value of javaOpts and jtregOpts outside. I think this unexpected.
>> To avoid this siutation, I think we should unset javaOpts and jtregOpts before use it.
>
> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into jbs7904084
>  - Merge branch 'openjdk:master' into jbs7904084
>  - Merge branch 'openjdk:master' into jbs7904084
>  - 7904084: Unset javaOpts and jtregOpts in jtreg.sh

@sendaoYan 
Your change (at version a3076f53d2081c818c7435f9b633bb8d820ad330) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/291#issuecomment-3816524339

From syan at openjdk.org  Thu Jan 29 09:50:07 2026
From: syan at openjdk.org (SendaoYan)
Date: Thu, 29 Jan 2026 09:50:07 GMT
Subject: RFR: 7904084: Unset javaOpts and jtregOpts in jtreg.sh [v2]
In-Reply-To: <ECp9zYuEMM475i3QJ09Vy7gFpiPwmVAeDhrDoI3pRRk=.63e1c877-cb06-446f-8887-971bba1d2272@github.com>
References: <K4U0-tl4b_m7P2GLdBPm8WMXK7Z9n8AwhQH4D59WoHM=.fb58f7e1-402b-47f7-94ad-ead4f0de53d8@github.com>
 <8WJCZd44tfAGAlVfiyZAR_OFOosCwUz0WDOFi23snuI=.de9c7f05-6d32-4f59-b320-89e9cb244af0@github.com>
 <pfwa_8F5ajhrnD3tlisRTkvDTesINF7Z6qcy6_gG9Zo=.55f9d549-fc06-4dc0-9053-8fe0b3672d88@github.com>
 <uc7ls9nZJeCnGBBErVTxaaBWyUjZUUfOGKcFbN9SZ-U=.787abd37-7163-4e22-a7c8-a1dd24b3b8d5@github.com>
 <ECp9zYuEMM475i3QJ09Vy7gFpiPwmVAeDhrDoI3pRRk=.63e1c877-cb06-446f-8887-971bba1d2272@github.com>
Message-ID: <0rAwM-lejjuLqAdBEHCni_nM-L2ln2PCFEvmlkkS170=.aa234a14-afee-4e10-a4d9-98496f110dff@github.com>

On Thu, 29 Jan 2026 08:14:08 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Thanks for the reviews @sormuras 
>> 
>> Does this PR need second reviewer, or may I integrate this PR now.
>
>> [...] may I integrate this PR now.
> 
> Yes. Happy to sponsor afterwards.

Thanks @sormuras @liach

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/291#issuecomment-3816576964

From syan at openjdk.org  Thu Jan 29 09:50:08 2026
From: syan at openjdk.org (SendaoYan)
Date: Thu, 29 Jan 2026 09:50:08 GMT
Subject: Integrated: 7904084: Unset javaOpts and jtregOpts in jtreg.sh
In-Reply-To: <K4U0-tl4b_m7P2GLdBPm8WMXK7Z9n8AwhQH4D59WoHM=.fb58f7e1-402b-47f7-94ad-ead4f0de53d8@github.com>
References: <K4U0-tl4b_m7P2GLdBPm8WMXK7Z9n8AwhQH4D59WoHM=.fb58f7e1-402b-47f7-94ad-ead4f0de53d8@github.com>
Message-ID: <IWUrsQQy0gpUnvcaPuELHf6BRZEeieCoWlySV-kadbM=.98fe905f-243e-4fea-8077-b374e6924a38@github.com>

On Wed, 24 Sep 2025 13:53:39 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> In jtreg.sh it will combine all the java options and jtreg options in the `for i in "$@"` loop. SHELL use javaOpts and jtregOpts as global varable by default, this means jtreg.sh will receive the value of javaOpts and jtregOpts outside. I think this unexpected.
> To avoid this siutation, I think we should unset javaOpts and jtregOpts before use it.

This pull request has now been integrated.

Changeset: 3c9174b5
Author:    SendaoYan <syan at openjdk.org>
Committer: Christian Stein <cstein at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/3c9174b58e60e1231322509012a0f0a04aba2980
Stats:     2 lines in 1 file changed: 2 ins; 0 del; 0 mod

7904084: Unset javaOpts and jtregOpts in jtreg.sh

Reviewed-by: cstein, liach

-------------

PR: https://git.openjdk.org/jtreg/pull/291

From cstein at openjdk.org  Thu Jan 29 15:01:16 2026
From: cstein at openjdk.org (Christian Stein)
Date: Thu, 29 Jan 2026 15:01:16 GMT
Subject: RFR: 7904141: JTReg should support running compact source files
Message-ID: <4Kv3-E_4CQk8BnpKReRmy4NU2BkIWsTh9qttFh_tFc8=.3e34e17e-d9cb-49d0-81c6-5afa57a5710b@github.com>

Please review this change that adds support for running compact source files as jtreg `main` tests.

This pull request also adds JDK 25 to the GHA-based CI workflow and updates to use newer GitHub actions: `actions/checkout at v6` and `actions/setup-java at v5`

-------------

Commit messages:
 - Cleanup
 - Fix syntax
 - Install JDK 25 and 21
 - Configure correct makefile
 - Fix path to pre-installed JDK 25
 - Introduce `JDK25HOME` variable
 - 7904141: JTReg should support running compact source files

Changes: https://git.openjdk.org/jtreg/pull/313/files
  Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=313&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904141
  Stats: 260 lines in 10 files changed: 249 ins; 0 del; 11 mod
  Patch: https://git.openjdk.org/jtreg/pull/313.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/313/head:pull/313

PR: https://git.openjdk.org/jtreg/pull/313