RFR: 7904126: PrintWriter(s) used by jtreg for agent logging aren't using autoFlush
Christian Stein
cstein at openjdk.org
Wed Jan 7 11:06:52 UTC 2026
On Tue, 6 Jan 2026 05:27:48 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7904126?
>
> With this change the logs written out to agent.trace and agentServer.<id>.trace should now have these log message more promptly written out and thus help debug and unexpected test failures. Furthermore, the explicit flush() that was done in https://bugs.openjdk.org/browse/CODETOOLS-7903470 has now been replaced with the use of this autoFlush=true to avoid having to explicitly flush() at any call sites where the logger is used to write out the logs.
>
> Given the nature of the change no new self tests have been introduced.
Looks reasonable.
-------------
Marked as reviewed by cstein (Reviewer).
PR Review: https://git.openjdk.org/jtreg/pull/305#pullrequestreview-3634368684
More information about the jtreg-dev
mailing list