RFR: 7904084: Unset javaOpts and jtregOpts in jtreg.sh [v4]
Chen Liang
liach at openjdk.org
Thu Jan 29 08:08:47 UTC 2026
On Wed, 28 Jan 2026 07:07:23 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>>
>> In jtreg.sh it will combine all the java options and jtreg options in the `for i in "$@"` loop. SHELL use javaOpts and jtregOpts as global varable by default, this means jtreg.sh will receive the value of javaOpts and jtregOpts outside. I think this unexpected.
>> To avoid this siutation, I think we should unset javaOpts and jtregOpts before use it.
>
> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into jbs7904084
> - Merge branch 'openjdk:master' into jbs7904084
> - Merge branch 'openjdk:master' into jbs7904084
> - 7904084: Unset javaOpts and jtregOpts in jtreg.sh
Clearing variable before loop makes sense.
-------------
Marked as reviewed by liach (no project role).
PR Review: https://git.openjdk.org/jtreg/pull/291#pullrequestreview-3721241834
More information about the jtreg-dev
mailing list