From martinrb at google.com Thu Oct 2 11:14:17 2008 From: martinrb at google.com (Martin Buchholz) Date: Thu, 2 Oct 2008 11:14:17 -0700 Subject: More careful identification of @ignore Message-ID: <1ccfd1c10810021114h6c4e6b14g48600f1d2bc26e8b@mail.gmail.com> Hi jtreg maintainers, This is a bug report. If I try to test jdk/test/sun/net/idn/PunycodeTest.java, with @ignore'd tests suppressed, I get: jdk/test/sun/net/idn $ ~/jct-tools/3.2.2_03/linux/bin/jtreg -v:nopass,fail -automatic "-k:\!ignore" -testjdk:$FOREST/jdk/../build/linux-i586/j2sdk-image PunycodeTest.java Test results: no tests selected This is due to the occurrence of the string "ignore" in * @compile -XDignore.symbol.file PunycodeTest.java as any mangling of that string in the sources and retesting demonstrates. Probably the original coder was lazy and simply searched for the "ignore" substring, whereas a more disciplined search for @ignore or maybe @key WORD ... is necessary. Martin From Jonathan.Gibbons at Sun.COM Thu Oct 2 11:29:13 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Thu, 02 Oct 2008 11:29:13 -0700 Subject: More careful identification of @ignore In-Reply-To: <1ccfd1c10810021114h6c4e6b14g48600f1d2bc26e8b@mail.gmail.com> References: <1ccfd1c10810021114h6c4e6b14g48600f1d2bc26e8b@mail.gmail.com> Message-ID: <48E512F9.7050000@sun.com> Eeeek, so noted. I'll investigate. -- Jon Martin Buchholz wrote: > Hi jtreg maintainers, > > This is a bug report. > > If I try to test jdk/test/sun/net/idn/PunycodeTest.java, > with @ignore'd tests suppressed, I get: > > jdk/test/sun/net/idn $ ~/jct-tools/3.2.2_03/linux/bin/jtreg > -v:nopass,fail -automatic "-k:\!ignore" > -testjdk:$FOREST/jdk/../build/linux-i586/j2sdk-image PunycodeTest.java > Test results: no tests selected > > This is due to the occurrence of the string "ignore" in > > * @compile -XDignore.symbol.file PunycodeTest.java > > as any mangling of that string in the sources and retesting demonstrates. > > Probably the original coder was lazy and simply searched for the > "ignore" substring, > whereas a more disciplined search for @ignore or maybe @key WORD ... > is necessary. > > Martin > From Jonathan.Gibbons at Sun.COM Thu Oct 2 11:47:37 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Thu, 02 Oct 2008 11:47:37 -0700 Subject: More careful identification of @ignore In-Reply-To: <48E512F9.7050000@sun.com> References: <1ccfd1c10810021114h6c4e6b14g48600f1d2bc26e8b@mail.gmail.com> <48E512F9.7050000@sun.com> Message-ID: <48E51749.20108@sun.com> Egads, 'twould appear t'be true. As a workaround, I suggest you use the -ignore switch (e.g. -ignore:quiet) instead of -k:\!ignore. -- Jon Jonathan Gibbons wrote: > Eeeek, so noted. I'll investigate. > > -- Jon > > > Martin Buchholz wrote: >> Hi jtreg maintainers, >> >> This is a bug report. >> >> If I try to test jdk/test/sun/net/idn/PunycodeTest.java, >> with @ignore'd tests suppressed, I get: >> >> jdk/test/sun/net/idn $ ~/jct-tools/3.2.2_03/linux/bin/jtreg >> -v:nopass,fail -automatic "-k:\!ignore" >> -testjdk:$FOREST/jdk/../build/linux-i586/j2sdk-image PunycodeTest.java >> Test results: no tests selected >> >> This is due to the occurrence of the string "ignore" in >> >> * @compile -XDignore.symbol.file PunycodeTest.java >> >> as any mangling of that string in the sources and retesting >> demonstrates. >> >> Probably the original coder was lazy and simply searched for the >> "ignore" substring, >> whereas a more disciplined search for @ignore or maybe @key WORD ... >> is necessary. >> >> Martin >> > > From martinrb at google.com Thu Oct 2 12:17:53 2008 From: martinrb at google.com (Martin Buchholz) Date: Thu, 2 Oct 2008 12:17:53 -0700 Subject: More careful identification of @ignore In-Reply-To: <48E51749.20108@sun.com> References: <1ccfd1c10810021114h6c4e6b14g48600f1d2bc26e8b@mail.gmail.com> <48E512F9.7050000@sun.com> <48E51749.20108@sun.com> Message-ID: <1ccfd1c10810021217u20c3f994u70f9290bdea3e5ac@mail.gmail.com> On Thu, Oct 2, 2008 at 11:47, Jonathan Gibbons wrote: > Egads, 'twould appear t'be true. > > As a workaround, I suggest you use the -ignore switch (e.g. -ignore:quiet) > instead of -k:\!ignore. I tried -ignore:quiet, but that appears to have the same bug; that is, it is not a workaround. Martin From Jonathan.Gibbons at Sun.COM Thu Oct 2 12:26:41 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Thu, 02 Oct 2008 12:26:41 -0700 Subject: More careful identification of @ignore In-Reply-To: <1ccfd1c10810021217u20c3f994u70f9290bdea3e5ac@mail.gmail.com> References: <1ccfd1c10810021114h6c4e6b14g48600f1d2bc26e8b@mail.gmail.com> <48E512F9.7050000@sun.com> <48E51749.20108@sun.com> <1ccfd1c10810021217u20c3f994u70f9290bdea3e5ac@mail.gmail.com> Message-ID: <48E52071.301@sun.com> I'm sorry; that is ... disappointing. I'll raise the priority to fix this. -- Jon Martin Buchholz wrote: > On Thu, Oct 2, 2008 at 11:47, Jonathan Gibbons wrote: > >> Egads, 'twould appear t'be true. >> >> As a workaround, I suggest you use the -ignore switch (e.g. -ignore:quiet) >> instead of -k:\!ignore. >> > > I tried -ignore:quiet, > but that appears to have the same bug; > that is, it is not a workaround. > > Martin > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jtreg-use/attachments/20081002/1e246e6a/attachment.html From volker.simonis at gmail.com Mon Oct 13 08:23:17 2008 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 13 Oct 2008 17:23:17 +0200 Subject: Setting PATH for jtreg Message-ID: Hi, the jtreg FAQ states in point 4.1: As per spec, the only shell environment variables that are propagated into the test's JVM are: * Linux and Solaris: o PATH is set to /bin:/usr/bin However in our environment, the compilers are installed on a global NFS-share. I have the problem that all the tests which use gcc to compile native JNI files fail because they get a wrong version of gcc from /usr/bin. Is there any possibility how I can override the PATH variable for jtreg? Regards, Volker From Jonathan.Gibbons at Sun.COM Mon Oct 13 09:30:42 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Mon, 13 Oct 2008 09:30:42 -0700 Subject: Setting PATH for jtreg In-Reply-To: References: Message-ID: <4AE0F4C0-9781-46DA-85C2-400738F49363@sun.com> Volker, jtreg has a -e option for tunnelling env variables into scripts. Use "jtreg -help -e" for info. Any values specified with -e override any defaults set up for the test. So, it should work to use -e:PATH to override the system default value of PATH with the value from your current environment. -- Jon On Oct 13, 2008, at 8:23 AM, Volker Simonis wrote: > Hi, > > the jtreg FAQ states in point 4.1: > > As per spec, the only shell environment variables that are propagated > into the test's JVM are: > > * Linux and Solaris: > o PATH is set to /bin:/usr/bin > > However in our environment, the compilers are installed on a global > NFS-share. I have the problem that all the tests which use gcc to > compile native JNI files fail because they get a wrong version of gcc > from /usr/bin. > > Is there any possibility how I can override the PATH variable for > jtreg? > > Regards, > Volker From volker.simonis at gmail.com Tue Oct 14 00:30:15 2008 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 14 Oct 2008 09:30:15 +0200 Subject: Setting PATH for jtreg In-Reply-To: <4AE0F4C0-9781-46DA-85C2-400738F49363@sun.com> References: <4AE0F4C0-9781-46DA-85C2-400738F49363@sun.com> Message-ID: Hi John, thank you for the fast help. "-e:PATH" indeed solved the problem. Now that you pointed me to the option I must admit that it is really there. Unfortunately, I didn't found it before, although I did "jtreg -help" several times. This may be perhaps because it is in the "JDK-related Options". For me, this is not strictly a JDK-related option and would better fit into the "General Options". But this is of course purely a matter of taste:) However I think a small advice in the FAQ section 4.1 cited below that PATH can be overriden with the "-e:PATH" option may be helpfull to others as well. Once again thank you and best regards, Volker On 10/13/08, Jonathan Gibbons wrote: > Volker, > > jtreg has a -e option for tunnelling env variables into scripts. > Use "jtreg -help -e" for info. Any values specified with -e > override any defaults set up for the test. So, it should work > to use -e:PATH to override the system default value of PATH > with the value from your current environment. > > -- Jon > > > > On Oct 13, 2008, at 8:23 AM, Volker Simonis wrote: > > > > Hi, > > > > the jtreg FAQ states in point 4.1: > > > > As per spec, the only shell environment variables that are propagated > > into the test's JVM are: > > > > * Linux and Solaris: > > o PATH is set to /bin:/usr/bin > > > > However in our environment, the compilers are installed on a global > > NFS-share. I have the problem that all the tests which use gcc to > > compile native JNI files fail because they get a wrong version of gcc > > from /usr/bin. > > > > Is there any possibility how I can override the PATH variable for jtreg? > > > > Regards, > > Volker > > > > From Jonathan.Gibbons at Sun.COM Tue Oct 14 06:50:36 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Tue, 14 Oct 2008 06:50:36 -0700 Subject: Setting PATH for jtreg In-Reply-To: References: <4AE0F4C0-9781-46DA-85C2-400738F49363@sun.com> Message-ID: Volker, Thank you for the update and suggestions. Your comment about it being more of a general option and not a JDK option and your suggestion about the FAQ are noted. -- Jon On Oct 14, 2008, at 12:30 AM, Volker Simonis wrote: > Hi John, > > thank you for the fast help. "-e:PATH" indeed solved the problem. > > Now that you pointed me to the option I must admit that it is really > there. Unfortunately, I didn't found it before, although I did "jtreg > -help" several times. This may be perhaps because it is in the > "JDK-related Options". For me, this is not strictly a JDK-related > option and would better fit into the "General Options". But this is of > course purely a matter of taste:) > > However I think a small advice in the FAQ section 4.1 cited below that > PATH can be overriden with the "-e:PATH" option may be helpfull to > others as well. > > Once again thank you and best regards, > Volker > > > On 10/13/08, Jonathan Gibbons wrote: >> Volker, >> >> jtreg has a -e option for tunnelling env variables into scripts. >> Use "jtreg -help -e" for info. Any values specified with -e >> override any defaults set up for the test. So, it should work >> to use -e:PATH to override the system default value of PATH >> with the value from your current environment. >> >> -- Jon >> >> >> >> On Oct 13, 2008, at 8:23 AM, Volker Simonis wrote: >> >> >>> Hi, >>> >>> the jtreg FAQ states in point 4.1: >>> >>> As per spec, the only shell environment variables that are >>> propagated >>> into the test's JVM are: >>> >>> * Linux and Solaris: >>> o PATH is set to /bin:/usr/bin >>> >>> However in our environment, the compilers are installed on a global >>> NFS-share. I have the problem that all the tests which use gcc to >>> compile native JNI files fail because they get a wrong version of >>> gcc >>> from /usr/bin. >>> >>> Is there any possibility how I can override the PATH variable for >>> jtreg? >>> >>> Regards, >>> Volker >>> >> >> From Jonathan.Gibbons at Sun.COM Tue Oct 21 14:45:20 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Tue, 21 Oct 2008 14:45:20 -0700 Subject: New jtreg version, 4.0 b02 Message-ID: <48FE4D70.2090100@sun.com> We've released a new build of jtreg, which fixes a number of minor issues. See my blog entry at http://blogs.sun.com/jjg/entry/jtreg_update for details. Thanks to those folk that reported issues and made suggestions, and to Xiomara for helping finally get the bits published. -- Jon