RFR: 7901066: jtreg should propagate LC_CTYPE, not LC_TYPE (a typo)

Jonathan Gibbons jonathan.gibbons at oracle.com
Mon Oct 20 20:03:45 UTC 2014


Martin,

For reference, I checked the following for a list of environment variables:
http://pubs.opengroup.org/onlinepubs/007908799/xbd/envvar.html

and I agree that I see LC_CTYPE and not LC_TYPE.

Given that, I approve the review.  Can I assume you would like me to 
push it for you?

-- Jon

On 10/20/2014 12:36 PM, Martin Buchholz wrote:
> Hi Jonathan,
>
> I'd like you to do a code review.
>
> # HG changeset patch
> # User martin
> # Date 1413833639 25200
> #      Mon Oct 20 12:33:59 2014 -0700
> # Node ID a8beaa09e252997034815bee3dc13c837832b887
> # Parent  5aa862e728dac6fa4b74d58e53fd80f6993a91b4
> 7901066: jtreg should propagate LC_CTYPE, not LC_TYPE (a typo)
> Summary: s/LC_TYPE/LC_CTYPE/g
> Reviewed-by: jjg
>
> diff --git a/src/share/classes/com/sun/javatest/regtest/Main.java 
> b/src/share/classes/com/sun/javatest/regtest/Main.java
> --- a/src/share/classes/com/sun/javatest/regtest/Main.java
> +++ b/src/share/classes/com/sun/javatest/regtest/Main.java
> @@ -2380,7 +2380,7 @@
>      private static final String[] DEFAULT_UNIX_ENV_VARS = {
>          "DISPLAY", "GNOME_DESKTOP_SESSION_ID", "HOME", "LANG",
> -        "LC_ALL", "LC_TYPE", "LPDEST", "PRINTER", "TZ", "XMODIFIERS"
> +        "LC_ALL", "LC_CTYPE", "LPDEST", "PRINTER", "TZ", "XMODIFIERS"
>      };
>      private static final String[] DEFAULT_WINDOWS_ENV_VARS = {
> diff --git a/src/share/doc/javatest/regtest/faq.xml 
> b/src/share/doc/javatest/regtest/faq.xml
> --- a/src/share/doc/javatest/regtest/faq.xml
> +++ b/src/share/doc/javatest/regtest/faq.xml
> @@ -1234,7 +1234,7 @@
>  <code>HOME</code>
>  <code>LANG</code>,
>  <code>LC_ALL</code>,
> -  <code>LC_TYPE</code>,
> +  <code>LC_CTYPE</code>,
>  <code>LPDEST</code>,
>  <code>PRINTER</code>,
>                              <code>TZ</code> and
> diff --git a/src/share/doc/javatest/regtest/tag-spec.html 
> b/src/share/doc/javatest/regtest/tag-spec.html
> --- a/src/share/doc/javatest/regtest/tag-spec.html
> +++ b/src/share/doc/javatest/regtest/tag-spec.html
> @@ -582,7 +582,7 @@
>      <code>HOME</code>,
>      <code>LANG</code>,
>      <code>LC_ALL</code>,
> -    <code>LC_TYPE</code>,
> +    <code>LC_CTYPE</code>,
>      <code>LPDEST</code>,
>      <code>PRINTER</code>,
>      <code>TZ</code> and
>



More information about the jtreg-use mailing list