From robert.field at oracle.com Sat Nov 1 21:03:26 2014 From: robert.field at oracle.com (robert.field at oracle.com) Date: Sat, 01 Nov 2014 21:03:26 +0000 Subject: hg: kulla/dev/langtools: 8062689: REPL: Push current prototype into Kulla repo Message-ID: <201411012103.sA1L3QCO015749@aojmv0008> Changeset: 6fb02c425b33 Author: rfield Date: 2014-11-01 14:01 -0700 URL: http://hg.openjdk.java.net/kulla/dev/langtools/rev/6fb02c425b33 8062689: REPL: Push current prototype into Kulla repo Reviewed-by: briangoetz + repl/README + repl/TODO + repl/samples/PP.repl + repl/samples/Rdef.repl + repl/samples/count.repl + repl/samples/fib.repl + repl/samples/foo.repl + repl/samples/heart.repl + repl/scripts/compile.sh + repl/scripts/run.sh + repl/src/tool/CompletenessScanner.java + repl/src/tool/JavaTokenizer.java + repl/src/tool/LayoutCharacters.java + repl/src/tool/Lexer.java + repl/src/tool/MemoryFileManager.java + repl/src/tool/Name.java + repl/src/tool/Names.java + repl/src/tool/Position.java + repl/src/tool/Repl.java + repl/src/tool/Scanner.java + repl/src/tool/Tokens.java + repl/src/tool/UnicodeReader.java + repl/src/tool/UnsharedNameTable.java From robert.field at oracle.com Wed Nov 5 23:14:53 2014 From: robert.field at oracle.com (robert.field at oracle.com) Date: Wed, 05 Nov 2014 23:14:53 +0000 Subject: hg: kulla/dev/langtools: 8063063: REPL: Use overridden JavacParser Message-ID: <201411052314.sA5NEsGw023513@aojmv0008> Changeset: 11cca79cfebb Author: rfield Date: 2014-11-05 15:12 -0800 URL: http://hg.openjdk.java.net/kulla/dev/langtools/rev/11cca79cfebb 8063063: REPL: Use overridden JavacParser Reviewed-by: briangoetz ! repl/README ! repl/TODO ! repl/scripts/compile.sh ! repl/scripts/run.sh - repl/src/tool/JavaTokenizer.java - repl/src/tool/LayoutCharacters.java - repl/src/tool/Lexer.java - repl/src/tool/Name.java - repl/src/tool/Names.java - repl/src/tool/Position.java ! repl/src/tool/Repl.java + repl/src/tool/ReplParser.java + repl/src/tool/ReplParserFactory.java - repl/src/tool/Scanner.java - repl/src/tool/Tokens.java - repl/src/tool/UnicodeReader.java - repl/src/tool/UnsharedNameTable.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java From robert.field at oracle.com Fri Nov 7 03:25:16 2014 From: robert.field at oracle.com (robert.field at oracle.com) Date: Fri, 07 Nov 2014 03:25:16 +0000 Subject: hg: kulla/dev/langtools: 8064295: REPL: Restructure in preparation for redefinition Message-ID: <201411070325.sA73PHjJ001172@aojmv0008> Changeset: 62876b290a52 Author: rfield Date: 2014-11-06 19:23 -0800 URL: http://hg.openjdk.java.net/kulla/dev/langtools/rev/62876b290a52 8064295: REPL: Restructure in preparation for redefinition Reviewed-by: briangoetz ! repl/README ! repl/TODO ! repl/samples/heart.repl ! repl/scripts/compile.sh ! repl/src/tool/Repl.java + repl/src/tool/RuntimeSupport.java + repl/src/tool/TaskFactory.java + repl/src/tool/Util.java + repl/src/tool/WrapFactory.java From robert.field at oracle.com Sun Nov 9 05:09:06 2014 From: robert.field at oracle.com (robert.field at oracle.com) Date: Sun, 09 Nov 2014 05:09:06 +0000 Subject: hg: kulla/dev/langtools: 8064417: Redeclaration of variables, methods, or classes; Without dependent recompilation or reexecution Message-ID: <201411090509.sA95975T022213@aojmv0008> Changeset: 443ce16a01b1 Author: rfield Date: 2014-11-08 21:08 -0800 URL: http://hg.openjdk.java.net/kulla/dev/langtools/rev/443ce16a01b1 8064417: Redeclaration of variables, methods, or classes; Without dependent recompilation or reexecution Reviewed-by: briangoetz ! repl/README ! repl/TODO - repl/samples/PP.repl - repl/samples/foo.repl ! repl/src/tool/Repl.java ! repl/src/tool/TaskFactory.java + repl/src/tool/Units.java ! repl/src/tool/WrapFactory.java From robert.field at oracle.com Wed Nov 12 17:58:27 2014 From: robert.field at oracle.com (robert.field at oracle.com) Date: Wed, 12 Nov 2014 17:58:27 +0000 Subject: hg: kulla/dev/langtools: 8064731: REPL: On-going development Message-ID: <201411121758.sACHwRUF007192@aojmv0008> Changeset: 687c68a62973 Author: rfield Date: 2014-11-12 09:58 -0800 URL: http://hg.openjdk.java.net/kulla/dev/langtools/rev/687c68a62973 8064731: REPL: On-going development Summary: Refactor TaskFactory Reviewed-by: briangoetz ! repl/TODO ! repl/src/tool/TaskFactory.java From robert.field at oracle.com Mon Nov 17 19:36:25 2014 From: robert.field at oracle.com (robert.field at oracle.com) Date: Mon, 17 Nov 2014 19:36:25 +0000 Subject: hg: kulla/dev/langtools: Update TODO. Remove jcheck. Message-ID: <201411171936.sAHJaQpc027149@aojmv0008> Changeset: fc4389dcf4a9 Author: rfield Date: 2014-11-17 11:36 -0800 URL: http://hg.openjdk.java.net/kulla/dev/langtools/rev/fc4389dcf4a9 Update TODO. Remove jcheck. - .jcheck/conf ! repl/TODO From robert.field at oracle.com Mon Nov 24 23:42:45 2014 From: robert.field at oracle.com (robert.field at oracle.com) Date: Mon, 24 Nov 2014 23:42:45 +0000 Subject: hg: kulla/dev/langtools: Fix handling of null expression values Message-ID: <201411242342.sAONgjwW002682@aojmv0008> Changeset: b72290ca582c Author: rfield Date: 2014-11-24 15:42 -0800 URL: http://hg.openjdk.java.net/kulla/dev/langtools/rev/b72290ca582c Fix handling of null expression values ! repl/src/tool/RuntimeSupport.java ! repl/src/tool/Util.java From robert.field at oracle.com Tue Nov 25 19:46:39 2014 From: robert.field at oracle.com (robert.field at oracle.com) Date: Tue, 25 Nov 2014 19:46:39 +0000 Subject: hg: kulla/dev/langtools: Update REPL TODO Message-ID: <201411251946.sAPJkd6p022974@aojmv0008> Changeset: f66d02b651c0 Author: rfield Date: 2014-11-25 11:46 -0800 URL: http://hg.openjdk.java.net/kulla/dev/langtools/rev/f66d02b651c0 Update REPL TODO ! repl/TODO From roy.van.rijn at gmail.com Wed Nov 26 15:41:21 2014 From: roy.van.rijn at gmail.com (Roy van Rijn) Date: Wed, 26 Nov 2014 16:41:21 +0100 Subject: Problem running heart.repl sample Message-ID: <31D57517-C3D2-4495-A112-92CCA798B98C@gmail.com> Hey kulla-devs, Today I decided to check out the Kulla branch and fiddle around with the new REPL. Everything seems to work as expected but when running the heart.rep example it always crashes on me. What is the best way to continue? This is what it says: # SIGSEGV (0xb) at pc=0x00007fff96e0d172, pid=68408, tid=1299 # # JRE version: OpenJDK Runtime Environment (9.0) (build 1.9.0-internal-royvanrijn_2014_11_26_15_40-b00) # Java VM: OpenJDK 64-Bit Server VM (1.9.0-internal-royvanrijn_2014_11_26_15_40-b00 mixed mode bsd-amd64 compressed oops) # Problematic frame: # C [libsystem_c.dylib+0x1172] strlen+0x12 All I?ve done is following the AdoptOpenJDK, build the branch and followed the REPL README. This worked flawlessly on my MacBook 10.10.1. In the attachment I?ve added the complete error report. If you have any questions, need more information, or I need to report it somewhere else? please notify me. Roy From vicente.romero at oracle.com Wed Nov 26 23:41:17 2014 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Wed, 26 Nov 2014 15:41:17 -0800 Subject: Problem running heart.repl sample In-Reply-To: <31D57517-C3D2-4495-A112-92CCA798B98C@gmail.com> References: <31D57517-C3D2-4495-A112-92CCA798B98C@gmail.com> Message-ID: <5476651D.3030703@oracle.com> Hi Roy, You forgot the attachment. Thanks, Vicente On 11/26/2014 07:41 AM, Roy van Rijn wrote: > Hey kulla-devs, > > Today I decided to check out the Kulla branch and fiddle around with the new REPL. Everything seems to work as expected but when running the heart.rep example it always crashes on me. What is the best way to continue? > > This is what it says: > > # SIGSEGV (0xb) at pc=0x00007fff96e0d172, pid=68408, tid=1299 > # > # JRE version: OpenJDK Runtime Environment (9.0) (build 1.9.0-internal-royvanrijn_2014_11_26_15_40-b00) > # Java VM: OpenJDK 64-Bit Server VM (1.9.0-internal-royvanrijn_2014_11_26_15_40-b00 mixed mode bsd-amd64 compressed oops) > # Problematic frame: > # C [libsystem_c.dylib+0x1172] strlen+0x12 > > All I?ve done is following the AdoptOpenJDK, build the branch and followed the REPL README. This worked flawlessly on my MacBook 10.10.1. In the attachment I?ve added the complete error report. > > If you have any questions, need more information, or I need to report it somewhere else? please notify me. > > Roy > > > From robert.field at oracle.com Thu Nov 27 00:45:06 2014 From: robert.field at oracle.com (Robert Field) Date: Wed, 26 Nov 2014 16:45:06 -0800 Subject: Problem running heart.repl sample In-Reply-To: <5476651D.3030703@oracle.com> References: <31D57517-C3D2-4495-A112-92CCA798B98C@gmail.com> <5476651D.3030703@oracle.com> Message-ID: <149eea88188.2784.4011f3a8741ca2aabce58b8b81f42d24@oracle.com> Hi Roy, The attachment may have been stripped by the openjdk mail server, you can email the error report directly to me.. This crash is in the JVM, which the REPL uses unmodified. It is possible something in how REPL uses the JVM is triggering a new bug, but first, what JVM are you using? What platform? We have not seen this issue. Thanks, Robert On November 26, 2014 3:41:40 PM Vicente-Arturo Romero-Zaldivar wrote: > Hi Roy, > > You forgot the attachment. > > Thanks, > Vicente > > On 11/26/2014 07:41 AM, Roy van Rijn wrote: > > Hey kulla-devs, > > > > Today I decided to check out the Kulla branch and fiddle around with the > new REPL. Everything seems to work as expected but when running the > heart.rep example it always crashes on me. What is the best way to continue? > > > > This is what it says: > > > > # SIGSEGV (0xb) at pc=0x00007fff96e0d172, pid=68408, tid=1299 > > # > > # JRE version: OpenJDK Runtime Environment (9.0) (build > 1.9.0-internal-royvanrijn_2014_11_26_15_40-b00) > > # Java VM: OpenJDK 64-Bit Server VM > (1.9.0-internal-royvanrijn_2014_11_26_15_40-b00 mixed mode bsd-amd64 > compressed oops) > > # Problematic frame: > > # C [libsystem_c.dylib+0x1172] strlen+0x12 > > > > All I?ve done is following the AdoptOpenJDK, build the branch and > followed the REPL README. This worked flawlessly on my MacBook 10.10.1. In > the attachment I?ve added the complete error report. > > > > If you have any questions, need more information, or I need to report it > somewhere else? please notify me. > > > > Roy > > > > > > > From roy.van.rijn at gmail.com Thu Nov 27 09:28:24 2014 From: roy.van.rijn at gmail.com (Roy van Rijn) Date: Thu, 27 Nov 2014 10:28:24 +0100 Subject: Problem running heart.repl sample In-Reply-To: <149eea88188.2784.4011f3a8741ca2aabce58b8b81f42d24@oracle.com> References: <31D57517-C3D2-4495-A112-92CCA798B98C@gmail.com> <5476651D.3030703@oracle.com> <149eea88188.2784.4011f3a8741ca2aabce58b8b81f42d24@oracle.com> Message-ID: The attachments seem to get stripped from the mailing list. I've send all the deeper details to Robert and Vicente. It isn't relevant for this mailing list, it seems to be a Swing related issue in my own build, has nothing to do with the REPL code. When I set my JVM to the latest JDK 9 release (build 1.9.0-ea-b39) and use my own OS/X build tools.jar the REPL works as expected, including hearts.repl and other Swing examples. Thanks for the quick replies! On Thu, Nov 27, 2014 at 1:45 AM, Robert Field wrote: > Hi Roy, > > The attachment may have been stripped by the openjdk mail server, you can > email the error report directly to me.. > > This crash is in the JVM, which the REPL uses unmodified. It is possible > something in how REPL uses the JVM is triggering a new bug, but first, what > JVM are you using? What platform? > > We have not seen this issue. > > Thanks, > Robert > > > > > On November 26, 2014 3:41:40 PM Vicente-Arturo Romero-Zaldivar > wrote: > >> Hi Roy, >> >> You forgot the attachment. >> >> Thanks, >> Vicente >> >> On 11/26/2014 07:41 AM, Roy van Rijn wrote: >> > Hey kulla-devs, >> > >> > Today I decided to check out the Kulla branch and fiddle around with the >> > new REPL. Everything seems to work as expected but when running the >> > heart.rep example it always crashes on me. What is the best way to continue? >> > >> > This is what it says: >> > >> > # SIGSEGV (0xb) at pc=0x00007fff96e0d172, pid=68408, tid=1299 >> > # >> > # JRE version: OpenJDK Runtime Environment (9.0) (build >> > 1.9.0-internal-royvanrijn_2014_11_26_15_40-b00) >> > # Java VM: OpenJDK 64-Bit Server VM >> > (1.9.0-internal-royvanrijn_2014_11_26_15_40-b00 mixed mode bsd-amd64 >> > compressed oops) >> > # Problematic frame: >> > # C [libsystem_c.dylib+0x1172] strlen+0x12 >> > >> > All I?ve done is following the AdoptOpenJDK, build the branch and >> > followed the REPL README. This worked flawlessly on my MacBook 10.10.1. In >> > the attachment I?ve added the complete error report. >> > >> > If you have any questions, need more information, or I need to report it >> > somewhere else? please notify me. >> > >> > Roy >> > >> > >> > >> > > From roy.van.rijn at gmail.com Thu Nov 27 10:23:11 2014 From: roy.van.rijn at gmail.com (Roy van Rijn) Date: Thu, 27 Nov 2014 11:23:11 +0100 Subject: REPL feedback Message-ID: After some more hours of playing with the actual REPL environment, I've come across some unlisted bugs/TODO items. It seems to be fairly easy to get stuck in an endless ReplParser.parseCompilationUnit loop, for example when you forget 'class': -> A { >> int i = 0; >> } *endless loop here, never reaches EOF in while loop* And testing the parsing, the following (valid Java) isn't correctly parsed: -> int[] i = {1,2,3}; | Error -- | illegal start of expression | int[] i = {1,2,3}; | ^ | Error -- | not a statement | int[] i = {1,2,3}; | ^^ | Error -- | ';' expected | int[] i = {1,2,3}; | Is this kind of testing appreciated and/or needed at this point in time, and are patches or tests welcome? From vicente.romero at oracle.com Thu Nov 27 19:38:01 2014 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Thu, 27 Nov 2014 11:38:01 -0800 Subject: Problem running heart.repl sample In-Reply-To: References: <31D57517-C3D2-4495-A112-92CCA798B98C@gmail.com> <5476651D.3030703@oracle.com> <149eea88188.2784.4011f3a8741ca2aabce58b8b81f42d24@oracle.com> Message-ID: <54777D99.80907@oracle.com> On 11/27/2014 01:28 AM, Roy van Rijn wrote: > The attachments seem to get stripped from the mailing list. I've send > all the deeper details to Robert and Vicente. It isn't relevant for Hi Roy, Thanks, actually Robert is the owner / champion of this project. But thanks a lot for the reports and attachments. Vicente > this mailing list, it seems to be a Swing related issue in my own > build, has nothing to do with the REPL code. > > When I set my JVM to the latest JDK 9 release (build 1.9.0-ea-b39) and > use my own OS/X build tools.jar the REPL works as expected, including > hearts.repl and other Swing examples. > > Thanks for the quick replies! > > > On Thu, Nov 27, 2014 at 1:45 AM, Robert Field wrote: >> Hi Roy, >> >> The attachment may have been stripped by the openjdk mail server, you can >> email the error report directly to me.. >> >> This crash is in the JVM, which the REPL uses unmodified. It is possible >> something in how REPL uses the JVM is triggering a new bug, but first, what >> JVM are you using? What platform? >> >> We have not seen this issue. >> >> Thanks, >> Robert >> >> >> >> >> On November 26, 2014 3:41:40 PM Vicente-Arturo Romero-Zaldivar >> wrote: >> >>> Hi Roy, >>> >>> You forgot the attachment. >>> >>> Thanks, >>> Vicente >>> >>> On 11/26/2014 07:41 AM, Roy van Rijn wrote: >>>> Hey kulla-devs, >>>> >>>> Today I decided to check out the Kulla branch and fiddle around with the >>>> new REPL. Everything seems to work as expected but when running the >>>> heart.rep example it always crashes on me. What is the best way to continue? >>>> >>>> This is what it says: >>>> >>>> # SIGSEGV (0xb) at pc=0x00007fff96e0d172, pid=68408, tid=1299 >>>> # >>>> # JRE version: OpenJDK Runtime Environment (9.0) (build >>>> 1.9.0-internal-royvanrijn_2014_11_26_15_40-b00) >>>> # Java VM: OpenJDK 64-Bit Server VM >>>> (1.9.0-internal-royvanrijn_2014_11_26_15_40-b00 mixed mode bsd-amd64 >>>> compressed oops) >>>> # Problematic frame: >>>> # C [libsystem_c.dylib+0x1172] strlen+0x12 >>>> >>>> All I?ve done is following the AdoptOpenJDK, build the branch and >>>> followed the REPL README. This worked flawlessly on my MacBook 10.10.1. In >>>> the attachment I?ve added the complete error report. >>>> >>>> If you have any questions, need more information, or I need to report it >>>> somewhere else? please notify me. >>>> >>>> Roy >>>> >>>> >>>> >>