Enhancement completion for new class expressions

ShinyaYoshida bitterfoxc at gmail.com
Sun Apr 19 13:27:47 UTC 2015


Hi,
I have the enhancement of the suggestion for  new class expressions.
Please review my patch.

Here is the patch & test:
http://cr.openjdk.java.net/~shinyafox/kulla/201504191/webrev.00/

1. Suggestion for the nested class instantiation:
-> class A{class B{}}
-> new A().new [TAB]
Display all 714 possibilities? (y or n)

Currently, REPL prints the full suggestion.
But it should print only the suggestion of the constructor of B such as
"B()".

2. Suggestion for the instantiation with the fully qualified name or the
static nested class instantiation:
-> new Strin[TAB]
String( StringBuffer( StringBufferInputStream( StringBuilder( etc...
-> new java.lang.Strin[TAB]
String StringBuffer StringBuilder StringIndexOutOfBoundsException

Currently, we get the different suggestion in the new expression between
the simple name and the fully qualified name.
We should get the suggestion with the paren for the instantiation with the
fully qualified name.

In the other case, we could not get the correct suggestion for the static
nested class instantiation:
-> class A{static class B {}}
-> new A.[TAB]
B       class

REPL should print only the suggestion of the constructor of B such as "B()".

Regards,
shinyafox(Shinya Yoshida)


More information about the kulla-dev mailing list