hg: kulla/dev/langtools: Unifying REPL tool and IOContext history; making console history persistent.

Jan Lahoda jan.lahoda at oracle.com
Tue Apr 21 09:59:17 UTC 2015


Fixed and integrated - thanks!

Jan

On 21.4.2015 08:30, ShinyaYoshida wrote:
> Hi Jan,
> In HistoryTest#testHistory, the test failed at last line in my environment:
>
>          while (history.size() > 2)
>              history.remove(0);
>
>          assertEquals(history.currentSessionEntries(),
> Arrays.asList("/*current2*/", "/*current3*/")); // HERE
>
> Could you confirm this case?
>
>
> I found one more failed case.
> Here is the failed test case and the fix for the issue:
> http://cr.openjdk.java.net/~shinyafox/kulla/201504211/webrev.00/
>
> Please review it.
>
> Regards,
> shinyafox(Shinya Yoshida)
>
>
>
>
>
> 2015-04-21 2:11 GMT+09:00 <jan.lahoda at oracle.com
> <mailto:jan.lahoda at oracle.com>>:
>
>     Changeset: 8bf791123094
>     Author:    jlahoda
>     Date:      2015-04-20 19:02 +0200
>     URL: http://hg.openjdk.java.net/kulla/dev/langtools/rev/8bf791123094
>
>     Unifying REPL tool and IOContext history; making console history
>     persistent.
>
>     + repl/src/tool/ConsoleIOContext.java
>     ! repl/src/tool/Repl.java
>     + repl/testng/test/HistoryTest.java
>     ! repl/testng/test/ToolBasicTest.java
>
>


More information about the kulla-dev mailing list