Steps towards integrating Kulla into JDK9

[andrei.eremeev]

Concerning location of REPL tests, I think test/jdk/eval is not the 
right place where the tests should be located. Following the structure 
of the langtools repo, tests for javac, javap and etc. are located in 
test/tools/{javac|javap|etc.}. So my suggestion is to move them to 
tests/tools/jshell. Nevertheless, tests for javadoc is not located in 
test/tools.
What do you think?

Andrei Eremeev

On 04/23/2015 08:18 PM, Robert Field wrote:
> Hearing that you've had positive responses to jshell and hearing no 
> objections on this list, let's definitely go with jshell for the tool 
> name.
>
> As to the name of the package, that depends where the center is. For 
> someone wanting to look at how the tool is implemented jdk.jshell 
> would be right. For an IDE using the evaluation API, jdk.eval or 
> something like that would be appropriate. I think eval applies to 
> both, but jshell only applies to the tool.
>
> You reference consistency with other tills like javadoc. The doclet 
> API is an API provided by the javadoc tool for doclets that it 
> launches. The compiler API is an API for launching the javac tool.  In 
> contrast, the jshell tool is built on the Kulla API. Example of vs 
> implementation of.
>
> -Robert
>
>
>
> On April 22, 2015 11:50:54 PM Brian Goetz <brian.goetz at oracle.com> wrote:
>
>> I have been shopping the name jshell around and it seems to sit well.
>>
>> I suggest we take this farther -- call the module JDK.jshell as well. 
>> This is consistent with other tools, like javadoc, which are both 
>> command line tools and libraries.  And I think it is more evocative 
>> than eval, which is very generic.
>>
>> Sent from my iPhone
>>
>> > On Apr 23, 2015, at 2:21 AM, Robert Field <robert.field at oracle.com> 
>> wrote:
>> >
>> > I have just pushed a change that moves the Kulla source and test 
>> files into their designated places in the langtools directory structure.
>> >
>> > The module is jdk.eval -- so the source files can be found under 
>> src/jdk.eval/
>> >
>> > The source packages are:
>> >    API:                        jdk.eval
>> >    implementation:    jdk.internal.eval.impl and 
>> jdk.internal.eval.impl.remote
>> >    REPL tool:              jdk.internal.eval.jshell
>> >
>> > The latter is up for debate.  Brian suggested the name jshell for 
>> the REPL tool, the more it has sat in my head the more I like it, 
>> there is nothing cognitively nor linguistically natural about REPL.
>> >
>> > The tests have been moved to test/jdk/eval
>> > I have flatten the one stress test into this.
>> >
>> > The idea is to have the normal make scripts also build Kulla.  This 
>> does not currently work, a "make images" falls over almost 
>> immediately.  Anyone with experience that can help with this, please 
>> step forward.  Note: part of what needs to happen is that jline need 
>> to be rolled into the JDK; Though this is not the immediate failure.
>> >
>> > For now, I have adjusted the old scripts to the new locations, so, 
>> repl/scripts/   compile.sh  run.sh test.sh still work when run from 
>> repl/
>> >
>> > Thanks,
>> > Robert
>> >
>> >
>
>