Kulla: JShell API ready for round two review

[Robert Field]

Hmmm, disappearing it last minute would be easy but seems problematic for last minute bugs.

Seems like I should bite the bullet and do the separate little JShell debugging package.

	• 8133152 JShell API: hide internal debugging support class


-Robert

> On Aug 5, 2015, at 7:13 AM, Brian Goetz <brian.goetz at oracle.com> wrote:
> 
> It should be demoted to package visibility before shipping, then.
> 
> On 8/4/2015 4:51 PM, Robert Field wrote:
>> 
>>> On Aug 3, 2015, at 7:45 AM, Brian Goetz <brian.goetz at oracle.com> wrote:
>>> 
>>>>> Would need to be a non-exported *package*.  Exports work at the
>>>>> package granularity.
>>>> 
>>>> Would it be OK just to hide it from the javadoc (don’t remember how
>>>> to do that, but remember that there is a way)?
>>> 
>>> Better than nothing, but let's try to find a right place for it first.
>>> 
>>> If this is for the *tool* and not for the JShell API, shouldn't it go in the package with the tool?  It wouldn't be so out of place there.
>> 
>> It is for controlling debugging of the API.  I debug the API from the tool.
>> 
>> It has to be in the API package because that is where all the debugging hooks are.  Well, it could be in a hidden separate package with registration but still would need to be public.
>> 
>> For context: the undocumented command “/debug <debug-flags>” calls into it to turn on debug files for a given JShell instance.
>> 
>> -Robert
>> 
>>> 
>>> 
>>