Kulla: JShell API ready for round two review

[Robert Field]

There are a lot of ways one could slice the state, but having a single 
enum that represents the state seems most simple to me.  What do others 
think?

The active-ness is a query on the Status (tracksupdates) as is its 
visibility (isDefined).

A SUCCESS dimension doesn't make sense for many of the Status states.

EXPLICIT/IMPLICIT is not part of the Status, that is part of the 
transition and is encoded in the event.

Thanks,
Robert

On 08/10/15 07:59, Maurizio Cimadamore wrote:
>
>
> On 10/08/15 15:43, Maurizio Cimadamore wrote:
>> Of course, now all three of those are needed, as the state is all 
>> folded together; but with a richer state representation, I can easily 
>> see (3) going down to only 3 slots (NON_EXISTENT, ACTIVE, INACTIVE) 
> And, by folding 4 with 1, I think only three axis are needed:
>
> 1) Last compilation result kind
>     SUCCESS
>     CORRALLED
>     FAILED
>
> 2) Last compilation kind
>     EXPLICIT
>     IMPLICIT
>
> 3) Snippet state
>    NON_EXISTENT
>    ACTIVE
>    INACTIVE
>
> Note that the snippet state is really (3) - I believe (1) and (2) 
> together are an optional extra info associated with the snippet status 
> (only when the snippet is ACTIVE).
>
> This would lead to something like this:
>
> class Status {
>     enum Kind {
>        NON_EXISTENT,
>        ACTIVE,
>        INACTIVE
>     }
>
>     Optional<CompilationStatus> compilationStatus;
> }
>
> class CompilationStatus {
>    enum Kind {
>        IMPLICIT,
>        EXPLICIT;
>    }
>
>    enum Result {
>        SUCCESS,
>        CORRRALLED,
>        FAILED;
>    }
>
>    Kind kind; Result result;
> }
>
> Maurizio