RFR 8143952: JShell: space in class path causes remote launch failure

[Robert Field]

This is a very nice clean-up (as well as being a fix to a problem that 
has bitten many users).  In a job, long long ago, part of the culture 
was that "Code Deletion Engineer" was one of the highest honors.

My thumb is up!

-Robert

On 12/11/15 10:08, Jan Lahoda wrote:
> Hello,
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8143952
>
> Problem: when running the RemoteAgent (the process in which the user's 
> code is being run), a problem occurs if the -classpath or 
> -Xbootclasspath/p: argument contains a space, as the spaces are not 
> properly quoted.
>
> We currently construct a "connection spec" string in ExecutionControl, 
> and then parse it in JDIConnection to construct connector arguments. 
> So we would need to keep some kind of quoting through this process. 
> This seems a little bit unnecessary - why not pass the arguments as a 
> map (with proper quoting of the values in the map), avoiding the parsing?
>
> Patch that implements this:
> http://cr.openjdk.java.net/~jlahoda/8143952/webrev.00/
>
> Thanks to Robert and Maurizio for their comments so far on the patch.
>
> Any feedback is welcome.
>
> Thanks!
>
> Jan