RFR 8145263: JShell API: Change the format of SourceCodeAnalysis#documentation

[Jan Lahoda]

Hi Shinya,

Generally, looks good, thanks for looking at this! Two comments:
-for parameter names, I was hoping we could get them from the sources 
(if/when available), but we are not doing that now, and hiding synthetic 
parameter names makes sense to me. So this is OK, and if we at some 
point start to parse parameter names from the sources, we can tweak the 
code to do the right thing.

-not sure if marking constructors with ".new" 
("type-name.new(<parameters>)") will be clear - do you think the 
traditional form ("type-name(<parameters>)")  is unclear?

Thanks,
     Jan

On 13.12.2015 07:33, ShinyaYoshida wrote:
> Hi Jan and Robert,
> I'd like to propose changing the format of SourceCodeAnalysis#documentation.
>
> The detail of the change is on the issue 8145263:
> https://bugs.openjdk.java.net/browse/JDK-8145263
> Please see it.
>
> You can see the more example in the test of my patch.
>
> Patch is here:
> http://cr.openjdk.java.net/~shinyafox/kulla/8145263/webrev.00/
>
> Please consider my proposal and review the patch.
>
> Regards,
> shinyafox(Shinya Yoshida)