More tests and API to set output stream

[andrei.eremeev]

Adding kulla-dev to the thread.

Andrei Eremeev

On 02/13/2015 11:55 PM, andrei.eremeev wrote:
> Hi Robert,
>
> Please, find some tests for currentDeclaration() here: 
> http://cr.openjdk.java.net/~aeremeev/current_declaration.00/
> The patch is comprised of tests for "Test that replaced Snippets have 
> null Declarations" and some clean-up.
>
> Could you clarify what you mean in the following statement?
> > Test that stack traces have the Snippet id.  assertException is not 
> comparing filename, and test should be changed to fetch Snippet.id() 
> to compare.
> assertException compares actual stack trace with expected one; 
> expected stack trace contains golden information about filenames, 
> which are Snippet.id(). ExecutionException does not contain 
> information about Snippet.
>
> To test REPL output, I need an ability to set a custom stream writer 
> to REPL. Currently, all output goes to stdout/stderr. I suggest adding 
> API to set output stream and using one stream, as it is done in javac. 
> Thus, tests for tool will look like:
>     REPL.start(input, output, args);
>     // checking output stream.
> Please, find prototype of this feature in attachments. What do you 
> think about it?
>
> Andrei Eremeev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: output.diff
Type: text/x-patch
Size: 13878 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/kulla-dev/attachments/20150216/4c911efb/output-0001.diff>