hg: kulla/dev/langtools: Streamification

Robert Field robert.field at oracle.com
Fri Jul 17 06:25:01 UTC 2015


Hi,

Brian is on vacation. But it looks like you already got his thumbs-up, so 
go for it.

Thanks,
Robert



On July 16, 2015 10:26:17 PM ShinyaYoshida <bitterfoxc at gmail.com> wrote:

> Hi Brian and all,
> Sorry for my late confirm.
> I couldn't concentrate my effort on Kulla because I had to make my hands-on
> event of Lambda & StreamAPI.
>
> Can I push this patch?
>
> Regards,
> shinyafox(Shinya Yoshida)
>
> 2015-06-30 4:04 GMT+09:00 Brian Goetz <brian.goetz at oracle.com>:
>
> > Reviewed.  +1.
> >
> >
> > On 6/29/2015 12:57 PM, ShinyaYoshida wrote:
> >
> >> Hi Robert and Brian,
> >> I have the streamified code for SourceCodeAnalysisImpl.
> >> Could you review this?
> >>
> >> webrev:
> >> http://cr.openjdk.java.net/~shinyafox/kulla/streamification.00/webrev.00/
> >>
> >> Regards,
> >> shinyafox(Shinya Yoshida)
> >>
> >>
> >> 2015-06-24 5:43 GMT+09:00 <robert.field at oracle.com
> >> <mailto:robert.field at oracle.com>>:
> >>
> >>     Changeset: 06f3585a609b
> >>     Author:    rfield
> >>     Date:      2015-06-23 13:43 -0700
> >>     URL: http://hg.openjdk.java.net/kulla/dev/langtools/rev/06f3585a609b
> >>
> >>     Streamification
> >>     Contributed-by: brian.goetz at oracle.com <mailto:brian.goetz at oracle.com
> >> >
> >>
> >>     ! src/jdk.jshell/share/classes/jdk/internal/jshell/impl/Eval.java
> >>     !
> >> src/jdk.jshell/share/classes/jdk/internal/jshell/impl/JShellImpl.java
> >>     ! src/jdk.jshell/share/classes/jdk/internal/jshell/impl/KeyMap.java
> >>     !
> >>
> >> 
> src/jdk.jshell/share/classes/jdk/internal/jshell/impl/MaskCommentsAndModifiers.java
> >>     !
> >> src/jdk.jshell/share/classes/jdk/internal/jshell/impl/SnippetMaps.java
> >>     !
> >> src/jdk.jshell/share/classes/jdk/internal/jshell/impl/TaskFactory.java
> >>
> >>
> >>


More information about the kulla-dev mailing list