RFR 8129935: JShell Tool: Variable decl which is for the variable of the type of multi-byte character shows the unicode string as the type

ShinyaYoshida bitterfoxc at gmail.com
Sun Jul 19 07:11:34 UTC 2015


Hi Robert,
Thank you for your review and advice.

I've just update my webrev:
http://cr.openjdk.java.net/~shinyafox/kulla/8129935/webrev.01/

- matching codes to the current repository model
- making the test as an isolated test

Could you review this again?

Regards,
shinyafox(Shinya Yoshida)


2015-07-17 15:20 GMT+09:00 Robert Field <robert.field at oracle.com>:

>   Thanks Shinya.
>
> Looks good, but keep in mind that almost every source file in JShell has
> changed substantially in the last couple weeks because of the API upheaval
> work I've been doing -- including these two files. So rather than merging
> you might want to pull a fresh repo and cut-and-paste these changes. While
> you are at it, might be better to make the Unicode tests separate new tests.
>
> Thanks,
> Robert
>
> On July 16, 2015 10:40:49 PM ShinyaYoshida <bitterfoxc at gmail.com> wrote:
>
>> Hi Robert,
>> Do you have any opinion for this?
>>
>> Regards,
>> shinyafox(Shinya Yoshida)
>>
>> 2015-06-26 20:33 GMT+09:00 ShinyaYoshida <bitterfoxc at gmail.com>:
>>
>>> Hi Robert,
>>> Please review this patch:
>>>
>>> bugs:
>>> https://bugs.openjdk.java.net/browse/JDK-8129935
>>>
>>> webrev:
>>> http://cr.openjdk.java.net/~shinyafox/kulla/8129935/webrev.00/
>>>
>>> Regards,
>>> shinyafox(Shinya Yoshida)
>>>
>>
>>


More information about the kulla-dev mailing list