xxs: RFR 8081780: JShell tool: Completion contains $REPL00DOESNOTMATTER

Robert Field robert.field at oracle.com
Wed Jun 3 17:08:44 UTC 2015


Hi Shinya,

Not a full review, but, defining DOESNOTMATTER is good, but then it 
should match the code that creates it, so, Eval.trialCompile() should 
use this constant,

Thanks,
Robert

On 06/03/15 09:58, ShinyaYoshida wrote:
> Hi Jan,
> Please review this.
>
> webrev:
> http://cr.openjdk.java.net/~shinyafox/kulla/8081780/webrev.00/
>
> bugs:
> https://bugs.openjdk.java.net/browse/JDK-8081780
>
> Regards,
> shinyafox(Shinya Yoshida)



More information about the kulla-dev mailing list